launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

Deryck Hodge has proposed merging lp:~deryck/launchpad/tags-count-typo-670352 into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #670352 Official tag lists shows "{count}" rather than a number on +manage-official-tags
  https://bugs.launchpad.net/bugs/670352


This branch fixes the official bug tag management page to not show {count} when there are no bugs for a tag.  This was a JavaScript error where the script was only checking for 0 and not for undefined also.
-- 
https://code.launchpad.net/~deryck/launchpad/tags-count-typo-670352/+merge/39982
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/tags-count-typo-670352 into lp:launchpad/devel.

=== modified file 'lib/lp/bugs/javascript/official_bug_tags.js'
--- lib/lp/bugs/javascript/official_bug_tags.js	2010-07-11 00:32:53 +0000
+++ lib/lp/bugs/javascript/official_bug_tags.js	2010-11-03 15:57:48 +0000
@@ -160,7 +160,7 @@
  * @method make_tag_li
  */
 var make_tag_li = function(item) {
-    if (item.count === 0) {
+    if (item.count === 0 || item.count === undefined) {
       item.count = '';
     }
     item._tag_id = mangle_id(item.tag);