launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

The proposal to merge lp:~wallyworld/launchpad/fix-enable-review-type into lp:launchpad has been updated.

Description changed to:

= Summary =

As per bug 671665, when the popup selection widget is used to choose the reviewer for a mp, the review type field does not become enabled.

= Implementation =

There are 2 parts to the fix.
1. Enhance lazr-js so that focus is returned to the input field when the user finishes selecting the value from the popup
2. Change the mechanism to trigger the review_type field enable update from onchange to onblur

The enabled processing will occur when the user tabs out of the reviewer field, and will work in the same way whether the reviewer value is typed or entered using the popup.

This branch should be merged only once lazr-js is upgraded. The relevant branch there is lp:~wallyworld/lazr-js/popup-selection-focus-fix

= Tests =

The code.windmill.test_branchmergeproposal_review.py test was enhanced to the that the correct behaviour occurred when using the popup selector.

bin/test -vvt test_branchmergeproposal_review

= Lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/code/templates/branch-register-merge.pt
  lib/lp/code/windmill/tests/test_branchmergeproposal_review.py


-- 
https://code.launchpad.net/~wallyworld/launchpad/fix-enable-review-type/+merge/40302
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/fix-enable-review-type into lp:launchpad.