launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Stuart Bishop has proposed merging lp:~stub/launchpad/trivial into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #654639 Python 2.5 compatibility code to remove
  https://bugs.launchpad.net/bugs/654639
  #667883 database performance report: fold edge into lpnet
  https://bugs.launchpad.net/bugs/667883


Use the new noparam modifier to the TALES memcache commands to reuse the cache on the same page with different query parameters. At the moment, for example, https://bugs.launchpad.net/ubuntu/+bug/1 and https://bugs.launchpad.net/ubuntu/+bug/1?comments=all do not share the cache of rendered bug comments. This branch fixes that.
-- 
https://code.launchpad.net/~stub/launchpad/trivial/+merge/40431
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stub/launchpad/trivial into lp:launchpad/devel.

=== modified file 'lib/lp/bugs/templates/bugcomment-box.pt'
--- lib/lp/bugs/templates/bugcomment-box.pt	2010-07-29 11:20:47 +0000
+++ lib/lp/bugs/templates/bugcomment-box.pt	2010-11-09 14:31:14 +0000
@@ -9,7 +9,7 @@
               python: comment.show_for_admin and 'adminHiddenComment' or ''"
   tal:attributes="class string:boardComment ${remote_bug_comment_class}
                  ${admin_comment_hidden_class}"
-  tal:content="cache:authenticated,comment/rendered_cache_time,comment/index">
+  tal:content="cache:authenticated noparam,comment/rendered_cache_time,comment/index">
 
   <div class="boardCommentDetails">
     <table>

=== modified file 'lib/lp/bugs/templates/bugtarget-portlet-latestbugs.pt'
--- lib/lp/bugs/templates/bugtarget-portlet-latestbugs.pt	2010-05-17 17:29:08 +0000
+++ lib/lp/bugs/templates/bugtarget-portlet-latestbugs.pt	2010-11-09 14:31:14 +0000
@@ -4,7 +4,7 @@
   xmlns:i18n="http://xml.zope.org/namespaces/i18n";
   class="portlet" id="portlet-latest-bugs"
   tal:condition="view/latestBugTasks"
-  tal:content="cache:private, 1 hour">
+  tal:content="cache:private noparam, 1 hour">
   <h2><span class="see-all"><a
       tal:attributes="href context/fmt:url:bugs">All bugs</a></span>
     Latest bugs reported</h2>

=== modified file 'lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt'
--- lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt	2010-07-21 16:48:14 +0000
+++ lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt	2010-11-09 14:31:14 +0000
@@ -3,7 +3,7 @@
      xmlns:i18n="http://xml.zope.org/namespaces/i18n";
      class="portletBody">
   <div class="section" tal:define="tags_cloud_data view/tags_cloud_data">
-    <tal:tags content="cache:public, 60 minutes">
+    <tal:tags content="cache:public noparam, 60 minutes">
         <h2 tal:condition="tags_cloud_data">Tags</h2>
         <div style="text-align: justify">
           <a tal:repeat="tag_info view/tags_cloud_data"