launchpad-reviewers team mailing list archive

[Tim Penhey <tim.penhey@xxxxxxxxxxxxx>]

Tim Penhey has proposed merging lp:~thumper/launchpad/recipe-builds into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #671077 "Build records" is jargony
  https://bugs.launchpad.net/bugs/671077


Very simple branch that adds an adapter for build status images, and changes the title of "Build records" to "Latest builds".
-- 
https://code.launchpad.net/~thumper/launchpad/recipe-builds/+merge/40489
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~thumper/launchpad/recipe-builds into lp:launchpad/devel.

=== modified file 'lib/lp/app/browser/configure.zcml'
--- lib/lp/app/browser/configure.zcml	2010-10-22 03:35:41 +0000
+++ lib/lp/app/browser/configure.zcml	2010-11-09 23:14:52 +0000
@@ -203,6 +203,12 @@
       factory="lp.app.browser.tales.BuildImageDisplayAPI"
       name="image"
       />
+  <adapter
+      for="lp.code.interfaces.sourcepackagerecipebuild.ISourcePackageRecipeBuild"
+      provides="zope.traversing.interfaces.IPathAdapter"
+      factory="lp.app.browser.tales.BuildImageDisplayAPI"
+      name="image"
+      />
 
   <adapter
       for="lp.soyuz.interfaces.archive.IArchive"

=== modified file 'lib/lp/code/templates/sourcepackagerecipe-index.pt'
--- lib/lp/code/templates/sourcepackagerecipe-index.pt	2010-08-05 18:20:28 +0000
+++ lib/lp/code/templates/sourcepackagerecipe-index.pt	2010-11-09 23:14:52 +0000
@@ -81,7 +81,7 @@
   </div>
   <div class="yui-g">
     <div class="portlet">
-      <h2>Build records</h2>
+      <h2>Latest builds</h2>
         <table class="listing" style='margin-bottom: 1em;'>
           <thead>
             <tr>
@@ -93,13 +93,15 @@
           </thead>
           <tbody>
             <tr tal:repeat="build view/builds">
+              <tal:build-view define="buildview nocall:build/@@+index">
               <td>
-                <a tal:content="build/@@+index/status"
+                <span tal:replace="structure build/image:icon" />
+                <a tal:content="buildview/status"
                    tal:attributes="href build/fmt:url"></a>
               </td>
               <td>
-                <tal:date replace="build/@@+index/date/fmt:displaydate" />
-                <tal:estimate condition="build/@@+index/estimate">
+                <tal:date replace="buildview/date/fmt:displaydate" />
+                <tal:estimate condition="buildview/estimate">
                 (estimated)
                 </tal:estimate>
               </td>
@@ -110,6 +112,7 @@
               <td>
                 <tal:archive replace="structure build/archive/fmt:link"/>
               </td>
+              </tal:build-view>
             </tr>
           </tbody>
         </table>