launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Stuart Bishop has proposed merging lp:~stub/launchpad/pending-db-changes into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #628637 staging replication logs get lost
  https://bugs.launchpad.net/bugs/628637
  #644975 Export OpenIdIdentifier to Canonical SSO
  https://bugs.launchpad.net/bugs/644975


Currently, we have to manually change database permissions when doing cherry picks. It would be great if we could just run security.py.

Unfortunately, this can fail. If you run security.py before updating the code you can remove permissions currently required by the running system creating OOPSes. If you run it after, there is a window where the new code is running with incorrect permissions creating OOPSes.

This branch adds the --no-revoke flag. This means the script only adds permissions, and doesn't revoke existing ones. So we can now run 'security.py --no-revoke' against the live system making the permissions the union of those already granted and those defined in security.cfg. We can then upgrade the code, which will be running with all required permissions. After all systems are running the new code, we can then run 'security.py --revoke' to remove permissions that are no longer required.
-- 
https://code.launchpad.net/~stub/launchpad/pending-db-changes/+merge/40627
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stub/launchpad/pending-db-changes into lp:launchpad.

=== modified file 'database/replication/slon_ctl.py'
--- database/replication/slon_ctl.py	2010-09-07 12:20:34 +0000
+++ database/replication/slon_ctl.py	2010-11-11 14:22:26 +0000
@@ -116,7 +116,7 @@
             "--exec", "/usr/bin/slon",
             "--startas", "/bin/sh",
             "--", "-c",
-            "slon -p %s %s %s '%s' > %s" % (
+            "slon -p %s %s %s '%s' >> %s" % (
                 pidfile, slon_args, replication.helpers.CLUSTERNAME,
                 node.connection_string, logfile)]
         log.debug("Running %s" % repr(cmd))