launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/link-checker-oops into lp:launchpad/devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #671390 +check-links triggering an OOPS
  https://bugs.launchpad.net/bugs/671390


=Summary =

See bug 671390. On oops is generated if +check-links is invoked directly.

= Implementatiom =

The server side code assumed the client javascript would only pass valid data, and this is true. However, if the +check-links is invoked directly, then no data is present in the request and a check is needed for this.

= Tests =

Added new test case to test_linkchecker.
bin/test -vvt test_linkchecker

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/app/browser/linkchecker.py
  lib/lp/app/browser/tests/test_linkchecker.py
-- 
https://code.launchpad.net/~wallyworld/launchpad/link-checker-oops/+merge/40680
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/link-checker-oops into lp:launchpad/devel.