launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #01946
Re: [Merge] lp:~jtv/launchpad/parallel-make into lp:launchpad/devel
Review: Approve code*
This branch looks good. Edwin, my review mentor, will also be reviewing this branch.
The transformation you applied is straightforward. (And welcome, my first day working on LP I ran into this issue).
It's probably not worth adding, because changes are rare, but for completeness I'll note that the buildout_bin rule has an unlisted dependency: buildout.cfg uses template files in buildout-templates (which at the moment is just _pythonpath.py.in).
--
https://code.launchpad.net/~jtv/launchpad/parallel-make/+merge/41108
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/parallel-make into lp:launchpad/devel.
References