launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

Aaron Bentley has proposed merging lp:~abentley/launchpad/more-harness into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


= Summary =
Add useful stuff to harness

== Proposed fix ==
Add removeSecurityProxy, canonical_url, utc.

== Pre-implementation notes ==
None

== Implementation details ==
None

== Tests ==
None

== Demo and Q/A ==
None


= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/canonical/database/harness.py

./lib/canonical/database/harness.py
      47: 'from storm.locals import *' used; unable to detect undefined names
      48: 'from storm.expr import *' used; unable to detect undefined names
      29: 'canonical_url' imported but unused
      49: 'DEFAULT_FLAVOR' imported but unused
      49: 'SLAVE_FLAVOR' imported but unused
      26: 'removeSecurityProxy' imported but unused
      22: 'utc' imported but unused
      23: 'transaction' imported but unused
      41: 'verifyObject' imported but unused
      44: 'rlcompleter' imported but unused
      71: E501 line too long (82 characters)
      71: Line exceeds 78 characters.
-- 
https://code.launchpad.net/~abentley/launchpad/more-harness/+merge/41619
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abentley/launchpad/more-harness into lp:launchpad.

=== modified file 'lib/canonical/database/harness.py'
--- lib/canonical/database/harness.py	2010-11-08 13:23:22 +0000
+++ lib/canonical/database/harness.py	2010-11-23 16:23:58 +0000
@@ -19,11 +19,14 @@
 import os
 import sys
 
+from pytz import utc
 import transaction
 
 from zope.component import getUtility
+from zope.security.proxy import removeSecurityProxy
 
 from canonical.launchpad.scripts import execute_zcml_for_scripts
+from canonical.launchpad.webapp import canonical_url
 
 from lp.answers.model.question import Question
 from lp.blueprints.model.specification import Specification