launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

Gavin Panella has proposed merging lp:~allenap/launchpad/zope-test-in-subprocess-unicode-issue into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


Pass a decoded stream reader to subunit.TestProtocolServer. See the thread containing https://lists.launchpad.net/launchpad-dev/msg05732.html for more information.
-- 
https://code.launchpad.net/~allenap/launchpad/zope-test-in-subprocess-unicode-issue/+merge/41886
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/launchpad/zope-test-in-subprocess-unicode-issue into lp:launchpad.

=== modified file 'lib/lp/testing/__init__.py'
--- lib/lp/testing/__init__.py	2010-11-25 14:15:30 +0000
+++ lib/lp/testing/__init__.py	2010-11-25 16:58:55 +0000
@@ -46,6 +46,7 @@
     'ZopeTestInSubProcess',
     ]
 
+import codecs
 from contextlib import contextmanager
 from datetime import (
     datetime,
@@ -864,7 +865,7 @@
             result = super(ZopeTestResult, result)
             # Accept the result from the child process.
             protocol = subunit.TestProtocolServer(result)
-            protocol.readFrom(fdread)
+            protocol.readFrom(codecs.getreader("utf8")(fdread))
             fdread.close()
             os.waitpid(pid, 0)