launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/launchpad/recife-getpofileswithtranslationcredits into lp:launchpad/db-devel with lp:~jtv/launchpad/recife-pre-stats as a prerequisite.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers): code


= Recife: fix getPOFilesWithTranslationCredits =

This fixes up POFileSet.getPOFilesWithTranslationCredits for Rosetta's new "Recife" data model.  In a nutshell, if the caller passes untranslated=True, the method should look not for translation credits with is_current_ubuntu==False but for ones with is_current_ubuntu==False or is_current_upstream==False depending on what kind of template the POFile is for—Ubuntu or upstream respectively.

To test:
{{{
./bin/test -vvc lp.translations.tests.test_pofile
}}}


No lint,

Jeroen
-- 
https://code.launchpad.net/~jtv/launchpad/recife-getpofileswithtranslationcredits/+merge/42083
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/recife-getpofileswithtranslationcredits into lp:launchpad/db-devel.