| Thread Previous • Date Previous • Date Next • Thread Next |
j.c.sackett has proposed merging lp:~jcsackett/launchpad/launchpad-ids-270310 into lp:launchpad. Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: #270310 launchpad person page should show their launchpad-id https://bugs.launchpad.net/bugs/270310 Summary ======= Launchpad id, while displayed in the url and the +edit view (and as part of the login data on the left), isn't actually displayed on a users page. Given that documentation references a "launchpad id" and nothing is called this on the user page, a bug was confirmed to add that to the overview. Trivially, this branch adds an entry for Launchpad id on the contact portlet. Demo & QA ========= Go to launchpad.dev/~mark. An entry of Launchpad id exists with the data "mark". Lint ==== make lint output: = Launchpad lint = Checking for conflicts and issues in changed files. Linting changed files: lib/lp/registry/templates/person-portlet-contact-details.pt -- https://code.launchpad.net/~jcsackett/launchpad/launchpad-ids-270310/+merge/42190 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/launchpad-ids-270310 into lp:launchpad.
=== modified file 'lib/lp/registry/templates/person-portlet-contact-details.pt'
--- lib/lp/registry/templates/person-portlet-contact-details.pt 2010-08-16 13:14:31 +0000
+++ lib/lp/registry/templates/person-portlet-contact-details.pt 2010-11-29 23:07:18 +0000
@@ -47,6 +47,11 @@
</dd>
</dl>
+ <dl id="launchpad-id">
+ <dt>Launchpad id:</dt>
+ <dd tal:content="context/name"/>
+ </dl>
+
<dl tal:condition="view/should_show_jabberids_section" id="jabber-ids">
<dt>Jabber:
<a tal:replace="structure overview_menu/editjabberids/fmt:icon" />
| Thread Previous • Date Previous • Date Next • Thread Next |
