← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~jtv/launchpad/recife-statistics-aftershock into lp:launchpad/db-devel

 

Review: Needs Fixing code*
Hi Jeroen,

This looks great, I just have one comment.

In the first unit test, you assign self.now() to a variable, and then a few lines later use self.now(). You also assign to it multiple times.

-- 
https://code.launchpad.net/~jtv/launchpad/recife-statistics-aftershock/+merge/42274
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/recife-statistics-aftershock into lp:launchpad/db-devel.



References