launchpad-reviewers team mailing list archive

[James Westby <jw+debian@xxxxxxxxxxxxxxx>]

On Thu, 02 Dec 2010 12:11:14 -0000, Guilherme Salgado <salgado@xxxxxxxxxxxxx> wrote:
> I don't think we use the field you changed for constructing any forms,
> so I'd be surprised if this has any side effects.

That's good news.

> As we talked on IRC, I thought just exporting IBugLinkTarget as an entry
> would make it work, but apparently it didn't?

Nope, I had this diff minus the inheritence change and it didn't
work. I'm asking again for some advice on this on IRC.

> A trivial conflict here.

Fixed.

> I think you should use Reference instead of Object here.  I don't
> remember why we have Reference (which is a wrapper around Object), but
> that's what we seem to use in conjunction with CollectionFields.

Ok.

> Also, this interface is provided only by ISpecification and IQuestion
> (which is not yet exposed on the API), so I think it makes sense to
> expose it only on the 'devel' version of the webservice, like all the
> Blueprints bits that are currently exposed. To do that you just need a
> couple extra arguments to exported:
> 
>     ('devel', dict(exported=True)), exported=False)

I also fixed the docstring to match the current state of the code.

Thanks,

James
-- 
https://code.launchpad.net/~james-w/launchpad/export-specification-bug-links/+merge/42426
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~james-w/launchpad/export-specification-bug-links into lp:launchpad.