launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

Gavin Panella has proposed merging lp:~allenap/launchpad/prune-bug-notification-recipients into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


Remove a couple of unused methods in BugNotificationRecipients.
-- 
https://code.launchpad.net/~allenap/launchpad/prune-bug-notification-recipients/+merge/42972
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/launchpad/prune-bug-notification-recipients into lp:launchpad.

=== modified file 'lib/lp/bugs/doc/bugnotificationrecipients.txt'
--- lib/lp/bugs/doc/bugnotificationrecipients.txt	2010-10-18 22:24:59 +0000
+++ lib/lp/bugs/doc/bugnotificationrecipients.txt	2010-12-07 16:51:52 +0000
@@ -87,15 +87,9 @@
   >>> no_priv = personset.getByEmail("no-priv@xxxxxxxxxxxxx")
   >>> recipients.addAssignee(no_priv)
 
-  >>> daf = personset.getByEmail("daf@xxxxxxxxxxxxx")
-  >>> recipients.addDistroBugSupervisor(daf, debian)
-
   >>> carlos = personset.getByEmail("carlos@xxxxxxxxxxxxx")
   >>> recipients.addStructuralSubscriber(carlos, pmount)
 
-  >>> marilize = personset.getByEmail("marilize@xxxxxxx")
-  >>> recipients.addUpstreamBugSupervisor(marilize, alsa_utils)
-
   >>> testtest = personset.getByEmail("testtest@xxxxxxxxxxxxx")
   >>> recipients.addRegistrant(testtest, gnomebaker)
 
@@ -105,15 +99,9 @@
   carlos@xxxxxxxxxxxxx
       Subscriber (pmount in debian)
       You received this bug notification because you are subscribed to pmount in debian.
-  daf@xxxxxxxxxxxxx
-      Bug Supervisor (Debian)
-      You received this bug notification because you are the bug supervisor for Debian.
   foo.bar@xxxxxxxxxxxxx
       Subscriber of Duplicate
       You received this bug notification because you are a direct subscriber of a duplicate bug.
-  marilize@xxxxxxx
-      Bug Supervisor (alsa-utils)
-      You received this bug notification because you are the bug supervisor for alsa-utils.
   no-priv@xxxxxxxxxxxxx
       Assignee
       You received this bug notification because you are a bug assignee.
@@ -143,15 +131,9 @@
   >>> no_priv = personset.getByEmail("no-priv@xxxxxxxxxxxxx")
   >>> recipients.addAssignee(no_priv)
 
-  >>> daf = personset.getByEmail("daf@xxxxxxxxxxxxx")
-  >>> recipients.addDistroBugSupervisor(daf, debian)
-
   >>> carlos = personset.getByEmail("carlos@xxxxxxxxxxxxx")
   >>> recipients.addStructuralSubscriber(carlos, pmount)
 
-  >>> marilize = personset.getByEmail("marilize@xxxxxxx")
-  >>> recipients.addUpstreamBugSupervisor(marilize, alsa_utils)
-
   >>> testtest = personset.getByEmail("testtest@xxxxxxxxxxxxx")
   >>> recipients.addRegistrant(testtest, gnomebaker)
 
@@ -164,15 +146,9 @@
   carlos@xxxxxxxxxxxxx
       Subscriber (pmount in debian) via Bug 2
       You received this bug notification because you are subscribed to pmount in debian (via bug 2).
-  daf@xxxxxxxxxxxxx
-      Bug Supervisor (Debian) via Bug 2
-      You received this bug notification because you are the bug supervisor for Debian (via bug 2).
   foo.bar@xxxxxxxxxxxxx
       Subscriber of Duplicate via Bug 2
       You received this bug notification because you are a direct subscriber of a duplicate bug (via bug 2).
-  marilize@xxxxxxx
-      Bug Supervisor (alsa-utils) via Bug 2
-      You received this bug notification because you are the bug supervisor for alsa-utils (via bug 2).
   no-priv@xxxxxxxxxxxxx
       Assignee via Bug 2
       You received this bug notification because you are a bug assignee (via bug 2).
@@ -200,31 +176,19 @@
   >>> name20 = personset.getByName("name20")
   >>> recipients.addStructuralSubscriber(name20, pmount)
 
-  >>> name18 = personset.getByName("name18")
-  >>> recipients.addUpstreamBugSupervisor(name18, alsa_utils)
-
   >>> vcs_imports = personset.getByName("vcs-imports")
   >>> recipients.addRegistrant(vcs_imports, gnomebaker)
 
   >>> shipit_admins = personset.getByName("shipit-admins")
   >>> recipients.addDirectSubscriber(shipit_admins)
 
-  >>> launchpad_buildd_admins = personset.getByName("launchpad-buildd-admins")
-  >>> recipients.addDistroBugSupervisor(launchpad_buildd_admins, debian)
-
 You'll notice that the rationales this time state clearly which team
 membership is causing us to send mail.
 
   >>> print_rationales(recipients)
-    andrew.bennetts@xxxxxxxxxxxxxxx
-        Bug Supervisor (alsa-utils) @name18
-        You received this bug notification because you are a member of Ubuntu Gnome Team, which is the bug supervisor for alsa-utils.
     carlos@xxxxxxxxxxxxx
         Subscriber of Duplicate @testing-spanish-team
         You received this bug notification because you are a member of testing Spanish team, which is a subscriber of a duplicate bug.
-    celso.providelo@xxxxxxxxxxxxx
-        Bug Supervisor (Debian) @launchpad-buildd-admins
-        You received this bug notification because you are a member of Launchpad Buildd Admins, which is the bug supervisor for Debian.
     david.allouche@xxxxxxxxxxxxx
         Registrant (gnomebaker) @vcs-imports
         You received this bug notification because you are a member of VCS imports, which is the registrant for gnomebaker.
@@ -234,9 +198,6 @@
     kurem@xxxxxxxxx
         Subscriber of Duplicate @testing-spanish-team
         You received this bug notification because you are a member of testing Spanish team, which is a subscriber of a duplicate bug.
-    limi@xxxxxxxxx
-        Bug Supervisor (alsa-utils) @name18
-        You received this bug notification because you are a member of Ubuntu Gnome Team, which is the bug supervisor for alsa-utils.
     marilize@xxxxxxx
         Subscriber @shipit-admins
         You received this bug notification because you are a member of ShipIt Administrators, which is a direct subscriber.

=== modified file 'lib/lp/bugs/mail/bugnotificationrecipients.py'
--- lib/lp/bugs/mail/bugnotificationrecipients.py	2010-10-23 16:25:51 +0000
+++ lib/lp/bugs/mail/bugnotificationrecipients.py	2010-12-07 16:51:52 +0000
@@ -207,21 +207,6 @@
             text = "are a bug assignee"
         self._addReason(person, text, reason)
 
-    def addDistroBugSupervisor(self, person, distro):
-        """Registers a distribution bug supervisor for this bug."""
-        reason = "Bug Supervisor (%s)" % distro.displayname
-        # All displaynames in these reasons should be changed to bugtargetname
-        # (as part of bug 113262) once bugtargetname is finalized for packages
-        # (bug 113258). Changing it before then would be excessively
-        # disruptive.
-        if person.isTeam():
-            text = ("are a member of %s, which is the bug supervisor for %s" %
-                (person.displayname, distro.displayname))
-            reason += " @%s" % person.name
-        else:
-            text = "are the bug supervisor for %s" % distro.displayname
-        self._addReason(person, text, reason)
-
     def addStructuralSubscriber(self, person, target):
         """Registers a structural subscriber to this bug's target."""
         reason = "Subscriber (%s)" % target.displayname
@@ -233,17 +218,6 @@
             text = "are subscribed to %s" % target.displayname
         self._addReason(person, text, reason)
 
-    def addUpstreamBugSupervisor(self, person, upstream):
-        """Registers an upstream bug supervisor for this bug."""
-        reason = "Bug Supervisor (%s)" % upstream.displayname
-        if person.isTeam():
-            text = ("are a member of %s, which is the bug supervisor for %s" %
-                (person.displayname, upstream.displayname))
-            reason += " @%s" % person.name
-        else:
-            text = "are the bug supervisor for %s" % upstream.displayname
-        self._addReason(person, text, reason)
-
     def addRegistrant(self, person, upstream):
         """Registers an upstream product registrant for this bug."""
         reason = "Registrant (%s)" % upstream.displayname