launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

Данило Шеган has proposed merging lp:~danilo/launchpad/bug-680044 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #680044 Redundant test run: pofile-views.txt
  https://bugs.launchpad.net/bugs/680044


= Bug 680044 =

Test pofile-views.txt is run twice because it is run by the doc test suite and by the test_view.py in the containing directory. We need to remove the special case from the doc test suite since the view test uses appropriate layer anyway.

None of the other special-cased tests are affected since they all live in doc/* subdirectory which is what test_doc is processing anyway.

== Tests ==

bin/test -cvvt pofile-views.txt

-- 
https://code.launchpad.net/~danilo/launchpad/bug-680044/+merge/43515
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/bug-680044 into lp:launchpad.

=== modified file 'lib/lp/translations/tests/test_doc.py'
--- lib/lp/translations/tests/test_doc.py	2010-10-18 16:36:46 +0000
+++ lib/lp/translations/tests/test_doc.py	2010-12-13 13:53:54 +0000
@@ -25,10 +25,6 @@
 
 
 special = {
-    'pofile-views.txt': LayeredDocFileSuite(
-        '../browser/tests/pofile-views.txt',
-        setUp=setUp, tearDown=tearDown, layer=LaunchpadFunctionalLayer
-        ),
     'poexport-queue.txt': LayeredDocFileSuite(
         '../doc/poexport-queue.txt',
         setUp=setUp, tearDown=tearDown, layer=LaunchpadFunctionalLayer