launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

Gavin Panella has proposed merging lp:~allenap/launchpad/retest-tweak into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)


Make bin/retest recognize both errors and failures.
-- 
https://code.launchpad.net/~allenap/launchpad/retest-tweak/+merge/43625
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/launchpad/retest-tweak into lp:launchpad.

=== modified file 'buildout-templates/bin/retest.in'
--- buildout-templates/bin/retest.in	2010-07-08 14:03:52 +0000
+++ buildout-templates/bin/retest.in	2010-12-14 10:14:14 +0000
@@ -57,9 +57,13 @@
 
 def gen_test_lines(lines):
     def p_start(line):
-        return line.startswith('Tests with failures:')
+        return (
+            line.startswith('Tests with failures:') or
+            line.startswith('Tests with errors:'))
     def p_take(line):
-        return not line.startswith('Total:')
+        return not (
+            line.isspace() or
+            line.startswith('Total:'))
     lines = iter(lines)
     for line in lines:
         if p_start(line):