launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/mp-link-not-visible into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #687703 "propose for merging" not visible when not logged in
  https://bugs.launchpad.net/bugs/687703


= Summary =

Small fix to always show the Propose for Merging link on the branch page even if the user is not logged in.
They will just be prompted to login before being redirected to the right place. This is how other similar
links on that page work eg Link to Bug

= Implementation =

Remove @enabled_with_permission('launchpad.AnyPerson') decorator from register_merge()

= Tests =

Added to xx-propose-for-merging doc test to check link is there even if not logged in.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/code/browser/branch.py
  lib/lp/code/stories/branches/xx-propose-for-merging.txt
-- 
https://code.launchpad.net/~wallyworld/launchpad/mp-link-not-visible/+merge/43850
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/mp-link-not-visible into lp:launchpad.