launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

Deryck Hodge has proposed merging lp:~deryck/launchpad/js-private-var-385817 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #385817 variable "private" in launchpad.js is future reserved word and should be renamed
  https://bugs.launchpad.net/bugs/385817


Rename "private" to "private_flag" in js code to avoid a reserved name in ECMAScript.  This is a trivial change, and I ran the Windmill test (even though it doesn't run by default currenty) to see that there is any impact.  There is no problem with this change.  Will self approve since it's not a major change.
-- 
https://code.launchpad.net/~deryck/launchpad/js-private-var-385817/+merge/44245
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/js-private-var-385817 into lp:launchpad.

=== modified file 'lib/lp/bugs/javascript/bugtask_index.js'
--- lib/lp/bugs/javascript/bugtask_index.js	2010-11-05 17:13:49 +0000
+++ lib/lp/bugs/javascript/bugtask_index.js	2010-12-20 16:18:32 +0000
@@ -529,11 +529,11 @@
             lp_client, bug_repr, bug_repr.self_link);
     }
 
-    var private = data['field.private'] !== undefined;
+    var private_flag = data['field.private'] !== undefined;
     var security_related =
         data['field.security_related'] !== undefined;
 
-    lp_bug_entry.set('private', private);
+    lp_bug_entry.set('private', private_flag);
     lp_bug_entry.set('security_related', security_related);
     var error_handler = new LP.client.ErrorHandler();
     error_handler.clearProgressUI = function () {
@@ -553,7 +553,7 @@
                 privacy_link.setStyle('display', 'inline');
                 lp_bug_entry = updated_entry;
 
-                if (private) {
+                if (private_flag) {
                     Y.one('body').replaceClass('public', 'private');
                     privacy_div.replaceClass('public', 'private');
                     privacy_text.set(