launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

The proposal to merge lp:~danilo/launchpad/bug-690254 into lp:launchpad/db-devel has been updated.

Description changed to:

= Bug 690254 =

TranslationMessage.shareIfPossible still uses the old model code (getCurrentTranslationMessage, getImportedTranslationMessage), instead of the new model method getCurrentTranslation with the side parameter.

== Implementation details ==

While it seems as if shareIfPossible is still in the old model, it is not.  It is just using old model methods to achieve what it needs since it was implemented before the new method was available (it [ab]used the low-level knowledge of the implementation of the two models).

So, nothing is really changing except the way we get the data.

== Tests ==

Unfortunately, shareIfPossible is unit-tested only indirectly through test_message_sharing_migration.  Since these tests are quite comprehensive, I didn't bother adding new tests, but I did file a separate bug about *moving* them around: bug 696009.

  bin/test -cvvt test_message_sharing_migration

== Demo and Q/A ==

Part of general "translations sharing" feature QA.


= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/translations/model/translationmessage.py



For more details, see:
https://code.launchpad.net/~danilo/launchpad/bug-690254/+merge/44960
-- 
https://code.launchpad.net/~danilo/launchpad/bug-690254/+merge/44960
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/bug-690254 into lp:launchpad/db-devel.