launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Curtis Hovey has proposed merging lp:~sinzui/launchpad/prf-in-nightly-0 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #558448 Threshold for the product release finder monitoring script needs to be increased
  https://bugs.launchpad.net/bugs/558448

For more details, see:
https://code.launchpad.net/~sinzui/launchpad/prf-in-nightly-0/+merge/46748

Remove the product-release-finder from nightly.sh so that less that 24 hours
of work is scheduled everyday.

    Launchpad bug: https://bugs.launchpad.net/bugs/558448
    Pre-implementation: lifeless, wgrant
    Test command: None

The script monitor reports alternate between reporting that the PRF did not
run or that all other scheduled scripts in nightly did not run. This is
because more than 24 hours of work is scheduled every day. The PRF can
be run in parallel. Remove it from nightly.sh

Note that The prf up to run in lp-production-crontabs which is a second
branch.

--------------------------------------------------------------------

RULES

    * Comment out the product release finder script in nightly.sh


QA

    * None to QA
    * But the bug must be reopened if the script monitor does not say
      that karma ran 2 days in a row.


LINT

    cronscripts/nightly.sh
-- 
https://code.launchpad.net/~sinzui/launchpad/prf-in-nightly-0/+merge/46748
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~sinzui/launchpad/prf-in-nightly-0 into lp:launchpad.

=== modified file 'cronscripts/nightly.sh'
--- cronscripts/nightly.sh	2010-07-28 22:37:29 +0000
+++ cronscripts/nightly.sh	2011-01-19 06:21:33 +0000
@@ -59,7 +59,7 @@
 ### echo == Expiring bugs `date` ==
 ### python -S expire-bugtasks.py
 
-# checkwatches.py is scheduled in the /code/pqm/launchpad_crontabs branch.
+# checkwatches.py is scheduled in ~launchpad-pqn/lp-production-crontabs.
 ### echo == Updating bug watches `date` ==
 ### python -S checkwatches.py
 
@@ -75,8 +75,9 @@
 echo == Updating package cache `date` ==
 python -S update-pkgcache.py -q
 
-echo == Product Release Finder `date` ==
-python -S product-release-finder.py -q
+# Release finder is scheduled in ~launchpad-pqn/lp-production-crontabs.
+#echo == Product Release Finder `date` ==
+#python -S product-release-finder.py -q
 
 
 rm -f $LOCK