launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

Review: Needs Fixing code
Hey, Steve.  Thanks for this work!  Death to pointless doctests always warms the heart.

As we chatted about here in person at the sprint, I think the branch needs a test for the assertion error itself.  We have no test to prove that the error is actually raised should we hit this condition.

Sorry to add more work, but I really think we need this test added.

Cheers,
deryck
-- 
https://code.launchpad.net/~stevenk/launchpad/bpb-currentcomponent-assertion-part-6/+merge/46859
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/bpb-currentcomponent-assertion-part-6 into lp:launchpad.