launchpad-reviewers team mailing list archive

[Huw Wilkins <huwshimi@xxxxxxxxx>]

Huw Wilkins has proposed merging lp:~huwshimi/launchpad/licence-widget-overlap-687564 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #687564 license widget sections overlaps on projectgroup +newproject and projects/+new
  https://bugs.launchpad.net/bugs/687564

For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/licence-widget-overlap-687564/+merge/47084

Fixed bug #687564 so that the license selection widget on new project does not overlap other content on the page.

To test begin creating a new project. When you get to the step where you select the license check that the license widget has the first set of options (Recommended open source licenses) open and is not appearing on top of other content. Opening other license sets (More open source licenses or Other choices) should behave in the same way and should not appear over other content (they should be closed to begin with however). This will be fairly obvious if it is broken.
-- 
https://code.launchpad.net/~huwshimi/launchpad/licence-widget-overlap-687564/+merge/47084
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/licence-widget-overlap-687564 into lp:launchpad.

=== modified file 'lib/canonical/widgets/templates/license.pt'
--- lib/canonical/widgets/templates/license.pt	2010-11-16 19:02:58 +0000
+++ lib/canonical/widgets/templates/license.pt	2011-01-21 19:47:27 +0000
@@ -21,7 +21,7 @@
 </script>
 <script type="text/javascript">
 //<![CDATA[
-LPS.use('node', 'lazr.effects', function(Y) {
+YUI().use('node', 'lazr.effects', function(Y) {
     Y.on('domready', function() {
         function make_slider(cfg) {
             var table_name = '#' + cfg.which;