launchpad-reviewers team mailing list archive

[Huw Wilkins <huwshimi@xxxxxxxxx>]

Huw Wilkins has proposed merging lp:~huwshimi/launchpad/remove-icon-alt-528367 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #528367 Icon for unlinking related bug report has no alt= text
  https://bugs.launchpad.net/bugs/528367

For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/remove-icon-alt-528367/+merge/48430

Added alt tag to remove icons (bug #528367)
-- 
https://code.launchpad.net/~huwshimi/launchpad/remove-icon-alt-528367/+merge/48430
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/remove-icon-alt-528367 into lp:launchpad.

=== modified file 'lib/canonical/launchpad/templates/launchpad-graphics.pt'
--- lib/canonical/launchpad/templates/launchpad-graphics.pt	2010-10-31 20:18:45 +0000
+++ lib/canonical/launchpad/templates/launchpad-graphics.pt	2011-02-03 05:21:34 +0000
@@ -413,7 +413,7 @@
       </tr>
       <tr>
         <td>remove</td>
-        <td><img src="/@@/remove" /></td>
+        <td><img src="/@@/remove" alt="Remove" /></td>
         <td>Can be clicked to "remove" data from the system. Is sometimes
         used as a bullet on an action menu item which results in data
         removal, or in lists where clicking it will remove the data in that

=== modified file 'lib/lp/answers/templates/person-answer-contact-for.pt'
--- lib/lp/answers/templates/person-answer-contact-for.pt	2009-08-20 14:37:15 +0000
+++ lib/lp/answers/templates/person-answer-contact-for.pt	2011-02-03 05:21:34 +0000
@@ -16,7 +16,7 @@
           tal:attributes="href question_target/fmt:url:answers"
           tal:content="question_target/title">Project Title</a>
         <tal:link condition="view/showRemoveYourselfLink">
-          <img src="/@@/remove" />&mdash;
+          <img src="/@@/remove" alt="Remove" />&mdash;
           <a id="project-setanswercontact" href="#"
             tal:attributes="href string:${question_target/fmt:url}/+support-contact;
             id string:${question_target/name}-setdirectanswercontact">

=== modified file 'lib/lp/bugs/javascript/bugtask_index.js'
--- lib/lp/bugs/javascript/bugtask_index.js	2011-01-21 05:10:55 +0000
+++ lib/lp/bugs/javascript/bugtask_index.js	2011-02-03 05:21:34 +0000
@@ -830,7 +830,7 @@
     if (subscription.can_be_unsubscribed_by_user()) {
         var icon_html = Y.Node.create(
             '<a href="+subscribe">' +
-            '<img class="unsub-icon" src="/@@/remove" /></a>');
+            '<img class="unsub-icon" src="/@@/remove" alt="Remove" /></a>');
         icon_html
             .set('id', 'unsubscribe-' + terms.css_name)
             .set('title', 'Unsubscribe ' + terms.full_name);

=== modified file 'lib/lp/bugs/templates/bug-branch.pt'
--- lib/lp/bugs/templates/bug-branch.pt	2009-11-13 03:05:26 +0000
+++ lib/lp/bugs/templates/bug-branch.pt	2011-02-03 05:21:34 +0000
@@ -23,7 +23,7 @@
      tal:attributes="
        href string:${branch/fmt:url}/+bug/${bug/id}/+delete;
        id string:bugbranch-${bug_branch/id}-delete;">
-    <img src="/@@/remove"/>
+    <img src="/@@/remove" alt="Remove"/>
   </a>
   <div tal:repeat="proposal view/merge_proposals" class="reviews">
     <tal:merge-fragment tal:replace="structure proposal/@@+summary-fragment"/>

=== modified file 'lib/lp/bugs/templates/bug-portlet-dupe-subscribers-content.pt'
--- lib/lp/bugs/templates/bug-portlet-dupe-subscribers-content.pt	2010-09-02 22:55:21 +0000
+++ lib/lp/bugs/templates/bug-portlet-dupe-subscribers-content.pt	2011-02-03 05:21:34 +0000
@@ -41,7 +41,7 @@
                  class python: view.getSubscriptionClassForUser(subscription.person)
                "
             >
-              <img class="unsub-icon" src="/@@/remove"
+              <img class="unsub-icon" src="/@@/remove" alt="Remove"
                 tal:attributes="id string:unsubscribe-icon-${subscription/css_name}" />
             </a>
     </div>

=== modified file 'lib/lp/bugs/templates/bug-portlet-subscribers-content.pt'
--- lib/lp/bugs/templates/bug-portlet-subscribers-content.pt	2009-12-18 20:54:13 +0000
+++ lib/lp/bugs/templates/bug-portlet-subscribers-content.pt	2011-02-03 05:21:34 +0000
@@ -39,7 +39,7 @@
                  class python: view.getSubscriptionClassForUser(subscription.person)
                "
             >
-              <img class="unsub-icon" src="/@@/remove"
+              <img class="unsub-icon" src="/@@/remove" alt="Remove"
                 tal:attributes="id string:unsubscribe-icon-${subscription/css_name}" />
             </a>
 

=== modified file 'lib/lp/code/templates/branch-macros.pt'
--- lib/lp/code/templates/branch-macros.pt	2011-01-20 04:27:38 +0000
+++ lib/lp/code/templates/branch-macros.pt	2011-02-03 05:21:34 +0000
@@ -123,7 +123,7 @@
              class="delete-buglink"
              tal:attributes="href string:+bug/${bug/id}/+delete;
                              id string:delete-buglink-${bug/id}">
-            <img src="/@@/remove"/>
+            <img src="/@@/remove" alt="Remove"/>
           </a>
         </td>
       </tr>

=== modified file 'lib/lp/code/templates/branch-related-bugs-specs.pt'
--- lib/lp/code/templates/branch-related-bugs-specs.pt	2010-10-19 01:24:36 +0000
+++ lib/lp/code/templates/branch-related-bugs-specs.pt	2011-02-03 05:21:34 +0000
@@ -22,7 +22,7 @@
                  class="delete-buglink"
                  tal:attributes="href string:+bug/${bug/id}/+delete;
                                  id string:delete-buglink-${bug/id}">
-                <img src="/@@/remove"/>
+                <img src="/@@/remove" alt="Remove"/>
               </a>
             </tal:buglink-edit>
           </li>