launchpad-reviewers team mailing list archive

[Gary Poster <gary.poster@xxxxxxxxxxxxx>]

The proposal to merge lp:~gary/launchpad/bug548 into lp:launchpad has been updated.

Description changed to:

This branch adds a simple way to control whether you want to receive bug notifications for changes you generated.  It is as described in the first paragraph of https://dev.launchpad.net/yellow/Subscriptions#Turning%20off%20emails%20about%20your%20own%20actions .

Note that we expect this functionality to be even more important in the "Email from structural subscriptions" story, as described in the second paragraph of that text.  That is currently being mocked up and prepared for user testing.

Functionality tests already exist from previous branches.  Therefore, this branch merely shows that the widget exists and can be manipulated.

make lint was happy.

To QA, log in as a user, go to the user's "details" page, and deselect this option ("Send me bug notifications for changes I make.").  Then go to a bug to which the user is subscribed, and make a change.  Ask the LOSAs to run "cronscripts/send-bug-notifications.py -vv" and give you the output (warn them that it might be large).  In that output, verify that the user did not get a notification for the change that the user made.



For more details, see:
https://code.launchpad.net/~gary/launchpad/bug548/+merge/48850
-- 
https://code.launchpad.net/~gary/launchpad/bug548/+merge/48850
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gary/launchpad/bug548 into lp:launchpad.