launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

I would massively prefer a test of this for the '%' and '%%' cases, but as its diagnostic only its probably tolerable without. Up to you, but ... consider yourself encouraged. 

lib/canonical/launchpad/webapp/tests/test_errorlog.py is where I would add such a test, I think. That or the storm tests that test the storm adapters you're changing.
-- 
https://code.launchpad.net/~wallyworld/launchpad/profile-sql-bind-values/+merge/48872
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/profile-sql-bind-values into lp:launchpad.