launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

Данило Шеган has proposed merging lp:~danilo/launchpad/bugtask-index-portlet-setup into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~danilo/launchpad/bugtask-index-portlet-setup/+merge/49818

= Split bugtask-index.js into two files =

Warning: this is a branch with a huge diff, but it's a move of ~1100 lines of JS from bugtask_index.js to a new bugtask_index_portlets.js.  Changes other than the move are minimal.

At the moment, bugtask-index.js is a behemoth of >2k lines of JS, doing many unrelated things:
 - handling duplication
 - handling branch linking
 - handling "me too" functionality
 - handling subscription portlets

The idea is to eventually split it all up by functionality, but a first step is to start with setup_portlet_handlers and move that all out into a separate file.  That includes duplication and subscribing portlets set-up.

Future branches will split duplication from subscription stuff.

== Pre-implementation notes ==

Talked this over with Graham who suggested starting with setup_portlet_handlers.

== Implementation details ==

Only two functions are namespaced using lp.bugs.bugtask_index.portlets, because they are the actual entry points.  I am not entirely sure what does namespacing bring us, but it seems they are not accessible outside if they are not namespaced, which makes this the right choice.

Rest of it is a simple code move from bugtask-index.js to bugtask-index-portlets.js.

Fixes in other parts of the tree are due to failing windmill tests.

I am not sure how to best figure out what is the minimum list of required modules for a certain module (I just copied the list over from bugtask_index.js), so if a reviewer has any suggestions, I'd be happy to hear them out.

== Tests ==

bin/test -cvvm lp.bugs --layer=WindmillLayer

== Demo and Q/A ==

Go to eg. https://bugs.launchpad.dev/tomcat/+bug/2 and try setting a bug as a duplicate of another bug (say number 3), subscribing and unsubscribing from a bug.  Nothing should change compared to the existing behaviour.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/bugs/templates/bug-portlet-subscribers.pt
  lib/lp/bugs/javascript/bugtask_index_portlets.js
  lib/lp/bugs/javascript/bugtask_index.js
-- 
https://code.launchpad.net/~danilo/launchpad/bugtask-index-portlet-setup/+merge/49818
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/bugtask-index-portlet-setup into lp:launchpad.

=== modified file 'lib/lp/bugs/javascript/bugtask_index.js'
--- lib/lp/bugs/javascript/bugtask_index.js	2011-02-10 09:52:06 +0000
+++ lib/lp/bugs/javascript/bugtask_index.js	2011-02-15 14:49:55 +0000
@@ -42,122 +42,9 @@
 // The set of subscriber CSS IDs as a JSON struct.
 var subscriber_ids;
 
-// A boolean telling us whether advanced subscription features are to be
-// used or not.
-// XXX 2011-01-14 gmb bug=702859:
-//     We need to expose feature flags via the API to avoid this kind of
-//     thing.
-var use_advanced_subscriptions = false;
-var subscription_labels = Y.lp.bugs.subscriber.subscription_labels;
-
-/*
- * An object representing the bugtask subscribers portlet.
- *
- * Since the portlet loads via XHR and inline subscribing
- * depends on that portlet being loaded, setup a custom
- * event object, to provide a hook for initializing subscription
- * link callbacks after custom events.
- */
-var PortletTarget = function() {};
-Y.augment(PortletTarget, Y.Event.Target);
-namespace.portlet = new PortletTarget();
-
-function setup_portlet_handlers() {
-    namespace.portlet.subscribe('bugs:portletloaded', function() {
-        load_subscriber_ids();
-    });
-    namespace.portlet.subscribe('bugs:dupeportletloaded', function() {
-        setup_unsubscribe_icon_handlers();
-    });
-    /*
-     * If the subscribers portlet fails to load, clear any
-     * click handlers, so the normal subscribe page can be reached.
-     */
-    namespace.portlet.subscribe('bugs:portletloadfailed', function(handlers) {
-        if (Y.Lang.isArray(handlers)) {
-            var click_handler = handlers[0];
-            click_handler.detach();
-        }
-    });
-    /* If the dupe subscribers portlet fails to load,
-     * be sure to try to handle any unsub icons that may
-     * exist for others.
-     */
-    namespace.portlet.subscribe(
-        'bugs:dupeportletloadfailed',
-        function(handlers) {
-            setup_unsubscribe_icon_handlers();
-        });
-
-    /* If loading the subscriber IDs JSON has succeeded, set up the
-     * subscription link handlers and load the subscribers from dupes.
-     */
-    namespace.portlet.subscribe(
-        'bugs:portletsubscriberidsloaded',
-        function() {
-            setup_subscription_link_handlers();
-            load_subscribers_from_duplicates();
-        });
-
-    /* If loading the subscriber IDs JSON fails we still need to load the
-     * subscribers from duplicates but we don't set up the subscription link
-     * handlers.
-     */
-    namespace.portlet.subscribe(
-        'bugs:portletsubscriberidsfailed',
-        function() {
-            load_subscribers_from_duplicates();
-        });
-
-    /*
-     * Subscribing someone else requires loading a grayed out
-     * username into the DOM until the subscribe action completes.
-     * There are a couple XHR requests in check_can_be_unsubscribed
-     * before the subscribe work can be done, so fire a custom event
-     * bugs:nameloaded and do the work here when the event fires.
-     */
-    namespace.portlet.subscribe('bugs:nameloaded', function(subscription) {
-        var error_handler = new LP.client.ErrorHandler();
-        error_handler.clearProgressUI = function() {
-            var temp_link = Y.one('#temp-username');
-            if (temp_link) {
-                var temp_parent = temp_link.get('parentNode');
-                temp_parent.removeChild(temp_link);
-            }
-        };
-        error_handler.showError = function(error_msg) {
-            Y.lp.app.errors.display_error(
-                Y.one('.menu-link-addsubscriber'), error_msg);
-        };
-
-        var config = {
-            on: {
-                success: function() {
-                    var temp_link = Y.one('#temp-username');
-                    var temp_spinner = Y.one('#temp-name-spinner');
-                    temp_link.removeChild(temp_spinner);
-                    var anim = Y.lazr.anim.green_flash({ node: temp_link });
-                    anim.on('end', function() {
-                        add_user_name_link(subscription);
-                        var temp_parent = temp_link.get('parentNode');
-                        temp_parent.removeChild(temp_link);
-                    });
-                    anim.run();
-                },
-                failure: error_handler.getFailureHandler()
-            },
-            parameters: {
-                person: LP.client.get_absolute_uri(
-                    subscription.get('person').get('escaped_uri')),
-                suppress_notify: false
-            }
-        };
-        lp_client.named_post(bug_repr.self_link, 'subscribe', config);
-    });
-}
-
 namespace.setup_bugtask_index = function() {
-    setup_portlet_handlers();
+    Y.lp.bugs.bugtask_index.portlets.setup_portlet_handlers();
+
     /*
      * Check the page for links related to overlay forms and request the HTML
      * for these forms.
@@ -275,203 +162,6 @@
 
 
 /*
- * Initialize click handler for the subscribe someone else link.
- *
- * @method setup_subscribe_someone_else_handler
- * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
- */
-function setup_subscribe_someone_else_handler(subscription) {
-    var config = {
-        header: 'Subscribe someone else',
-        step_title: 'Search',
-        picker_activator: '.menu-link-addsubscriber'
-    };
-
-    config.save = function(result) {
-        subscribe_someone_else(result, subscription);
-    };
-    var picker = Y.lp.app.picker.create('ValidPersonOrTeam', config);
-}
-
-
-/*
- * Handle the advanced_subscription_overlay's form submissions.
- *
- * @method handle_advanced_subscription_overlay
- * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
- * @param form_data {Object} The data from the submitted form.
- */
-function handle_advanced_subscription_overlay(subscription, form_data) {
-    var link = subscription.get('link');
-    var link_parent = link.get('parentNode');
-    if (link_parent.hasClass('subscribed-false') &&
-        link_parent.hasClass('dup-subscribed-false')) {
-        // The user isn't subscribed, so subscribe them.
-        subscription.set(
-            'bug_notification_level',
-            form_data['field.bug_notification_level']);
-        subscribe_current_user(subscription);
-    } else if (
-        form_data['field.subscription'] == 'update-subscription') {
-        // The user is already subscribed and wants to update their
-        // subscription.
-        setup_client_and_bug();
-        var person_name = subscription.get('person').get('name');
-        var subscription_url =
-            lp_bug_entry.get('self_link') + '/+subscription/' +
-            person_name;
-        config = {
-            on: {
-                success: function(lp_subscription) {
-                    subscription.enable_spinner('Updating subscription...');
-                    lp_subscription.set(
-                        'bug_notification_level',
-                        form_data['field.bug_notification_level'][0])
-                    save_config = {
-                        on: {
-                            success: function(e) {
-                                subscription.disable_spinner(
-                                    'Edit subscription');
-                                var anim = Y.lazr.anim.green_flash({
-                                    node: link_parent
-                                    });
-                                anim.run();
-                            },
-                            failure: function(e) {
-                                subscription.disable_spinner(
-                                    'Edit subscription');
-                                var anim = Y.lazr.anim.red_flash({
-                                    node: link_parent
-                                    });
-                                anim.run();
-                            }
-                        }
-                    }
-                    lp_subscription.lp_save(save_config);
-                }
-            }
-        }
-        lp_client.get(subscription_url, config);
-    } else {
-        // The user is already subscribed and wants to unsubscribe.
-        unsubscribe_current_user(subscription);
-    }
-}
-
-
-/*
- * Create and return a FormOverlay for advanced subscription
- * interactions.
- *
- * @method setup_advanced_subscription_overlay
- * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
- */
-function setup_advanced_subscription_overlay(subscription) {
-    var subscription_overlay = new Y.lazr.FormOverlay({
-        headerContent: '<h2>Subscribe to bug</h2>',
-        form_submit_button:
-            Y.Node.create(submit_button_html),
-        form_cancel_button:
-            Y.Node.create(cancel_button_html),
-        centered: true,
-        visible: false
-    });
-    subscription_overlay.set(
-        'form_submit_callback', function(form_data) {
-        handle_advanced_subscription_overlay(subscription, form_data);
-        subscription_overlay.hide();
-    });
-
-    var subscription_link_url = subscription.get(
-        'link').get('href') + '/++form++';
-    subscription_overlay.loadFormContentAndRender(
-        subscription_link_url);
-    subscription_overlay.render('#privacy-form-container');
-    return subscription_overlay
-}
-
-
-/*
- * Initialize callbacks for subscribe/unsubscribe links.
- *
- * @method setup_subscription_link_handlers
- */
-function setup_subscription_link_handlers() {
-    if (LP.client.links.me === undefined) {
-        return;
-    }
-
-    setup_client_and_bug();
-    var subscription = new Y.lp.bugs.subscriber.Subscription({
-        link: Y.one('.menu-link-subscription'),
-        spinner: Y.one('#sub-unsub-spinner'),
-        subscriber: new Y.lp.bugs.subscriber.Subscriber({
-            uri: LP.client.links.me,
-            subscriber_ids: subscriber_ids
-        })
-    });
-
-    var is_direct = subscription.get(
-        'link').get('parentNode').hasClass('subscribed-true');
-    var has_dupes = subscription.get(
-        'link').get('parentNode').hasClass('dup-subscribed-true');
-    subscription.set('is_direct', is_direct);
-    subscription.set('has_dupes', has_dupes);
-
-    if (subscription.is_node()) {
-        subscription.get('link').on('click', function(e) {
-            e.halt();
-            subscription.set('can_be_unsubscribed', true);
-            subscription.set('person', subscription.get('subscriber'));
-            subscription.set('is_team', false);
-            var parent = e.target.get('parentNode');
-            if (namespace.use_advanced_subscriptions) {
-                var subscription_overlay =
-                    setup_advanced_subscription_overlay(subscription);
-                subscription_overlay.show();
-            } else {
-                // Look for the false conditions of subscription, which
-                // is_direct_subscription, etc. don't report correctly,
-                // to make sure we only use subscribe_current_user for
-                // the current user.
-                if (parent.hasClass('subscribed-false') &&
-                    parent.hasClass('dup-subscribed-false')) {
-                    subscribe_current_user(subscription);
-                }
-                else {
-                    unsubscribe_current_user(subscription);
-                }
-            }
-        });
-        subscription.get('link').addClass('js-action');
-    }
-
-    setup_subscribe_someone_else_handler(subscription);
-}
-
-/*
- * Set click handlers for unsubscribe remove icons.
- *
- * @method setup_unsubscribe_icon_handlers
- * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
- */
-function setup_unsubscribe_icon_handlers() {
-    var subscription = new Y.lp.bugs.subscriber.Subscription({
-        link: Y.one('.menu-link-subscription'),
-        spinner: Y.one('#sub-unsub-spinner'),
-        subscriber: new Y.lp.bugs.subscriber.Subscriber({
-            uri: LP.client.links.me,
-            subscriber_ids: subscriber_ids
-        })
-    });
-
-    Y.on('click', function(e) {
-        e.halt();
-        unsubscribe_user_via_icon(e.target, subscription);
-    }, '.unsub-icon');
-}
-
-/*
  * Create the lp client and bug entry if we haven't done so already.
  *
  * @method setup_client_and_bug
@@ -850,594 +540,6 @@
     Y.fire('lp:branch-linked', bug_branch_node);
 }
 
-/*
- * Traverse the DOM of a given remove icon to find
- * the user's link.  Returns a URI of the form "/~username".
- *
- * @method get_user_uri_from_icon
- * @param icon {Node} The node representing a remove icon.
- * @return user_uri {String} The user's uri, without the hostname.
- */
-function get_user_uri_from_icon(icon) {
-    var parent_div = icon.get('parentNode').get('parentNode');
-    // This should be parent_div.firstChild, but because of #text
-    // and cross-browser issues, using the YUI query syntax is
-    // safer here.
-    var user_uri = parent_div.one('a').getAttribute('href');
-
-    // Strip the domain off. We just want a path.
-    var host_start = user_uri.indexOf('//');
-    if (host_start != -1) {
-        var host_end = user_uri.indexOf('/', host_start+2);
-        return user_uri.substring(host_end, user_uri.length);
-    }
-
-    return user_uri;
-}
-
-
-/*
- * Build the HTML for a user link for the subscribers list.
- *
- * @method build_user_link_html
- * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
- * @return html {String} The HTML used for creating a subscriber link.
- */
-function build_user_link_html(subscription) {
-    var name = subscription.get('person').get('name');
-    var css_name = subscription.get('person').get('css_name');
-    var full_name = subscription.get('person').get('full_display_name');
-    // Be paranoid about display_name, since timeouts or other errors
-    // could mean display_name wasn't set on initialization.
-    if (subscription.get('person').get('display_name') === '') {
-        subscription.get('person').set_display_name();
-    }
-    var display_name = subscription.get('person').get('display_name');
-    var terms = {
-        name: name,
-        css_name: css_name,
-        display_name: display_name,
-        full_name: full_name
-    };
-
-    if (subscription.is_current_user_subscribing()) {
-        terms.subscribed_by = 'themselves';
-    } else {
-        terms.subscribed_by = 'by ' + full_name;
-    }
-
-    var html = Y.Node.create('<div><a></a></div>');
-    html.addClass(terms.css_name);
-
-    if (subscription.is_direct_subscription()) {
-        html.set('id', 'direct-' + terms.css_name);
-    } else {
-        html.set('id', 'dupe-' + terms.css_name);
-    }
-
-    html.one('a')
-        .set('href', '/~' + terms.name)
-        .set('name', terms.full_name)
-        .set('title', 'Subscribed ' + terms.subscribed_by);
-
-    var span;
-    if (subscription.is_team()) {
-        span = '<span class="sprite team"></span>';
-    } else {
-        span = '<span class="sprite person"></span>';
-    }
-
-    html.one('a')
-        .appendChild(Y.Node.create(span))
-        .appendChild(document.createTextNode(terms.display_name));
-
-    // Add remove icon if the current user can unsubscribe the subscriber.
-    if (subscription.can_be_unsubscribed_by_user()) {
-        var icon_html = Y.Node.create(
-            '<a href="+subscribe">' +
-            '<img class="unsub-icon" src="/@@/remove" alt="Remove" /></a>');
-        icon_html
-            .set('id', 'unsubscribe-' + terms.css_name)
-            .set('title', 'Unsubscribe ' + terms.full_name);
-        icon_html.one('img')
-            .set('id', 'unsubscribe-icon-' + terms.css_name);
-        html.appendChild(icon_html);
-    }
-
-    return html;
-}
-
-/*
- * Used to remove the user's name from the subscriber's list.
- *
- * @method remove_user_name_link
- * @param user_node {Node} Node representing the user name link.
- */
-function remove_user_name_link(user_node) {
-    var parent = user_node.get('parentNode');
-    parent.removeChild(user_node);
-}
-
-/*
- * Returns the next node in alphabetical order after the subscriber
- * node now being added.  No node is returned to append to end of list.
- *
- * The name can appear in one of two different lists. 1) The list of
- * subscribers that can be unsubscribed by the current user, and
- * 2) the list of subscribers that cannont be unsubscribed.
- *
- * @method get_next_subscriber_node
- * @param subscription_link {Node} The sub/unsub link.
- * @return {Node} The node appearing next in the subscriber list or
- *          undefined if no node is next.
- */
-function get_next_subscriber_node(subscription) {
-    var full_name = subscription.get('person').get('full_display_name');
-    var can_be_unsubscribed = subscription.can_be_unsubscribed_by_user();
-    var nodes_by_name = {};
-    var unsubscribables = [];
-    var not_unsubscribables = [];
-
-    // Use the list of subscribers pulled from the DOM to have sortable
-    // lists of unsubscribable vs. not unsubscribale person links.
-    var all_subscribers = Y.all('#subscribers-links div');
-    if (all_subscribers.size() > 0) {
-        all_subscribers.each(function(sub_link) {
-            if (sub_link.getAttribute('id') != 'temp-username') {
-                // User's displayname is found via the link's "name"
-                // attribute.
-                var sub_link_name = sub_link.one('a').getAttribute('name');
-                nodes_by_name[sub_link_name] = sub_link;
-                if (sub_link.one('img.unsub-icon')) {
-                    unsubscribables.push(sub_link_name);
-                } else {
-                    not_unsubscribables.push(sub_link_name);
-                }
-            }
-        });
-
-        // Add the current subscription.
-        if (can_be_unsubscribed) {
-            unsubscribables.push(full_name);
-        } else {
-            not_unsubscribables.push(full_name);
-        }
-        unsubscribables.sort();
-        not_unsubscribables.sort();
-    } else {
-        // If there is no all_subscribers, then we're dealing with
-        // the printed None, so return.
-        return;
-    }
-
-    var i;
-    if ((!unsubscribables && !not_unsubscribables) ||
-        // If A) neither list exists, B) the user belongs in the second
-        // list but the second list doesn't exist, or C) user belongs in the
-        // first list and the second doesn't exist, return no node to append.
-        (!can_be_unsubscribed && !not_unsubscribables) ||
-        (can_be_unsubscribed && unsubscribables && !not_unsubscribables)) {
-        return;
-    } else if (
-        // If the user belongs in the first list, and the first list
-        // doesn't exist, but the second one does, return the first node
-        // in the second list.
-        can_be_unsubscribed && !unsubscribables && not_unsubscribables) {
-        return nodes_by_name[not_unsubscribables[0]];
-    } else if (can_be_unsubscribed) {
-        // If the user belongs in the first list, loop the list for position.
-        for (i=0; i<unsubscribables.length; i++) {
-            if (unsubscribables[i] == full_name) {
-                if (i+1 < unsubscribables.length) {
-                    return nodes_by_name[unsubscribables[i+1]];
-                // If the current link should go at the end of the first
-                // list and we're at the end of that list, return the
-                // first node of the second list.  Due to earlier checks
-                // we can be sure this list exists.
-                } else if (i+1 >= unsubscribables.length) {
-                    return nodes_by_name[not_unsubscribables[0]];
-                }
-            }
-        }
-    } else if (!can_be_unsubscribed) {
-        // If user belongs in the second list, loop the list for position.
-        for (i=0; i<not_unsubscribables.length; i++) {
-            if (not_unsubscribables[i] == full_name) {
-                if (i+1 < not_unsubscribables.length) {
-                    return nodes_by_name[not_unsubscribables[i+1]];
-                } else {
-                    return;
-                }
-            }
-        }
-    }
-}
-
-/*
- * Add the user name to the subscriber's list.
- *
- * @method add_user_name_link
- */
-function add_user_name_link(subscription) {
-    var person = subscription.get('person');
-    var link_node = build_user_link_html(subscription);
-    var subscribers = Y.one('#subscribers-links');
-    if (subscription.is_current_user_subscribing()) {
-        // If this is the current user, then top post the name and be done.
-        subscribers.insertBefore(link_node, subscribers.get('firstChild'));
-    } else {
-        var next = get_next_subscriber_node(subscription);
-        if (next) {
-            subscribers.insertBefore(link_node, next);
-        } else {
-            // Handle the case of the displayed "None".
-            var none_subscribers = Y.one('#none-subscribers');
-            if (none_subscribers) {
-                var none_parent = none_subscribers.get('parentNode');
-                none_parent.removeChild(none_subscribers);
-            }
-            subscribers.appendChild(link_node);
-        }
-    }
-
-    // Set the click handler if adding a remove icon.
-    if (subscription.can_be_unsubscribed_by_user()) {
-        var remove_icon =
-          Y.one('#unsubscribe-icon-' + person.get('css_name'));
-        remove_icon.on('click', function(e) {
-            e.halt();
-            unsubscribe_user_via_icon(e.target, subscription);
-        });
-    }
-}
-
-/*
- * Add a grayed out, temporary user name when subscribing
- * someone else.
- *
- * @method add_temp_user_name
- * @param subscription_link {Node} The sub/unsub link.
- */
-function add_temp_user_name(subscription) {
-    // Be paranoid about display_name, since timeouts or other errors
-    // could mean display_name wasn't set on initialization.
-    if (subscription.get('person').get('display_name') === '') {
-        subscription.get('person').set_display_name();
-    }
-    var display_name = subscription.get('person').get('display_name');
-    var img_src;
-    if (subscription.is_team()) {
-        img_src = '/@@/teamgray';
-    } else {
-        img_src = '/@@/persongray';
-    }
-
-    // The <span>...</span> below must *not* be <span/>. On FF (maybe
-    // others, but at least on FF 3.0.11) will then not notice any
-    // following sibling nodes, like the spinner image.
-    var link_node = Y.Node.create([
-        '<div id="temp-username"> ',
-        '  <img alt="" width="14" height="14" />',
-        '  <span>Other Display Name</span>',
-        '  <img id="temp-name-spinner" src="/@@/spinner" alt="" ',
-        '       style="position:absolute;right:8px" /></div>'].join(''));
-    link_node.one('img').set('src', img_src);
-    link_node.replaceChild(
-        document.createTextNode(display_name),
-        link_node.one('span'));
-
-    var subscribers = Y.one('#subscribers-links');
-    var next = get_next_subscriber_node(subscription);
-    if (next) {
-        subscribers.insertBefore(link_node, next);
-    } else {
-        // Handle the case of the displayed "None".
-        var none_subscribers = Y.one('#none-subscribers');
-        if (none_subscribers) {
-            var none_parent = none_subscribers.get('parentNode');
-            none_parent.removeChild(none_subscribers);
-        }
-        subscribers.appendChild(link_node);
-    }
-
-    // Fire a custom event to know it's safe to begin
-    // any actual subscribing work.
-    namespace.portlet.fire('bugs:nameloaded', subscription);
-}
-
-/*
- * Add the "None" div to the subscribers list if
- * there aren't any subscribers left.
- *
- * @method set_none_for_empty_subscribers
- */
-function set_none_for_empty_subscribers() {
-    var subscriber_list = Y.one('#subscribers-links');
-    // Assume if subscriber_list has no child divs
-    // then the list of subscribers is empty.
-    if (!Y.Lang.isValue(subscriber_list.one('div')) &&
-        !Y.Lang.isValue(Y.one('#none-subscribers'))) {
-        var none_div = Y.Node.create('<div id="none-subscribers">None</div>');
-        subscriber_list.appendChild(none_div);
-    }
-
-    // Clear the empty duplicate subscribers list if it exists.
-    var dup_list = Y.one('#subscribers-from-duplicates');
-    if (Y.Lang.isValue(dup_list) &&
-        !Y.Lang.isValue(dup_list.one('div'))) {
-        var parent = dup_list.get('parentNode');
-        parent.removeChild(dup_list);
-    }
-}
-
-/*
- * Set the class on subscription link's parentNode.
- *
- * This is used to reset the class used by the
- * click handler to know which link was clicked.
- *
- * @method set_subscription_link_parent_class
- * @param subscription_link {Node} The sub/unsub link.
- * @param subscribed {Boolean} The sub/unsub'ed flag for the class.
- * @param dupe_subscribed {Boolean} The sub/unsub'ed flag for dupes
- *                                  on the class.
- */
-function set_subscription_link_parent_class(
-    user_link, subscribed, dupe_subscribed) {
-
-    var parent = user_link.get('parentNode');
-    if (subscribed) {
-        parent.removeClass('subscribed-false');
-        parent.addClass('subscribed-true');
-    } else {
-        parent.removeClass('subscribed-true');
-        parent.addClass('subscribed-false');
-    }
-
-    if (dupe_subscribed) {
-        parent.removeClass('dup-subscribed-false');
-        parent.addClass('dup-subscribed-true');
-    } else {
-        parent.removeClass('dup-subscribed-true');
-        parent.addClass('dup-subscribed-false');
-    }
-}
-
-/*
- * Unsubscribe a user from this bugtask when a remove icon is clicked.
- *
- * @method unsubscribe_user_via_icon
- * @param icon {Node} The remove icon that was clicked.
- * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
-*/
-function unsubscribe_user_via_icon(icon, subscription) {
-    icon.set('src', '/@@/spinner');
-    var icon_parent = icon.get('parentNode');
-
-    var user_uri = get_user_uri_from_icon(icon);
-    var person = new Y.lp.bugs.subscriber.Subscriber({
-        uri: user_uri,
-        subscriber_ids: subscriber_ids
-    });
-    subscription.set('person', person);
-
-    // Determine if this is a dupe.
-    var is_dupe;
-    var icon_parent_div = icon_parent.get('parentNode');
-    var dupe_id = 'dupe-' + person.get('css_name');
-    if (icon_parent_div.get('id') == dupe_id) {
-        is_dupe = true;
-    } else {
-        is_dupe = false;
-    }
-
-    var error_handler = new LP.client.ErrorHandler();
-    error_handler.clearProgressUI = function () {
-        icon.set('src', '/@@/remove');
-        // Grab the icon again to reset to click handler.
-        var unsubscribe_icon = Y.one(
-            '#unsubscribe-icon-' + person.get('css_name'));
-        unsubscribe_icon.on('click', function(e) {
-            e.halt();
-            unsubscribe_user_via_icon(e.target, subscription);
-        });
-
-    };
-    error_handler.showError = function (error_msg) {
-        var flash_node = Y.one('.' + person.get('css_name'));
-        Y.lp.app.errors.display_error(flash_node, error_msg);
-
-    };
-
-    var subscription_link = subscription.get('link');
-    var config = {
-        on: {
-            success: function(client) {
-                icon_parent.removeChild(icon);
-                var anim = Y.lazr.anim.green_flash({ node: icon_parent_div });
-                anim.on('end', function(e) {
-                    remove_user_name_link(icon_parent_div);
-                    set_none_for_empty_subscribers();
-                    var person_link = Y.one('.' + person.get('css_name'));
-                    if (Y.Lang.isNull(person_link) &&
-                        subscription.is_current_user_subscribing()) {
-                            // Current user has been completely unsubscribed.
-                            subscription.disable_spinner(
-                                subscription_labels.SUBSCRIBE);
-                            set_subscription_link_parent_class(
-                                subscription_link, false, false);
-                            subscription.set('is_direct', false);
-                            subscription.set('has_dupes', false);
-                    } else {
-                        if (is_dupe) {
-                            // A direct subscription remains.
-                            set_subscription_link_parent_class(
-                                subscription_link, true, false);
-                            subscription.set('is_direct', true);
-                            subscription.set('has_dupes', false);
-                        } else {
-                            // A dupe subscription remains.
-                            set_subscription_link_parent_class(
-                                subscription_link, false, true);
-                            subscription.set('is_direct', false);
-                            subscription.set('has_dupes', true);
-                        }
-                    }
-                });
-                anim.run();
-            },
-
-            failure: error_handler.getFailureHandler()
-        }
-    };
-
-    if (!subscription.is_current_user_subscribing()) {
-        config.parameters = {
-            person: LP.client.get_absolute_uri(user_uri)
-        };
-    }
-
-    if (is_dupe) {
-        lp_client.named_post(
-            bug_repr.self_link, 'unsubscribeFromDupes', config);
-    } else {
-        lp_client.named_post(bug_repr.self_link, 'unsubscribe', config);
-    }
-}
-
-/*
- * Subscribe the current user via the LP API.
- *
- * @method subscribe_current_user
- * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
- */
-function subscribe_current_user(subscription) {
-    subscription.enable_spinner('Subscribing...');
-    var subscription_link = subscription.get('link');
-    var subscriber = subscription.get('subscriber');
-    var bug_notification_level = subscription.get('bug_notification_level');
-
-    var error_handler = new LP.client.ErrorHandler();
-    error_handler.clearProgressUI = function () {
-        subscription.disable_spinner();
-    };
-    error_handler.showError = function (error_msg) {
-        Y.lp.app.errors.display_error(subscription_link, error_msg);
-    };
-
-    var config = {
-        on: {
-            success: function(client) {
-                if (namespace.use_advanced_subscriptions) {
-                    subscription.disable_spinner(
-                        subscription_labels.EDIT);
-                } else {
-                    subscription.disable_spinner(
-                        subscription_labels.UNSUBSCRIBE);
-                }
-
-                if (subscription.has_duplicate_subscriptions()) {
-                    set_subscription_link_parent_class(
-                        subscription_link, true, true);
-                } else {
-                    set_subscription_link_parent_class(
-                        subscription_link, true, false);
-                }
-
-                // Handle the case where the subscriber's list displays
-                // "None".
-                var empty_subscribers = Y.one("#none-subscribers");
-                if (empty_subscribers) {
-                    var parent = empty_subscribers.get('parentNode');
-                    parent.removeChild(empty_subscribers);
-                }
-
-                add_user_name_link(subscription);
-
-                var flash_node = Y.one('.' + subscriber.get('css_name'));
-                var anim = Y.lazr.anim.green_flash({ node: flash_node });
-                anim.run();
-            },
-
-            failure: error_handler.getFailureHandler()
-        },
-
-        parameters: {
-            person: LP.client.get_absolute_uri(subscriber.get('escaped_uri')),
-            suppress_notify: false,
-            level: bug_notification_level
-        }
-    };
-    lp_client.named_post(bug_repr.self_link, 'subscribe', config);
-}
-
-/*
- * Unsubscribe the current user via the LP API.
- *
- * @method unsubscribe_current_user
- * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
- */
-function unsubscribe_current_user(subscription) {
-    subscription.enable_spinner('Unsubscribing...');
-    var subscription_link = subscription.get('link');
-    var subscriber = subscription.get('subscriber');
-
-    var error_handler = new LP.client.ErrorHandler();
-    error_handler.clearProgressUI = function () {
-        subscription.disable_spinner();
-    };
-    error_handler.showError = function (error_msg) {
-        Y.lp.app.errors.display_error(subscription_link, error_msg);
-    };
-
-    var config = {
-        on: {
-            success: function(client) {
-                if (subscription.is_direct_subscription() &&
-                    subscription.has_duplicate_subscriptions()) {
-                    // Don't change the 'Unsubscribe' text if
-                    // dupe subscriptions remain.
-                    subscription.disable_spinner();
-                    set_subscription_link_parent_class(
-                        subscription_link, false, true);
-                    subscription.set('is_direct', false);
-                } else if (subscription.is_direct_subscription() &&
-                          !subscription.has_duplicate_subscriptions()) {
-                    // Only unsub'ing a direct subscriber here.
-                    subscription.disable_spinner(
-                        subscription_labels.SUBSCRIBE);
-                    set_subscription_link_parent_class(
-                        subscription_link, false, false);
-                    subscription.set('is_direct', false);
-                } else {
-                    // Only unsub'ing dupes here.
-                    subscription.disable_spinner(
-                        subscription_labels.SUBSCRIBE);
-                    set_subscription_link_parent_class(
-                        subscription_link, false, false);
-                    subscription.set('has_dupes', false);
-                }
-
-                var flash_node = Y.one('.' + subscriber.get('css_name'));
-                var anim = Y.lazr.anim.green_flash({ node: flash_node });
-                anim.on('end', function(e) {
-                    remove_user_name_link(flash_node);
-                    set_none_for_empty_subscribers();
-                });
-                anim.run();
-            },
-
-            failure: error_handler.getFailureHandler()
-        }
-    };
-    if (subscription.is_direct_subscription()) {
-        lp_client.named_post(bug_repr.self_link, 'unsubscribe', config);
-    } else {
-        lp_client.named_post(
-            bug_repr.self_link, 'unsubscribeFromDupes', config);
-    }
-}
-
 
 /**
  * Set up a bug task table row.
@@ -1815,106 +917,6 @@
             LP.client.cache.bug.self_link, 'markUserAffected', config);
     }
 });
-
-/*
- * Check if the current user can unsubscribe the person
- * being subscribed.
- *
- * This must be done in JavaScript, since the subscription
- * hasn't completed yet, and so, can_be_unsubscribed_by_user
- * cannot be used.
- *
- * @method check_can_be_unsubscribed
- * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
- */
-function check_can_be_unsubscribed(subscription) {
-    var error_handler = new LP.client.ErrorHandler();
-    error_handler.showError = function (error_msg) {
-        Y.lp.app.errors.display_error(
-           Y.one('.menu-link-addsubscriber'), error_msg);
-    };
-
-    var config = {
-        on: {
-            success: function(result) {
-                var is_team = result.get('is_team');
-                subscription.set('is_team', is_team);
-                var final_config = {
-                    on: {
-                        success: function(result) {
-                            var team_member = false;
-                            for (var i=0; i<result.entries.length; i++) {
-                                 if (result.entries[i].member_link ==
-                                    LP.client.get_absolute_uri(
-                                        subscription.get(
-                                            'subscriber').get('uri'))) {
-                                    team_member = true;
-                                }
-                            }
-
-                            if (team_member) {
-                                subscription.set('can_be_unsubscribed', true);
-                                add_temp_user_name(subscription);
-                            } else {
-                                subscription.set(
-                                   'can_be_unsubscribed', false);
-                                add_temp_user_name(subscription);
-                            }
-                        },
-
-                        failure: error_handler.getFailureHandler()
-                    }
-                };
-
-                if (is_team) {
-                    // Get a list of members to see if current user
-                    // is a team member.
-                    var members = result.get(
-                       'members_details_collection_link');
-                    lp_client.get(members, final_config);
-                } else {
-                    subscription.set('can_be_unsubscribed', false);
-                    add_temp_user_name(subscription);
-                }
-            },
-
-            failure: error_handler.getFailureHandler()
-        }
-    };
-    lp_client.get(LP.client.get_absolute_uri(
-        subscription.get('person').get('escaped_uri')), config);
-}
-
-/*
- * Subscribe a person or team other than the current user.
- * This is a callback for the subscribe someone else picker.
- *
- * @method subscribe_someone_else
- * @result {Object} The object representing a person returned by the API.
- */
-function subscribe_someone_else(result, subscription) {
-    var person = new Y.lp.bugs.subscriber.Subscriber({
-        uri: result.api_uri,
-        display_name: result.title,
-        subscriber_ids: subscriber_ids
-    });
-    subscription.set('person', person);
-
-    var error_handler = new LP.client.ErrorHandler();
-    error_handler.showError = function(error_msg) {
-        Y.lp.app.errors.display_error(
-           Y.one('.menu-link-addsubscriber'), error_msg);
-    };
-
-    if (subscription.is_already_subscribed()) {
-        error_handler.showError(
-             subscription.get('person').get('full_display_name') +
-             ' has already been subscribed');
-    } else {
-        check_can_be_unsubscribed(subscription);
-    }
-}
-
 /*
  * Click handling to pass comment text to the attachment
  * page if there is a comment.
@@ -1935,114 +937,10 @@
     });
 }
 
-function load_subscribers_from_duplicates() {
-    if (Y.UA.ie) {
-        return null;
-    }
-
-    Y.one('#subscribers-portlet-dupe-spinner').setStyle(
-        'display', 'block');
-
-    function hide_spinner() {
-        Y.one('#subscribers-portlet-dupe-spinner').setStyle(
-            'display', 'none');
-        // Fire a custom event to signal failure, so that
-        // any remaining unsub icons can be hooked up.
-        namespace.portlet.fire('bugs:dupeportletloadfailed');
-    }
-
-    function on_success(transactionid, response, args) {
-        hide_spinner();
-
-        var dupe_subscribers_container = Y.one(
-            '#subscribers-from-duplicates-container');
-        dupe_subscribers_container.set(
-            'innerHTML',
-            dupe_subscribers_container.get('innerHTML') +
-            response.responseText);
-
-        // Fire a custom portlet loaded event to notify when
-        // it's safe to setup dupe subscriber link callbacks.
-        namespace.portlet.fire('bugs:dupeportletloaded');
-    }
-
-    var config = {on: {success: on_success,
-                       failure: hide_spinner}};
-    var url = Y.one(
-        '#subscribers-from-dupes-content-link').getAttribute(
-            'href').replace('bugs.', '');
-    Y.io(url, config);
-}
-
-namespace.load_subscribers_portlet = function(
-        subscription_link, subscription_link_handler) {
-    if (Y.UA.ie) {
-        return null;
-    }
-
-    Y.one('#subscribers-portlet-spinner').setStyle('display', 'block');
-
-    function hide_spinner() {
-        Y.one('#subscribers-portlet-spinner').setStyle('display', 'none');
-            // Fire a custom event to notify that the initial click
-            // handler on subscription_link set above should be
-            // cleared.
-            if (namespace) {
-                namespace.portlet.fire(
-                  'bugs:portletloadfailed', subscription_link_handler);
-        }
-    }
-
-    function setup_portlet(transactionid, response, args) {
-        hide_spinner();
-        var portlet = Y.one('#portlet-subscribers');
-        portlet.set('innerHTML',
-                    portlet.get('innerHTML') + response.responseText);
-
-        // Fire a custom portlet loaded event to notify when
-        // it's safe to setup subscriber link callbacks.
-        namespace.portlet.fire('bugs:portletloaded');
-    }
-
-    var config = {on: {success: setup_portlet,
-                       failure: hide_spinner}};
-    var url = Y.one(
-        '#subscribers-content-link').getAttribute('href').replace(
-            'bugs.', '');
-    Y.io(url, config);
-};
-
-function load_subscriber_ids() {
-    function on_success(transactionid, response, args) {
-        try {
-            subscriber_ids = Y.JSON.parse(response.responseText);
-
-            // Fire a custom event to trigger the setting-up of the
-            // subscription handlers.
-            namespace.portlet.fire('bugs:portletsubscriberidsloaded');
-        } catch (e) {
-            // Fire an event to signal failure. This ensures that the
-            // subscribers-from-dupes still get loaded into the portlet.
-            namespace.portlet.fire('bugs:portletsubscriberidsfailed');
-        }
-    }
-
-    function on_failure() {
-        // Fire an event to signal failure. This ensures that the
-        // subscribers-from-dupes still get loaded into the portlet.
-        namespace.portlet.fire('bugs:portletsubscriberidsfailed');
-    }
-
-    var config = {on: {success: on_success,
-                       failure: on_failure}};
-    var url = Y.one(
-        '#subscribers-ids-link').getAttribute('href');
-    Y.io(url, config);
-}
 
 }, "0.1", {"requires": ["base", "oop", "node", "event", "io-base",
                         "json-parse", "substitute", "widget-position-ext",
                         "lazr.formoverlay", "lazr.anim", "lazr.base",
                         "lazr.overlay", "lazr.choiceedit", "lp.app.picker",
-                        "lp.client.plugins", "lp.bugs.subscriber",
-                        "lp.app.errors"]});
+                        "lp.client.plugins", "lp.bugs.bugtask_index.portlets",
+                        "lp.bugs.subscriber", "lp.app.errors"]});

=== added file 'lib/lp/bugs/javascript/bugtask_index_portlets.js'
--- lib/lp/bugs/javascript/bugtask_index_portlets.js	1970-01-01 00:00:00 +0000
+++ lib/lp/bugs/javascript/bugtask_index_portlets.js	2011-02-15 14:49:55 +0000
@@ -0,0 +1,1145 @@
+/* Copyright 2011 Canonical Ltd.  This software is licensed under the
+ * GNU Affero General Public License version 3 (see the file LICENSE).
+ *
+ * Form overlay widgets and subscriber handling for bug pages.
+ *
+ * @module bugs
+ * @submodule bugtask_index.portlets
+ */
+
+YUI.add('lp.bugs.bugtask_index.portlets', function(Y) {
+
+var namespace = Y.namespace('lp.bugs.bugtask_index.portlets');
+
+// The launchpad js client used.
+var lp_client;
+
+// The launchpad client entry for the current bug.
+var lp_bug_entry;
+
+// The bug itself, taken from cache.
+var bug_repr;
+
+// A boolean telling us whether advanced subscription features are to be
+// used or not.
+// XXX 2011-01-14 gmb bug=702859:
+//     We need to expose feature flags via the API to avoid this kind of
+//     thing.
+var use_advanced_subscriptions = false;
+
+var subscription_labels = Y.lp.bugs.subscriber.subscription_labels;
+
+/*
+ * An object representing the bugtask subscribers portlet.
+ *
+ * Since the portlet loads via XHR and inline subscribing
+ * depends on that portlet being loaded, setup a custom
+ * event object, to provide a hook for initializing subscription
+ * link callbacks after custom events.
+ */
+var PortletTarget = function() {};
+Y.augment(PortletTarget, Y.Event.Target);
+namespace.portlet = new PortletTarget();
+
+/*
+ * Create the lp client and bug entry if we haven't done so already.
+ *
+ * @method setup_client_and_bug
+ */
+function setup_client_and_bug() {
+    lp_client = new LP.client.Launchpad();
+
+    if (bug_repr === undefined) {
+        bug_repr = LP.client.cache.bug;
+        lp_bug_entry = new LP.client.Entry(
+            lp_client, bug_repr, bug_repr.self_link);
+    }
+}
+
+namespace.load_subscribers_portlet = function(
+        subscription_link, subscription_link_handler) {
+    if (Y.UA.ie) {
+        return null;
+    }
+
+    Y.one('#subscribers-portlet-spinner').setStyle('display', 'block');
+
+    function hide_spinner() {
+        Y.one('#subscribers-portlet-spinner').setStyle('display', 'none');
+            // Fire a custom event to notify that the initial click
+            // handler on subscription_link set above should be
+            // cleared.
+            if (namespace) {
+                namespace.portlet.fire(
+                  'bugs:portletloadfailed', subscription_link_handler);
+        }
+    }
+
+    function setup_portlet(transactionid, response, args) {
+        hide_spinner();
+        var portlet = Y.one('#portlet-subscribers');
+        portlet.set('innerHTML',
+                    portlet.get('innerHTML') + response.responseText);
+
+        // Fire a custom portlet loaded event to notify when
+        // it's safe to setup subscriber link callbacks.
+        namespace.portlet.fire('bugs:portletloaded');
+    }
+
+    var config = {on: {success: setup_portlet,
+                       failure: hide_spinner}};
+    var url = Y.one(
+        '#subscribers-content-link').getAttribute('href').replace(
+            'bugs.', '');
+    Y.io(url, config);
+};
+
+
+namespace.setup_portlet_handlers = function() {
+    namespace.portlet.subscribe('bugs:portletloaded', function() {
+        load_subscriber_ids();
+    });
+    namespace.portlet.subscribe('bugs:dupeportletloaded', function() {
+        setup_unsubscribe_icon_handlers();
+    });
+    /*
+     * If the subscribers portlet fails to load, clear any
+     * click handlers, so the normal subscribe page can be reached.
+     */
+    namespace.portlet.subscribe('bugs:portletloadfailed', function(handlers) {
+        if (Y.Lang.isArray(handlers)) {
+            var click_handler = handlers[0];
+            click_handler.detach();
+        }
+    });
+    /* If the dupe subscribers portlet fails to load,
+     * be sure to try to handle any unsub icons that may
+     * exist for others.
+     */
+    namespace.portlet.subscribe(
+        'bugs:dupeportletloadfailed',
+        function(handlers) {
+            setup_unsubscribe_icon_handlers();
+        });
+
+    /* If loading the subscriber IDs JSON has succeeded, set up the
+     * subscription link handlers and load the subscribers from dupes.
+     */
+    namespace.portlet.subscribe(
+        'bugs:portletsubscriberidsloaded',
+        function() {
+            setup_subscription_link_handlers();
+            load_subscribers_from_duplicates();
+        });
+
+    /* If loading the subscriber IDs JSON fails we still need to load the
+     * subscribers from duplicates but we don't set up the subscription link
+     * handlers.
+     */
+    namespace.portlet.subscribe(
+        'bugs:portletsubscriberidsfailed',
+        function() {
+            load_subscribers_from_duplicates();
+        });
+
+    /*
+     * Subscribing someone else requires loading a grayed out
+     * username into the DOM until the subscribe action completes.
+     * There are a couple XHR requests in check_can_be_unsubscribed
+     * before the subscribe work can be done, so fire a custom event
+     * bugs:nameloaded and do the work here when the event fires.
+     */
+    namespace.portlet.subscribe('bugs:nameloaded', function(subscription) {
+        var error_handler = new LP.client.ErrorHandler();
+        error_handler.clearProgressUI = function() {
+            var temp_link = Y.one('#temp-username');
+            if (temp_link) {
+                var temp_parent = temp_link.get('parentNode');
+                temp_parent.removeChild(temp_link);
+            }
+        };
+        error_handler.showError = function(error_msg) {
+            Y.lp.app.errors.display_error(
+                Y.one('.menu-link-addsubscriber'), error_msg);
+        };
+
+        var config = {
+            on: {
+                success: function() {
+                    var temp_link = Y.one('#temp-username');
+                    var temp_spinner = Y.one('#temp-name-spinner');
+                    temp_link.removeChild(temp_spinner);
+                    var anim = Y.lazr.anim.green_flash({ node: temp_link });
+                    anim.on('end', function() {
+                        add_user_name_link(subscription);
+                        var temp_parent = temp_link.get('parentNode');
+                        temp_parent.removeChild(temp_link);
+                    });
+                    anim.run();
+                },
+                failure: error_handler.getFailureHandler()
+            },
+            parameters: {
+                person: LP.client.get_absolute_uri(
+                    subscription.get('person').get('escaped_uri')),
+                suppress_notify: false
+            }
+        };
+        lp_client.named_post(bug_repr.self_link, 'subscribe', config);
+    });
+}
+
+function load_subscriber_ids() {
+    function on_success(transactionid, response, args) {
+        try {
+            subscriber_ids = Y.JSON.parse(response.responseText);
+
+            // Fire a custom event to trigger the setting-up of the
+            // subscription handlers.
+            namespace.portlet.fire('bugs:portletsubscriberidsloaded');
+        } catch (e) {
+            // Fire an event to signal failure. This ensures that the
+            // subscribers-from-dupes still get loaded into the portlet.
+            namespace.portlet.fire('bugs:portletsubscriberidsfailed');
+        }
+    }
+
+    function on_failure() {
+        // Fire an event to signal failure. This ensures that the
+        // subscribers-from-dupes still get loaded into the portlet.
+        namespace.portlet.fire('bugs:portletsubscriberidsfailed');
+    }
+
+    var config = {on: {success: on_success,
+                       failure: on_failure}};
+    var url = Y.one(
+        '#subscribers-ids-link').getAttribute('href');
+    Y.io(url, config);
+}
+
+/*
+ * Set click handlers for unsubscribe remove icons.
+ *
+ * @method setup_unsubscribe_icon_handlers
+ * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
+ */
+function setup_unsubscribe_icon_handlers() {
+    var subscription = new Y.lp.bugs.subscriber.Subscription({
+        link: Y.one('.menu-link-subscription'),
+        spinner: Y.one('#sub-unsub-spinner'),
+        subscriber: new Y.lp.bugs.subscriber.Subscriber({
+            uri: LP.client.links.me,
+            subscriber_ids: subscriber_ids
+        })
+    });
+
+    Y.on('click', function(e) {
+        e.halt();
+        unsubscribe_user_via_icon(e.target, subscription);
+    }, '.unsub-icon');
+}
+
+/*
+ * Initialize callbacks for subscribe/unsubscribe links.
+ *
+ * @method setup_subscription_link_handlers
+ */
+function setup_subscription_link_handlers() {
+    if (LP.client.links.me === undefined) {
+        return;
+    }
+
+    setup_client_and_bug();
+    var subscription = new Y.lp.bugs.subscriber.Subscription({
+        link: Y.one('.menu-link-subscription'),
+        spinner: Y.one('#sub-unsub-spinner'),
+        subscriber: new Y.lp.bugs.subscriber.Subscriber({
+            uri: LP.client.links.me,
+            subscriber_ids: subscriber_ids
+        })
+    });
+
+    var is_direct = subscription.get(
+        'link').get('parentNode').hasClass('subscribed-true');
+    var has_dupes = subscription.get(
+        'link').get('parentNode').hasClass('dup-subscribed-true');
+    subscription.set('is_direct', is_direct);
+    subscription.set('has_dupes', has_dupes);
+
+    if (subscription.is_node()) {
+        subscription.get('link').on('click', function(e) {
+            e.halt();
+            subscription.set('can_be_unsubscribed', true);
+            subscription.set('person', subscription.get('subscriber'));
+            subscription.set('is_team', false);
+            var parent = e.target.get('parentNode');
+            if (namespace.use_advanced_subscriptions) {
+                var subscription_overlay =
+                    setup_advanced_subscription_overlay(subscription);
+                subscription_overlay.show();
+            } else {
+                // Look for the false conditions of subscription, which
+                // is_direct_subscription, etc. don't report correctly,
+                // to make sure we only use subscribe_current_user for
+                // the current user.
+                if (parent.hasClass('subscribed-false') &&
+                    parent.hasClass('dup-subscribed-false')) {
+                    subscribe_current_user(subscription);
+                }
+                else {
+                    unsubscribe_current_user(subscription);
+                }
+            }
+        });
+        subscription.get('link').addClass('js-action');
+    }
+
+    setup_subscribe_someone_else_handler(subscription);
+}
+
+function load_subscribers_from_duplicates() {
+    if (Y.UA.ie) {
+        return null;
+    }
+
+    Y.one('#subscribers-portlet-dupe-spinner').setStyle(
+        'display', 'block');
+
+    function hide_spinner() {
+        Y.one('#subscribers-portlet-dupe-spinner').setStyle(
+            'display', 'none');
+        // Fire a custom event to signal failure, so that
+        // any remaining unsub icons can be hooked up.
+        namespace.portlet.fire('bugs:dupeportletloadfailed');
+    }
+
+    function on_success(transactionid, response, args) {
+        hide_spinner();
+
+        var dupe_subscribers_container = Y.one(
+            '#subscribers-from-duplicates-container');
+        dupe_subscribers_container.set(
+            'innerHTML',
+            dupe_subscribers_container.get('innerHTML') +
+            response.responseText);
+
+        // Fire a custom portlet loaded event to notify when
+        // it's safe to setup dupe subscriber link callbacks.
+        namespace.portlet.fire('bugs:dupeportletloaded');
+    }
+
+    var config = {on: {success: on_success,
+                       failure: hide_spinner}};
+    var url = Y.one(
+        '#subscribers-from-dupes-content-link').getAttribute(
+            'href').replace('bugs.', '');
+    Y.io(url, config);
+}
+
+/*
+ * Add the user name to the subscriber's list.
+ *
+ * @method add_user_name_link
+ */
+function add_user_name_link(subscription) {
+    var person = subscription.get('person');
+    var link_node = build_user_link_html(subscription);
+    var subscribers = Y.one('#subscribers-links');
+    if (subscription.is_current_user_subscribing()) {
+        // If this is the current user, then top post the name and be done.
+        subscribers.insertBefore(link_node, subscribers.get('firstChild'));
+    } else {
+        var next = get_next_subscriber_node(subscription);
+        if (next) {
+            subscribers.insertBefore(link_node, next);
+        } else {
+            // Handle the case of the displayed "None".
+            var none_subscribers = Y.one('#none-subscribers');
+            if (none_subscribers) {
+                var none_parent = none_subscribers.get('parentNode');
+                none_parent.removeChild(none_subscribers);
+            }
+            subscribers.appendChild(link_node);
+        }
+    }
+
+    // Set the click handler if adding a remove icon.
+    if (subscription.can_be_unsubscribed_by_user()) {
+        var remove_icon =
+          Y.one('#unsubscribe-icon-' + person.get('css_name'));
+        remove_icon.on('click', function(e) {
+            e.halt();
+            unsubscribe_user_via_icon(e.target, subscription);
+        });
+    }
+}
+
+/*
+ * Unsubscribe a user from this bugtask when a remove icon is clicked.
+ *
+ * @method unsubscribe_user_via_icon
+ * @param icon {Node} The remove icon that was clicked.
+ * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
+*/
+function unsubscribe_user_via_icon(icon, subscription) {
+    icon.set('src', '/@@/spinner');
+    var icon_parent = icon.get('parentNode');
+
+    var user_uri = get_user_uri_from_icon(icon);
+    var person = new Y.lp.bugs.subscriber.Subscriber({
+        uri: user_uri,
+        subscriber_ids: subscriber_ids
+    });
+    subscription.set('person', person);
+
+    // Determine if this is a dupe.
+    var is_dupe;
+    var icon_parent_div = icon_parent.get('parentNode');
+    var dupe_id = 'dupe-' + person.get('css_name');
+    if (icon_parent_div.get('id') == dupe_id) {
+        is_dupe = true;
+    } else {
+        is_dupe = false;
+    }
+
+    var error_handler = new LP.client.ErrorHandler();
+    error_handler.clearProgressUI = function () {
+        icon.set('src', '/@@/remove');
+        // Grab the icon again to reset to click handler.
+        var unsubscribe_icon = Y.one(
+            '#unsubscribe-icon-' + person.get('css_name'));
+        unsubscribe_icon.on('click', function(e) {
+            e.halt();
+            unsubscribe_user_via_icon(e.target, subscription);
+        });
+
+    };
+    error_handler.showError = function (error_msg) {
+        var flash_node = Y.one('.' + person.get('css_name'));
+        Y.lp.app.errors.display_error(flash_node, error_msg);
+
+    };
+
+    var subscription_link = subscription.get('link');
+    var config = {
+        on: {
+            success: function(client) {
+                icon_parent.removeChild(icon);
+                var anim = Y.lazr.anim.green_flash({ node: icon_parent_div });
+                anim.on('end', function(e) {
+                    remove_user_name_link(icon_parent_div);
+                    set_none_for_empty_subscribers();
+                    var person_link = Y.one('.' + person.get('css_name'));
+                    if (Y.Lang.isNull(person_link) &&
+                        subscription.is_current_user_subscribing()) {
+                            // Current user has been completely unsubscribed.
+                            subscription.disable_spinner(
+                                subscription_labels.SUBSCRIBE);
+                            set_subscription_link_parent_class(
+                                subscription_link, false, false);
+                            subscription.set('is_direct', false);
+                            subscription.set('has_dupes', false);
+                    } else {
+                        if (is_dupe) {
+                            // A direct subscription remains.
+                            set_subscription_link_parent_class(
+                                subscription_link, true, false);
+                            subscription.set('is_direct', true);
+                            subscription.set('has_dupes', false);
+                        } else {
+                            // A dupe subscription remains.
+                            set_subscription_link_parent_class(
+                                subscription_link, false, true);
+                            subscription.set('is_direct', false);
+                            subscription.set('has_dupes', true);
+                        }
+                    }
+                });
+                anim.run();
+            },
+
+            failure: error_handler.getFailureHandler()
+        }
+    };
+
+    if (!subscription.is_current_user_subscribing()) {
+        config.parameters = {
+            person: LP.client.get_absolute_uri(user_uri)
+        };
+    }
+
+    if (is_dupe) {
+        lp_client.named_post(
+            bug_repr.self_link, 'unsubscribeFromDupes', config);
+    } else {
+        lp_client.named_post(bug_repr.self_link, 'unsubscribe', config);
+    }
+}
+
+/*
+ * Create and return a FormOverlay for advanced subscription
+ * interactions.
+ *
+ * @method setup_advanced_subscription_overlay
+ * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
+ */
+function setup_advanced_subscription_overlay(subscription) {
+    var subscription_overlay = new Y.lazr.FormOverlay({
+        headerContent: '<h2>Subscribe to bug</h2>',
+        form_submit_button:
+            Y.Node.create(submit_button_html),
+        form_cancel_button:
+            Y.Node.create(cancel_button_html),
+        centered: true,
+        visible: false
+    });
+    subscription_overlay.set(
+        'form_submit_callback', function(form_data) {
+        handle_advanced_subscription_overlay(subscription, form_data);
+        subscription_overlay.hide();
+    });
+
+    var subscription_link_url = subscription.get(
+        'link').get('href') + '/++form++';
+    subscription_overlay.loadFormContentAndRender(
+        subscription_link_url);
+    subscription_overlay.render('#privacy-form-container');
+    return subscription_overlay
+}
+
+/*
+ * Subscribe the current user via the LP API.
+ *
+ * @method subscribe_current_user
+ * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
+ */
+function subscribe_current_user(subscription) {
+    subscription.enable_spinner('Subscribing...');
+    var subscription_link = subscription.get('link');
+    var subscriber = subscription.get('subscriber');
+    var bug_notification_level = subscription.get('bug_notification_level');
+
+    var error_handler = new LP.client.ErrorHandler();
+    error_handler.clearProgressUI = function () {
+        subscription.disable_spinner();
+    };
+    error_handler.showError = function (error_msg) {
+        Y.lp.app.errors.display_error(subscription_link, error_msg);
+    };
+
+    var config = {
+        on: {
+            success: function(client) {
+                if (namespace.use_advanced_subscriptions) {
+                    subscription.disable_spinner(
+                        subscription_labels.EDIT);
+                } else {
+                    subscription.disable_spinner(
+                        subscription_labels.UNSUBSCRIBE);
+                }
+
+                if (subscription.has_duplicate_subscriptions()) {
+                    set_subscription_link_parent_class(
+                        subscription_link, true, true);
+                } else {
+                    set_subscription_link_parent_class(
+                        subscription_link, true, false);
+                }
+
+                // Handle the case where the subscriber's list displays
+                // "None".
+                var empty_subscribers = Y.one("#none-subscribers");
+                if (empty_subscribers) {
+                    var parent = empty_subscribers.get('parentNode');
+                    parent.removeChild(empty_subscribers);
+                }
+
+                add_user_name_link(subscription);
+
+                var flash_node = Y.one('.' + subscriber.get('css_name'));
+                var anim = Y.lazr.anim.green_flash({ node: flash_node });
+                anim.run();
+            },
+
+            failure: error_handler.getFailureHandler()
+        },
+
+        parameters: {
+            person: LP.client.get_absolute_uri(subscriber.get('escaped_uri')),
+            suppress_notify: false,
+            level: bug_notification_level
+        }
+    };
+    lp_client.named_post(bug_repr.self_link, 'subscribe', config);
+}
+
+/*
+ * Unsubscribe the current user via the LP API.
+ *
+ * @method unsubscribe_current_user
+ * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
+ */
+function unsubscribe_current_user(subscription) {
+    subscription.enable_spinner('Unsubscribing...');
+    var subscription_link = subscription.get('link');
+    var subscriber = subscription.get('subscriber');
+
+    var error_handler = new LP.client.ErrorHandler();
+    error_handler.clearProgressUI = function () {
+        subscription.disable_spinner();
+    };
+    error_handler.showError = function (error_msg) {
+        Y.lp.app.errors.display_error(subscription_link, error_msg);
+    };
+
+    var config = {
+        on: {
+            success: function(client) {
+                if (subscription.is_direct_subscription() &&
+                    subscription.has_duplicate_subscriptions()) {
+                    // Don't change the 'Unsubscribe' text if
+                    // dupe subscriptions remain.
+                    subscription.disable_spinner();
+                    set_subscription_link_parent_class(
+                        subscription_link, false, true);
+                    subscription.set('is_direct', false);
+                } else if (subscription.is_direct_subscription() &&
+                          !subscription.has_duplicate_subscriptions()) {
+                    // Only unsub'ing a direct subscriber here.
+                    subscription.disable_spinner(
+                        subscription_labels.SUBSCRIBE);
+                    set_subscription_link_parent_class(
+                        subscription_link, false, false);
+                    subscription.set('is_direct', false);
+                } else {
+                    // Only unsub'ing dupes here.
+                    subscription.disable_spinner(
+                        subscription_labels.SUBSCRIBE);
+                    set_subscription_link_parent_class(
+                        subscription_link, false, false);
+                    subscription.set('has_dupes', false);
+                }
+
+                var flash_node = Y.one('.' + subscriber.get('css_name'));
+                var anim = Y.lazr.anim.green_flash({ node: flash_node });
+                anim.on('end', function(e) {
+                    remove_user_name_link(flash_node);
+                    set_none_for_empty_subscribers();
+                });
+                anim.run();
+            },
+
+            failure: error_handler.getFailureHandler()
+        }
+    };
+    if (subscription.is_direct_subscription()) {
+        lp_client.named_post(bug_repr.self_link, 'unsubscribe', config);
+    } else {
+        lp_client.named_post(
+            bug_repr.self_link, 'unsubscribeFromDupes', config);
+    }
+}
+
+/*
+ * Initialize click handler for the subscribe someone else link.
+ *
+ * @method setup_subscribe_someone_else_handler
+ * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
+ */
+function setup_subscribe_someone_else_handler(subscription) {
+    var config = {
+        header: 'Subscribe someone else',
+        step_title: 'Search',
+        picker_activator: '.menu-link-addsubscriber'
+    };
+
+    config.save = function(result) {
+        subscribe_someone_else(result, subscription);
+    };
+    var picker = Y.lp.app.picker.create('ValidPersonOrTeam', config);
+}
+
+/*
+ * Build the HTML for a user link for the subscribers list.
+ *
+ * @method build_user_link_html
+ * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
+ * @return html {String} The HTML used for creating a subscriber link.
+ */
+function build_user_link_html(subscription) {
+    var name = subscription.get('person').get('name');
+    var css_name = subscription.get('person').get('css_name');
+    var full_name = subscription.get('person').get('full_display_name');
+    // Be paranoid about display_name, since timeouts or other errors
+    // could mean display_name wasn't set on initialization.
+    if (subscription.get('person').get('display_name') === '') {
+        subscription.get('person').set_display_name();
+    }
+    var display_name = subscription.get('person').get('display_name');
+    var terms = {
+        name: name,
+        css_name: css_name,
+        display_name: display_name,
+        full_name: full_name
+    };
+
+    if (subscription.is_current_user_subscribing()) {
+        terms.subscribed_by = 'themselves';
+    } else {
+        terms.subscribed_by = 'by ' + full_name;
+    }
+
+    var html = Y.Node.create('<div><a></a></div>');
+    html.addClass(terms.css_name);
+
+    if (subscription.is_direct_subscription()) {
+        html.set('id', 'direct-' + terms.css_name);
+    } else {
+        html.set('id', 'dupe-' + terms.css_name);
+    }
+
+    html.one('a')
+        .set('href', '/~' + terms.name)
+        .set('name', terms.full_name)
+        .set('title', 'Subscribed ' + terms.subscribed_by);
+
+    var span;
+    if (subscription.is_team()) {
+        span = '<span class="sprite team"></span>';
+    } else {
+        span = '<span class="sprite person"></span>';
+    }
+
+    html.one('a')
+        .appendChild(Y.Node.create(span))
+        .appendChild(document.createTextNode(terms.display_name));
+
+    // Add remove icon if the current user can unsubscribe the subscriber.
+    if (subscription.can_be_unsubscribed_by_user()) {
+        var icon_html = Y.Node.create(
+            '<a href="+subscribe">' +
+            '<img class="unsub-icon" src="/@@/remove" alt="Remove" /></a>');
+        icon_html
+            .set('id', 'unsubscribe-' + terms.css_name)
+            .set('title', 'Unsubscribe ' + terms.full_name);
+        icon_html.one('img')
+            .set('id', 'unsubscribe-icon-' + terms.css_name);
+        html.appendChild(icon_html);
+    }
+
+    return html;
+}
+
+/*
+ * Returns the next node in alphabetical order after the subscriber
+ * node now being added.  No node is returned to append to end of list.
+ *
+ * The name can appear in one of two different lists. 1) The list of
+ * subscribers that can be unsubscribed by the current user, and
+ * 2) the list of subscribers that cannot be unsubscribed.
+ *
+ * @method get_next_subscriber_node
+ * @param subscription_link {Node} The sub/unsub link.
+ * @return {Node} The node appearing next in the subscriber list or
+ *          undefined if no node is next.
+ */
+function get_next_subscriber_node(subscription) {
+    var full_name = subscription.get('person').get('full_display_name');
+    var can_be_unsubscribed = subscription.can_be_unsubscribed_by_user();
+    var nodes_by_name = {};
+    var unsubscribables = [];
+    var not_unsubscribables = [];
+
+    // Use the list of subscribers pulled from the DOM to have sortable
+    // lists of unsubscribable vs. not unsubscribale person links.
+    var all_subscribers = Y.all('#subscribers-links div');
+    if (all_subscribers.size() > 0) {
+        all_subscribers.each(function(sub_link) {
+            if (sub_link.getAttribute('id') != 'temp-username') {
+                // User's displayname is found via the link's "name"
+                // attribute.
+                var sub_link_name = sub_link.one('a').getAttribute('name');
+                nodes_by_name[sub_link_name] = sub_link;
+                if (sub_link.one('img.unsub-icon')) {
+                    unsubscribables.push(sub_link_name);
+                } else {
+                    not_unsubscribables.push(sub_link_name);
+                }
+            }
+        });
+
+        // Add the current subscription.
+        if (can_be_unsubscribed) {
+            unsubscribables.push(full_name);
+        } else {
+            not_unsubscribables.push(full_name);
+        }
+        unsubscribables.sort();
+        not_unsubscribables.sort();
+    } else {
+        // If there is no all_subscribers, then we're dealing with
+        // the printed None, so return.
+        return;
+    }
+
+    var i;
+    if ((!unsubscribables && !not_unsubscribables) ||
+        // If A) neither list exists, B) the user belongs in the second
+        // list but the second list doesn't exist, or C) user belongs in the
+        // first list and the second doesn't exist, return no node to append.
+        (!can_be_unsubscribed && !not_unsubscribables) ||
+        (can_be_unsubscribed && unsubscribables && !not_unsubscribables)) {
+        return;
+    } else if (
+        // If the user belongs in the first list, and the first list
+        // doesn't exist, but the second one does, return the first node
+        // in the second list.
+        can_be_unsubscribed && !unsubscribables && not_unsubscribables) {
+        return nodes_by_name[not_unsubscribables[0]];
+    } else if (can_be_unsubscribed) {
+        // If the user belongs in the first list, loop the list for position.
+        for (i=0; i<unsubscribables.length; i++) {
+            if (unsubscribables[i] == full_name) {
+                if (i+1 < unsubscribables.length) {
+                    return nodes_by_name[unsubscribables[i+1]];
+                // If the current link should go at the end of the first
+                // list and we're at the end of that list, return the
+                // first node of the second list.  Due to earlier checks
+                // we can be sure this list exists.
+                } else if (i+1 >= unsubscribables.length) {
+                    return nodes_by_name[not_unsubscribables[0]];
+                }
+            }
+        }
+    } else if (!can_be_unsubscribed) {
+        // If user belongs in the second list, loop the list for position.
+        for (i=0; i<not_unsubscribables.length; i++) {
+            if (not_unsubscribables[i] == full_name) {
+                if (i+1 < not_unsubscribables.length) {
+                    return nodes_by_name[not_unsubscribables[i+1]];
+                } else {
+                    return;
+                }
+            }
+        }
+    }
+}
+
+/*
+ * Traverse the DOM of a given remove icon to find
+ * the user's link.  Returns a URI of the form "/~username".
+ *
+ * @method get_user_uri_from_icon
+ * @param icon {Node} The node representing a remove icon.
+ * @return user_uri {String} The user's uri, without the hostname.
+ */
+function get_user_uri_from_icon(icon) {
+    var parent_div = icon.get('parentNode').get('parentNode');
+    // This should be parent_div.firstChild, but because of #text
+    // and cross-browser issues, using the YUI query syntax is
+    // safer here.
+    var user_uri = parent_div.one('a').getAttribute('href');
+
+    // Strip the domain off. We just want a path.
+    var host_start = user_uri.indexOf('//');
+    if (host_start != -1) {
+        var host_end = user_uri.indexOf('/', host_start+2);
+        return user_uri.substring(host_end, user_uri.length);
+    }
+
+    return user_uri;
+}
+
+/*
+ * Used to remove the user's name from the subscriber's list.
+ *
+ * @method remove_user_name_link
+ * @param user_node {Node} Node representing the user name link.
+ */
+function remove_user_name_link(user_node) {
+    var parent = user_node.get('parentNode');
+    parent.removeChild(user_node);
+}
+
+/*
+ * Add the "None" div to the subscribers list if
+ * there aren't any subscribers left.
+ *
+ * @method set_none_for_empty_subscribers
+ */
+function set_none_for_empty_subscribers() {
+    var subscriber_list = Y.one('#subscribers-links');
+    // Assume if subscriber_list has no child divs
+    // then the list of subscribers is empty.
+    if (!Y.Lang.isValue(subscriber_list.one('div')) &&
+        !Y.Lang.isValue(Y.one('#none-subscribers'))) {
+        var none_div = Y.Node.create('<div id="none-subscribers">None</div>');
+        subscriber_list.appendChild(none_div);
+    }
+
+    // Clear the empty duplicate subscribers list if it exists.
+    var dup_list = Y.one('#subscribers-from-duplicates');
+    if (Y.Lang.isValue(dup_list) &&
+        !Y.Lang.isValue(dup_list.one('div'))) {
+        var parent = dup_list.get('parentNode');
+        parent.removeChild(dup_list);
+    }
+}
+
+/*
+ * Set the class on subscription link's parentNode.
+ *
+ * This is used to reset the class used by the
+ * click handler to know which link was clicked.
+ *
+ * @method set_subscription_link_parent_class
+ * @param subscription_link {Node} The sub/unsub link.
+ * @param subscribed {Boolean} The sub/unsub'ed flag for the class.
+ * @param dupe_subscribed {Boolean} The sub/unsub'ed flag for dupes
+ *                                  on the class.
+ */
+function set_subscription_link_parent_class(
+    user_link, subscribed, dupe_subscribed) {
+
+    var parent = user_link.get('parentNode');
+    if (subscribed) {
+        parent.removeClass('subscribed-false');
+        parent.addClass('subscribed-true');
+    } else {
+        parent.removeClass('subscribed-true');
+        parent.addClass('subscribed-false');
+    }
+
+    if (dupe_subscribed) {
+        parent.removeClass('dup-subscribed-false');
+        parent.addClass('dup-subscribed-true');
+    } else {
+        parent.removeClass('dup-subscribed-true');
+        parent.addClass('dup-subscribed-false');
+    }
+}
+
+
+/*
+ * Handle the advanced_subscription_overlay's form submissions.
+ *
+ * @method handle_advanced_subscription_overlay
+ * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
+ * @param form_data {Object} The data from the submitted form.
+ */
+function handle_advanced_subscription_overlay(subscription, form_data) {
+    var link = subscription.get('link');
+    var link_parent = link.get('parentNode');
+    if (link_parent.hasClass('subscribed-false') &&
+        link_parent.hasClass('dup-subscribed-false')) {
+        // The user isn't subscribed, so subscribe them.
+        subscription.set(
+            'bug_notification_level',
+            form_data['field.bug_notification_level']);
+        subscribe_current_user(subscription);
+    } else if (
+        form_data['field.subscription'] == 'update-subscription') {
+        // The user is already subscribed and wants to update their
+        // subscription.
+        setup_client_and_bug();
+        var person_name = subscription.get('person').get('name');
+        var subscription_url =
+            lp_bug_entry.get('self_link') + '/+subscription/' +
+            person_name;
+        config = {
+            on: {
+                success: function(lp_subscription) {
+                    subscription.enable_spinner('Updating subscription...');
+                    lp_subscription.set(
+                        'bug_notification_level',
+                        form_data['field.bug_notification_level'][0])
+                    save_config = {
+                        on: {
+                            success: function(e) {
+                                subscription.disable_spinner(
+                                    'Edit subscription');
+                                var anim = Y.lazr.anim.green_flash({
+                                    node: link_parent
+                                    });
+                                anim.run();
+                            },
+                            failure: function(e) {
+                                subscription.disable_spinner(
+                                    'Edit subscription');
+                                var anim = Y.lazr.anim.red_flash({
+                                    node: link_parent
+                                    });
+                                anim.run();
+                            }
+                        }
+                    }
+                    lp_subscription.lp_save(save_config);
+                }
+            }
+        }
+        lp_client.get(subscription_url, config);
+    } else {
+        // The user is already subscribed and wants to unsubscribe.
+        unsubscribe_current_user(subscription);
+    }
+}
+
+/*
+ * Subscribe a person or team other than the current user.
+ * This is a callback for the subscribe someone else picker.
+ *
+ * @method subscribe_someone_else
+ * @result {Object} The object representing a person returned by the API.
+ */
+function subscribe_someone_else(result, subscription) {
+    var person = new Y.lp.bugs.subscriber.Subscriber({
+        uri: result.api_uri,
+        display_name: result.title,
+        subscriber_ids: subscriber_ids
+    });
+    subscription.set('person', person);
+
+    var error_handler = new LP.client.ErrorHandler();
+    error_handler.showError = function(error_msg) {
+        Y.lp.app.errors.display_error(
+           Y.one('.menu-link-addsubscriber'), error_msg);
+    };
+
+    if (subscription.is_already_subscribed()) {
+        error_handler.showError(
+             subscription.get('person').get('full_display_name') +
+             ' has already been subscribed');
+    } else {
+        check_can_be_unsubscribed(subscription);
+    }
+}
+
+/*
+ * Check if the current user can unsubscribe the person
+ * being subscribed.
+ *
+ * This must be done in JavaScript, since the subscription
+ * hasn't completed yet, and so, can_be_unsubscribed_by_user
+ * cannot be used.
+ *
+ * @method check_can_be_unsubscribed
+ * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
+ */
+function check_can_be_unsubscribed(subscription) {
+    var error_handler = new LP.client.ErrorHandler();
+    error_handler.showError = function (error_msg) {
+        Y.lp.app.errors.display_error(
+           Y.one('.menu-link-addsubscriber'), error_msg);
+    };
+
+    var config = {
+        on: {
+            success: function(result) {
+                var is_team = result.get('is_team');
+                subscription.set('is_team', is_team);
+                var final_config = {
+                    on: {
+                        success: function(result) {
+                            var team_member = false;
+                            for (var i=0; i<result.entries.length; i++) {
+                                 if (result.entries[i].member_link ==
+                                    LP.client.get_absolute_uri(
+                                        subscription.get(
+                                            'subscriber').get('uri'))) {
+                                    team_member = true;
+                                }
+                            }
+
+                            if (team_member) {
+                                subscription.set('can_be_unsubscribed', true);
+                                add_temp_user_name(subscription);
+                            } else {
+                                subscription.set(
+                                   'can_be_unsubscribed', false);
+                                add_temp_user_name(subscription);
+                            }
+                        },
+
+                        failure: error_handler.getFailureHandler()
+                    }
+                };
+
+                if (is_team) {
+                    // Get a list of members to see if current user
+                    // is a team member.
+                    var members = result.get(
+                       'members_details_collection_link');
+                    lp_client.get(members, final_config);
+                } else {
+                    subscription.set('can_be_unsubscribed', false);
+                    add_temp_user_name(subscription);
+                }
+            },
+
+            failure: error_handler.getFailureHandler()
+        }
+    };
+    lp_client.get(LP.client.get_absolute_uri(
+        subscription.get('person').get('escaped_uri')), config);
+}
+
+/*
+ * Add a grayed out, temporary user name when subscribing
+ * someone else.
+ *
+ * @method add_temp_user_name
+ * @param subscription_link {Node} The sub/unsub link.
+ */
+function add_temp_user_name(subscription) {
+    // Be paranoid about display_name, since timeouts or other errors
+    // could mean display_name wasn't set on initialization.
+    if (subscription.get('person').get('display_name') === '') {
+        subscription.get('person').set_display_name();
+    }
+    var display_name = subscription.get('person').get('display_name');
+    var img_src;
+    if (subscription.is_team()) {
+        img_src = '/@@/teamgray';
+    } else {
+        img_src = '/@@/persongray';
+    }
+
+    // The <span>...</span> below must *not* be <span/>. On FF (maybe
+    // others, but at least on FF 3.0.11) will then not notice any
+    // following sibling nodes, like the spinner image.
+    var link_node = Y.Node.create([
+        '<div id="temp-username"> ',
+        '  <img alt="" width="14" height="14" />',
+        '  <span>Other Display Name</span>',
+        '  <img id="temp-name-spinner" src="/@@/spinner" alt="" ',
+        '       style="position:absolute;right:8px" /></div>'].join(''));
+    link_node.one('img').set('src', img_src);
+    link_node.replaceChild(
+        document.createTextNode(display_name),
+        link_node.one('span'));
+
+    var subscribers = Y.one('#subscribers-links');
+    var next = get_next_subscriber_node(subscription);
+    if (next) {
+        subscribers.insertBefore(link_node, next);
+    } else {
+        // Handle the case of the displayed "None".
+        var none_subscribers = Y.one('#none-subscribers');
+        if (none_subscribers) {
+            var none_parent = none_subscribers.get('parentNode');
+            none_parent.removeChild(none_subscribers);
+        }
+        subscribers.appendChild(link_node);
+    }
+
+    // Fire a custom event to know it's safe to begin
+    // any actual subscribing work.
+    namespace.portlet.fire('bugs:nameloaded', subscription);
+}
+
+}, "0.1", {"requires": ["base", "oop", "node", "event", "io-base",
+                        "json-parse", "substitute", "widget-position-ext",
+                        "lazr.formoverlay", "lazr.anim", "lazr.base",
+                        "lazr.overlay", "lazr.choiceedit", "lp.app.picker",
+                        "lp.client.plugins", "lp.bugs.subscriber",
+                        "lp.app.errors"]});

=== modified file 'lib/lp/bugs/templates/bug-portlet-subscribers.pt'
--- lib/lp/bugs/templates/bug-portlet-subscribers.pt	2010-06-15 13:51:55 +0000
+++ lib/lp/bugs/templates/bug-portlet-subscribers.pt	2011-02-15 14:49:55 +0000
@@ -25,7 +25,7 @@
     <img src="/@@/spinner" />
   </div>
   <script type="text/javascript">
-    LPS.use('io-base', 'node', 'lp.bugs.bugtask_index', function(Y) {
+    LPS.use('io-base', 'node', 'lp.bugs.bugtask_index.portlet', function(Y) {
         // Must be done inline here to ensure the load event fires.
         // This is a work around for a YUI3 issue with event handling.
         var subscription_link = Y.one('.menu-link-subscription');
@@ -37,8 +37,8 @@
         }
 
         Y.on('domready', function() {
-            if (Y.lp.bugs.bugtask_index) {
-                Y.lp.bugs.bugtask_index.load_subscribers_portlet(
+            if (Y.lp.bugs.bugtask_index.portlets) {
+                Y.lp.bugs.bugtask_index.portlets.load_subscribers_portlet(
                     subscription_link, subscription_link_handler);
             }
         });