launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

Данило Шеган has proposed merging lp:~danilo/launchpad/db-bug-718809 into lp:launchpad/db-devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #718809 New users should default to not receiving email for their own actions
  https://bugs.launchpad.net/bugs/718809

For more details, see:
https://code.launchpad.net/~danilo/launchpad/db-bug-718809/+merge/49952

= Bug 718809: DB patch =

This is just a DB patch to finish off https://code.launchpad.net/~danilo/launchpad/bug-718809/+merge/49950

== Implementation notes ==

Sample data in current.sql seems to be out of date, but it's definitely not due to my branch, and I'd only fix that right before the landing.

Sample data in current-dev.sql might be out of date due to me playing around, but I don't want to wait for 'make schema' to confirm, especially since the test sampledata should not be affected by that.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  database/schema/patch-2208-99-0.sql


== Schema ==

database/sampledata/current.sql
    database/sampledata/lintdata.sql differs from database/sampledata/current.sql.
    Patches to the schema, or manual edits to database/sampledata/current.sql
    do not match the dump of the launchpad_ftest_template database.
    If database/sampledata/lintdata.sql is correct, copy it to
    database/sampledata/current.sql.
    Otherwise update database/sampledata/current.sql and run:
        make schema
        make newsampledata
        cd database/sampledata
        cp newsampledata.sql database/sampledata/current.sql
    Run make schema again to update the test/dev database.

database/sampledata/current.sql
    database/sampledata/lintdata-dev.sql differs from database/sampledata/current-dev.sql.
    Patches to the schema, or manual edits to database/sampledata/current-dev.sql
    do not match the dump of the launchpad_dev_template database.
    If database/sampledata/lintdata-dev.sql is correct, copy it to
    database/sampledata/current-dev.sql.
    Otherwise update database/sampledata/current-dev.sql and run:
        make schema
        make newsampledata
        cd database/sampledata
        cp newsampledata-dev.sql database/sampledata/current-dev.sql
    Run make schema again to update the test/dev database.
-- 
https://code.launchpad.net/~danilo/launchpad/db-bug-718809/+merge/49952
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/db-bug-718809 into lp:launchpad/db-devel.

=== added file 'database/schema/patch-2208-99-0.sql'
--- database/schema/patch-2208-99-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2208-99-0.sql	2011-02-16 11:34:52 +0000
@@ -0,0 +1,6 @@
+SET client_min_messages=ERROR;
+
+ALTER TABLE PersonSettings
+  ALTER COLUMN selfgenerated_bugnotifications SET DEFAULT FALSE;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2208, 99, 0);