← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~jcsackett/launchpad/bugs-in-deactivated-pillars into lp:launchpad

 

> In https://bugs.launchpad.net/launchpad/+bug/421901/comments/14 we had a more
> complex join - we enforce the active flag in the join, which reduces the data
> brought into intermediary tables. Was there a particular reason for eliding
> that aspect here?

As I mentioned on IRC, the only reason was distraction in assembling the python code. The proper join has been pushed up.
-- 
https://code.launchpad.net/~jcsackett/launchpad/bugs-in-deactivated-pillars/+merge/50000
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/bugs-in-deactivated-pillars into lp:launchpad.



References