launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

The proposal to merge lp:~wallyworld/launchpad/add-link-to-noneformatter into lp:launchpad has been updated.

Description changed to:

See bug 714519. The tales link formatter should be able to render objects with value None.

== Implementation ==

Enhance NoneFormatter to support traversing the "link" attribute of None objects. Returns "None".
Enhance format_link() helper to handle None objects, allowing a specified "None" value to be returned. Default is "None".

== Tests ==

There were no tests for NoneFormatter so I added these.
bin/test -vvt TestNoneFormatterAPI

== Lint ==

Linting changed files:
  lib/lp/app/browser/tales.py
  lib/lp/app/browser/webservice.py
  lib/lp/app/browser/tests/test_noneformatter.py
  lib/lp/app/browser/tests/test_webservice.py
  lib/lp/code/browser/sourcepackagerecipe.py

./lib/lp/app/browser/tests/test_webservice.py
      37: E501 line too long (80 characters)
      37: Line exceeds 78 characters.

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/add-link-to-noneformatter/+merge/50088
-- 
https://code.launchpad.net/~wallyworld/launchpad/add-link-to-noneformatter/+merge/50088
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/add-link-to-noneformatter into lp:launchpad.