launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/db-recipe-description into lp:launchpad/db-devel.

Requested reviews:
  Robert Collins (lifeless): db
  Stuart Bishop (stub): db
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/db-recipe-description/+merge/50697

Drop the NOT NULL constraint on SourcePackageRecipe.description, and update the interface and model to reflect this.
-- 
https://code.launchpad.net/~stevenk/launchpad/db-recipe-description/+merge/50697
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/db-recipe-description into lp:launchpad/db-devel.

=== added file 'database/schema/patch-2208-99-0.sql'
--- database/schema/patch-2208-99-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2208-99-0.sql	2011-02-22 05:38:59 +0000
@@ -0,0 +1,8 @@
+-- Copyright 2011 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+SET client_min_messages=ERROR;
+
+ALTER TABLE SourcePackageRecipe
+    ALTER COLUMN description DROP NOT NULL;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2208, 99, 0);

=== modified file 'lib/lp/code/interfaces/sourcepackagerecipe.py'
--- lib/lp/code/interfaces/sourcepackagerecipe.py	2011-02-18 02:39:47 +0000
+++ lib/lp/code/interfaces/sourcepackagerecipe.py	2011-02-22 05:38:59 +0000
@@ -191,7 +191,7 @@
             description=_("The name of this recipe.")))
 
     description = exported(Description(
-        title=_('Description'), required=True,
+        title=_('Description'),
         description=_('A short description of the recipe.')))
 
     date_last_modified = exported(

=== modified file 'lib/lp/code/model/sourcepackagerecipe.py'
--- lib/lp/code/model/sourcepackagerecipe.py	2011-02-18 02:39:47 +0000
+++ lib/lp/code/model/sourcepackagerecipe.py	2011-02-22 05:38:59 +0000
@@ -147,7 +147,7 @@
         return self.sourcepackagename.name
 
     name = Unicode(allow_none=True)
-    description = Unicode(allow_none=False)
+    description = Unicode(allow_none=True)
 
     @property
     def _recipe_data(self):