launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #02752
[Merge] lp:~sinzui/launchpad/fixed-font-sizes-0 into lp:launchpad
Curtis Hovey has proposed merging lp:~sinzui/launchpad/fixed-font-sizes-0 into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
#523189 font size smaller than default creates accessibility and usability difficulties
https://bugs.launchpad.net/bugs/523189
For more details, see:
https://code.launchpad.net/~sinzui/launchpad/fixed-font-sizes-0/+merge/51039
Remove unneeded discreet and lesser classes from text.
This is a preparation branch needed to land the update to
Launchpad font-sizes.
Launchpad bug: https://bugs.launchpad.net/bugs/723975
Pre-implementation: no one
Test command: ./bin/test -vv \
-t question-obfuscation -t questions-index -t xx-front-page-bug-lists
Several pages are using discreet or lesser to make text smaller. This may have
made sense in the past, but not in UI 3.0. In most cases, the classes can be
removed to fix the issue. The two most visible cases (the bug and answers
front pages) should be switched from a table to a list of items. The bug icons
are not displayed to webkit-based browsers because of a bad hack. Switching to
UI 3.0 conventions will fix this.
--------------------------------------------------------------------
RULES
* Remove the discreet and lesser classes that can be normal.
* the specwork load message
* cve listings
* link to the original bug description
* request a merge page
* Project group listings
* distroarchseries page.
* Update the bugs and answers front pages to use a <ul> to list
the items. Use the standard formatter to ensure icons appear.
* Remove the information about who reported it or when it was
updated. This is not shown on the project pages so it is not
need on the root pages.
QA
* Visit https://bugs.launchpad.net/
* Verify the icons appear in a webkit-based browser with proper
spacing between the icon and the title
* Verify the listing us a ul in the standard font size.
* Visit https://answers.launchpad.net/
* Verify the icons appear in a webkit-based browser with proper
spacing between the icon and the title
* Verify the listing us a ul in the standard font size.
* Visit https://blueprints.launchpad.net/~gdp-developers/+specworkload
* Verify the explanation of the page is normal size
* Visit https://bugs.launchpad.net/launchpad/+bug/80895
* Verify that the link to the original description is normal size
* Visit https://bugs.launchpad.net/bugs/cve/2010-4158/+listing-detailed
* Verify that the description is normal size
* Visit https://launchpad.net/people/+requestmerge
* Verify the last paragraph is normal size.
* Visit https://launchpad.net/ubuntu/maverick/i386
* Verify the line that lists the number of pages is normaal size.
LINT
lib/lp/answers/stories/question-obfuscation.txt
lib/lp/answers/stories/questions-index.txt
lib/lp/answers/templates/question-add.pt
lib/lp/answers/templates/question-listing-detailed.pt
lib/lp/answers/templates/questions-index.pt
lib/lp/blueprints/templates/person-specworkload.pt
lib/lp/bugs/stories/bugs/xx-front-page-bug-lists.txt
lib/lp/bugs/templates/bug-listing-detailed.pt
lib/lp/bugs/templates/bugtask-index.pt
lib/lp/bugs/templates/cve-listing-detailed.pt
lib/lp/bugs/templates/malone-index.pt
lib/lp/registry/templates/people-requestmerge.pt
lib/lp/registry/templates/project-listing-detailed.pt
lib/lp/scripts/utilities/pageperformancereport.py
lib/lp/soyuz/templates/distroarchseries-index.pt
IMPLEMENTATION
Updated answers front page to use a normal size list as is done
on the project overview page.
lib/lp/answers/stories/question-obfuscation.txt
lib/lp/answers/stories/questions-index.txt
lib/lp/answers/templates/question-add.pt
lib/lp/answers/templates/question-listing-detailed.pt
lib/lp/answers/templates/questions-index.pt
Updated bugs front page to use a normal size list as is done
on the project overview page.
lib/lp/bugs/stories/bugs/xx-front-page-bug-lists.txt
lib/lp/bugs/templates/bug-listing-detailed.pt
lib/lp/bugs/templates/malone-index.pt
Removed unneeded small fonts.
lib/lp/bugs/templates/bugtask-index.pt
lib/lp/bugs/templates/cve-listing-detailed.pt
lib/lp/blueprints/templates/person-specworkload.pt
lib/lp/registry/templates/people-requestmerge.pt
lib/lp/registry/templates/project-listing-detailed.pt
lib/lp/scripts/utilities/pageperformancereport.py
lib/lp/soyuz/templates/distroarchseries-index.pt
--
https://code.launchpad.net/~sinzui/launchpad/fixed-font-sizes-0/+merge/51039
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~sinzui/launchpad/fixed-font-sizes-0 into lp:launchpad.
=== modified file 'lib/lp/answers/stories/question-obfuscation.txt'
--- lib/lp/answers/stories/question-obfuscation.txt 2009-11-17 02:33:27 +0000
+++ lib/lp/answers/stories/question-obfuscation.txt 2011-02-23 23:39:10 +0000
@@ -15,8 +15,8 @@
>>> user_browser.open('http://answers.launchpad.dev/')
>>> question_portlet = find_tag_by_id(
... user_browser.contents, 'latest-questions-solved')
- >>> for tr in question_portlet.findAll('tr'):
- ... tr['title']
+ >>> for li in question_portlet.findAll('li'):
+ ... li['title']
u'I am not able to ... if i click on a mailto:user@xxxxxxxxxx link ...'
He can also see the email address in the tooltip for the question in the
@@ -30,8 +30,8 @@
>>> question_listing = find_tag_by_id(
... user_browser.contents, 'question-listing')
- >>> for tr in question_listing.tbody.findAll('tr'):
- ... tr['title']
+ >>> for li in question_portlet.findAll('li'):
+ ... li['title']
u'I am not able to ... if i click on a mailto:user@xxxxxxxxxx link ...'
>>> user_browser.getLink('mailto: problem in webpage').click()
@@ -81,8 +81,8 @@
>>> user_browser.open('http://answers.launchpad.dev/')
>>> question_portlet = find_tag_by_id(
... user_browser.contents, 'latest-questions-asked')
- >>> for tr in question_portlet.findAll('tr'):
- ... tr['title']
+ >>> for li in question_portlet.findAll('li'):
+ ... li['title']
u'The clicking mailto:user@xxxxxxxxxx crashes the browser.'
...
@@ -98,15 +98,15 @@
>>> question_portlet = find_tag_by_id(
... anon_browser.contents, 'latest-questions-solved')
- >>> for tr in question_portlet.findAll('tr'):
- ... tr['title']
+ >>> for li in question_portlet.findAll('li'):
+ ... li['title']
u'I am not able to ... if i click on a
mailto:<email address hidden> ...'
>>> question_portlet = find_tag_by_id(
... anon_browser.contents, 'latest-questions-asked')
- >>> for tr in question_portlet.findAll('tr'):
- ... tr['title']
+ >>> for li in question_portlet.findAll('li'):
+ ... li['title']
u'The clicking mailto:<email address hidden> crashes the browser.'
...
=== modified file 'lib/lp/answers/stories/questions-index.txt'
--- lib/lp/answers/stories/questions-index.txt 2010-12-18 00:45:26 +0000
+++ lib/lp/answers/stories/questions-index.txt 2011-02-23 23:39:10 +0000
@@ -26,13 +26,13 @@
... anon_browser.contents, 'latest-questions-asked')
>>> print latest_questions_asked.first('h2').renderContents()
Latest questions asked
- >>> for row in latest_questions_asked.fetch('tr', 'lesser'):
+ >>> for row in latest_questions_asked.fetch('li'):
... row.first('a').renderContents()
- 'Problemas de Impress\xc3\xa3o no Firefox'
- 'Problema al recompilar kernel con soporte smp (doble-n\xc3\xbacleo)'
- 'Continue playing after shutdown'
- 'Installation failed'
- 'Firefox loses focus and gets stuck'
+ '...: Problemas de Impress\xc3\xa3o no Firefox'
+ '...: Problema al recompilar kernel con soporte smp (doble-n\xc3\xbacleo)'
+ '...: Continue playing after shutdown'
+ '...: Installation failed'
+ '...: Firefox loses focus and gets stuck'
As well as the 5 latest questions solved:
@@ -40,9 +40,9 @@
... anon_browser.contents, 'latest-questions-solved')
>>> print latest_questions_solved.first('h2').renderContents()
Latest questions solved
- >>> for row in latest_questions_solved.fetch('tr', 'lesser'):
+ >>> for row in latest_questions_solved.fetch('li'):
... row.first('a').renderContents()
- 'mailto: problem in webpage'
+ '...: mailto: problem in webpage'
The application footer also contains a sample of stats for the application:
=== modified file 'lib/lp/answers/templates/question-add.pt'
--- lib/lp/answers/templates/question-add.pt 2009-08-19 16:48:37 +0000
+++ lib/lp/answers/templates/question-add.pt 2011-02-23 23:39:10 +0000
@@ -28,12 +28,10 @@
<tal:similar-questions condition="view/similar_questions">
<p>These other questions seem similar to yours. You may want to take a look at them.</p>
- <table id="similar-questions">
- <tbody>
- <tr tal:repeat="question view/similar_questions"
- tal:replace="structure question/@@+listing-detailed" />
- </tbody>
- </table>
+ <ul id="similar-questions">
+ <ul tal:repeat="question view/similar_questions"
+ tal:replace="structure question/@@+listing-detailed" />
+ </ul>
</tal:similar-questions>
<tal:similar-items condition="view/has_similar_items">
=== modified file 'lib/lp/answers/templates/question-listing-detailed.pt'
--- lib/lp/answers/templates/question-listing-detailed.pt 2010-12-16 20:40:07 +0000
+++ lib/lp/answers/templates/question-listing-detailed.pt 2011-02-23 23:39:10 +0000
@@ -4,40 +4,17 @@
xmlns:i18n="http://xml.zope.org/namespaces/i18n";>
<tal:description
define="global description context/description/fmt:obfuscate-email/fmt:shorten/320" />
-<tr class="lesser"
- tal:attributes="title description">
- <td class="icon left">
- <img alt="" src="/@@/question" />
- </td>
- <td>
- <div>
- <a
- tal:attributes="
- href context/fmt:url;
- class string:${context/status/title}
- "
- tal:content="context/title"
- />
+<li tal:attributes="title description">
+ <a tal:replace="structure context/fmt:link" />
(<span tal:replace="context/status/title">Approved</span>)
- </div>
- <div>
- posted
+ <br />
+ <span class="registered">posted
<span
tal:attributes="title context/datecreated/fmt:datetime"
tal:replace="context/datecreated/fmt:displaydate">2005-10-05</span>
- by
- <a tal:replace="structure context/owner/fmt:link"
- >Foo Bar</a><tal:assignee condition="context/assignee">,
- assigned to
- <a tal:replace="structure context/assignee/fmt:link"
- >Foo Bar</a></tal:assignee><tal:answerer condition="context/answerer">,
- answered by
- <a tal:replace="structure context/answerer/fmt:link">Foo Bar</a>
- </tal:answerer>
in
<span tal:replace="context/target/title">SmegConf</span>
- </div>
- </td>
-</tr>
+ </span>
+</li>
</tal:root>
=== modified file 'lib/lp/answers/templates/questions-index.pt'
--- lib/lp/answers/templates/questions-index.pt 2010-10-10 21:54:16 +0000
+++ lib/lp/answers/templates/questions-index.pt 2011-02-23 23:39:10 +0000
@@ -90,22 +90,22 @@
<div id="latest-questions-asked" class="three column middle">
<h2>Latest questions asked</h2>
- <table>
+ <ul>
<tal:question
repeat="question view/latest_questions_asked"
content="structure question/@@+listing-detailed"
/>
- </table>
+ </ul>
</div>
<div id="latest-questions-solved" class="three column right">
<h2>Latest questions solved</h2>
- <table>
+ <ul>
<tal:question
repeat="question view/latest_questions_solved"
content="structure question/@@+listing-detailed"
/>
- </table>
+ </ul>
</div>
</div>
=== modified file 'lib/lp/blueprints/templates/person-specworkload.pt'
--- lib/lp/blueprints/templates/person-specworkload.pt 2010-04-22 13:28:41 +0000
+++ lib/lp/blueprints/templates/person-specworkload.pt 2011-02-23 23:39:10 +0000
@@ -31,7 +31,7 @@
<h2>Team member workload</h2>
- <p class="discreet">
+ <p>
The following people are all members of the
<span tal:replace="context/displayname">Admins</span> team in
Launchpad. We list each of their specification workloads so that you
=== modified file 'lib/lp/bugs/stories/bugs/xx-front-page-bug-lists.txt'
--- lib/lp/bugs/stories/bugs/xx-front-page-bug-lists.txt 2010-10-19 18:44:31 +0000
+++ lib/lp/bugs/stories/bugs/xx-front-page-bug-lists.txt 2011-02-23 23:39:10 +0000
@@ -35,59 +35,37 @@
>>> anon_browser.open('http://bugs.launchpad.dev/')
>>> reported_bugs = find_tag_by_id(anon_browser.contents, 'reported-bugs')
-These bugs use a color-coded icon, via a sprite class, as an
-indication of the importance assigned to the bug.
-
- >>> high_bugs = find_tags_by_class(str(reported_bugs), 'sprite bug-high')
- >>> print high_bugs[0]
- <span class="sprite bug-high">
- </span>
-
The list of recently reported bugs contains up to the last 5 bugs reported
across Launchpad. The text for each bug contains links to the bug itself,
to the bug target and to the bug reporter's page.
>>> def print_bugs_links(bug_row):
- ... icon_td, summary_td, = bug_row('td')
... print "%s: %s" % (
- ... summary_td.b.a.renderContents().strip(),
- ... summary_td.a.renderContents())
- ... bug_link, bug_target_link, bug_reporter_link = summary_td('a')
- ... print bug_link['href']
- ... print bug_target_link['href']
- ... print bug_reporter_link['href']
- >>> for tr in reported_bugs('tr'):
- ... print_bugs_links(tr)
- Bigfixer:
- Summary for new bug ...
- <BLANKLINE>
- /bugs/...
- /bigfixer
- http://launchpad.dev/~person-name...
- Bigfixer:
- Summary for new bug ...
- <BLANKLINE>
- /bugs/...
- /bigfixer
- http://launchpad.dev/~person-name...
- Bigfixer:
- Summary for new bug ...
- <BLANKLINE>
- /bugs/...
- /bigfixer
- http://launchpad.dev/~person-name...
- Bigfixer:
- Summary for new bug ...
- <BLANKLINE>
- /bugs/...
- /bigfixer
- http://launchpad.dev/~person-name...
- Bigfixer:
- Summary for new bug ...
- <BLANKLINE>
- /bugs/...
- /bigfixer
- http://launchpad.dev/~person-name...
+ ... bug_row.span.a.renderContents().strip(),
+ ... bug_row.a.renderContents())
+ ... print bug_row.a['href']
+ ... print bug_row.span.a['href']
+ >>> for li in reported_bugs('li'):
+ ... print_bugs_links(li)
+ Bigfixer: Bug #...: Summary for new bug ...
+ /bugs/...
+ /bigfixer
+ Bigfixer:
+ Bug #...: Summary for new bug ...
+ /bugs/...
+ /bigfixer
+ Bigfixer:
+ Bug #...: Summary for new bug ...
+ /bugs/...
+ /bigfixer
+ Bigfixer:
+ Bug #...: Summary for new bug ...
+ /bugs/...
+ /bigfixer
+ Bigfixer:
+ Bug #...: Summary for new bug ...
+ /bugs/...
+ /bigfixer
Fixed bugs
@@ -97,46 +75,28 @@
>>> fixed_bugs = find_tag_by_id(anon_browser.contents, 'fixed-bugs')
-These bugs also use a color-coded icon as an indication of the
-importance assigned to the bug.
-
- >>> high_bugs = find_tags_by_class(str(fixed_bugs), 'sprite bug-high')
- >>> print high_bugs[0]
- <span class="sprite bug-high">
- </span>
-
The list of recently fixed bugs contains up to the last 5 bugs fixed
across Launchpad.
- >>> for tr in fixed_bugs('tr'):
- ... print_bugs_links(tr)
- Bigfixer:
- Summary for new bug 10
- <BLANKLINE>
- /bugs/...
- /bigfixer
- http://launchpad.dev/~person-name...
- Bigfixer:
- Summary for new bug 9
- <BLANKLINE>
- /bugs/...
- /bigfixer
- http://launchpad.dev/~person-name...
- Bigfixer:
- Summary for new bug 8
- <BLANKLINE>
- /bugs/...
- /bigfixer
- http://launchpad.dev/~person-name...
- Bigfixer:
- Summary for new bug 7
- <BLANKLINE>
- /bugs/...
- /bigfixer
- http://launchpad.dev/~person-name...
- Bigfixer:
- Summary for new bug 6
- <BLANKLINE>
- /bugs/...
- /bigfixer
- http://launchpad.dev/~person-name...
+ >>> for li in fixed_bugs('li'):
+ ... print_bugs_links(li)
+ Bigfixer:
+ Bug #...: Summary for new bug 10
+ /bugs/...
+ /bigfixer
+ Bigfixer:
+ Bug #...: Summary for new bug 9
+ /bugs/...
+ /bigfixer
+ Bigfixer:
+ Bug #...: Summary for new bug 8
+ /bugs/...
+ /bigfixer
+ Bigfixer:
+ Bug #...: Summary for new bug 7
+ /bugs/...
+ /bigfixer
+ Bigfixer:
+ Bug #...: Summary for new bug 6
+ /bugs/...
+ /bigfixer
=== modified file 'lib/lp/bugs/templates/bug-listing-detailed.pt'
--- lib/lp/bugs/templates/bug-listing-detailed.pt 2010-09-13 13:19:19 +0000
+++ lib/lp/bugs/templates/bug-listing-detailed.pt 2011-02-23 23:39:10 +0000
@@ -1,27 +1,13 @@
-<tr xmlns:tal="http://xml.zope.org/namespaces/tal";>
- <td class="icon left">
- <span tal:attributes="class context/default_bugtask/image:sprite_css" />
- </td>
- <td>
- <div>
- #<span tal:replace="context/id">4</span>
- <a tal:attributes="href context/fmt:url">
- <span tal:replace="context/title">Bug Title Here</span>
- </a>
- </div>
- <div class="lesser">
- in
+<li xmlns:tal="http://xml.zope.org/namespaces/tal";>
+ <a tal:replace="structure context/fmt:link" />
+ <br />
+ <span class="registered">in
<tal:per_pillar repeat="pillar context/affected_pillars">
- <b tal:content="structure pillar/fmt:link:bugs" />,
+ <pillar tal:replace="structure pillar/fmt:link:bugs" />,
</tal:per_pillar>
reported
<span
tal:attributes="title context/datecreated/fmt:datetime"
tal:content="context/datecreated/fmt:displaydate">2005-10-05</span>
- by
- <a
- tal:attributes="href context/owner/fmt:url"
- tal:content="context/owner/displayname">Foo Bar</a>
- </div>
- </td>
-</tr>
+ </span>
+</li>
=== modified file 'lib/lp/bugs/templates/bugtask-index.pt'
--- lib/lp/bugs/templates/bugtask-index.pt 2011-02-17 01:03:34 +0000
+++ lib/lp/bugs/templates/bugtask-index.pt 2011-02-23 23:39:10 +0000
@@ -120,7 +120,7 @@
<tal:widget replace="structure view/bug_description_html"/>
<div style="margin:-20px 0 20px 5px" class="clearfix">
- <span tal:condition="view/wasDescriptionModified" class="discreet"
+ <span tal:condition="view/wasDescriptionModified"
>See <a href="comments/0">original description</a></span>
</div>
=== modified file 'lib/lp/bugs/templates/cve-listing-detailed.pt'
--- lib/lp/bugs/templates/cve-listing-detailed.pt 2009-07-17 17:59:07 +0000
+++ lib/lp/bugs/templates/cve-listing-detailed.pt 2011-02-23 23:39:10 +0000
@@ -5,7 +5,7 @@
<img src="/@@/cve" />
<a tal:attributes="href context/fmt:url"
tal:content="context/title">CVE Title Here</a>
-<div style="font-size: 80%; margin-left: 25px;">
+<div style=" margin-left: 25px;">
<div tal:content="context/description">
Description Goes Here
</div>
=== modified file 'lib/lp/bugs/templates/malone-index.pt'
--- lib/lp/bugs/templates/malone-index.pt 2010-10-10 21:54:16 +0000
+++ lib/lp/bugs/templates/malone-index.pt 2011-02-23 23:39:10 +0000
@@ -69,23 +69,19 @@
<div class="first yui-u">
<div class="portlet">
<h2>Recently reported</h2>
- <table id="reported-bugs">
- <tbody>
- <tr tal:repeat="bug context/latest_bugs"
- tal:replace="structure bug/@@+listing-detailed" />
- </tbody>
- </table>
+ <ul id="reported-bugs">
+ <li tal:repeat="bug context/latest_bugs"
+ tal:replace="structure bug/@@+listing-detailed" />
+ </ul>
</div>
</div>
<div class="yui-u">
<div class="portlet">
<h2>Recently fixed</h2>
- <table id="fixed-bugs">
- <tbody>
- <tr tal:repeat="fixed_bug view/getMostRecentlyFixedBugs"
- tal:replace="structure fixed_bug/@@+listing-detailed" />
- </tbody>
- </table>
+ <ul id="fixed-bugs">
+ <li tal:repeat="fixed_bug view/getMostRecentlyFixedBugs"
+ tal:replace="structure fixed_bug/@@+listing-detailed" />
+ </ul>
</div>
</div>
</div>
=== modified file 'lib/lp/registry/templates/people-requestmerge.pt'
--- lib/lp/registry/templates/people-requestmerge.pt 2009-11-20 05:47:36 +0000
+++ lib/lp/registry/templates/people-requestmerge.pt 2011-02-23 23:39:10 +0000
@@ -26,7 +26,7 @@
account's e-mail address, it will be assigned to you, along with
everything else owned by it.
</p>
- <p class="discreet">
+ <p>
Note: If you no longer have access to the duplicated account's
email address, you may place a
<a href="/launchpad/+addquestion">support request</a>.
=== modified file 'lib/lp/registry/templates/project-listing-detailed.pt'
--- lib/lp/registry/templates/project-listing-detailed.pt 2010-08-13 21:30:24 +0000
+++ lib/lp/registry/templates/project-listing-detailed.pt 2011-02-23 23:39:10 +0000
@@ -9,9 +9,8 @@
(<a tal:attributes="href context/fmt:url/+review">Review</a>)
</tal:review>
-<div style="font-size: 80%; margin-left: 25px;">
- <div class="discreet"
- tal:content="context/summary" tal:condition="context/summary">
+<div style="margin-left: 25px;">
+ <div tal:content="context/summary" tal:condition="context/summary">
Summary Goes Here
</div>
</div>
=== modified file 'lib/lp/scripts/utilities/pageperformancereport.py'
--- lib/lp/scripts/utilities/pageperformancereport.py 2010-12-02 16:13:51 +0000
+++ lib/lp/scripts/utilities/pageperformancereport.py 2011-02-23 23:39:10 +0000
@@ -856,7 +856,7 @@
<script language="javascript" type="text/javascript"
src="http://people.canonical.com/~stub/sorttable.js";></script>
<style type="text/css">
- h3 { font-weight: normal; font-size: 100%%; }
+ h3 { font-weight: normal; font-size: 1em; }
thead th { padding-left: 1em; padding-right: 1em; }
.category-title { text-align: right; padding-right: 2em; }
.regexp { font-size: x-small; font-weight: normal; }
=== modified file 'lib/lp/soyuz/templates/distroarchseries-index.pt'
--- lib/lp/soyuz/templates/distroarchseries-index.pt 2009-08-21 19:45:35 +0000
+++ lib/lp/soyuz/templates/distroarchseries-index.pt 2011-02-23 23:39:10 +0000
@@ -30,7 +30,7 @@
<div class="top-portlet">
<h2>Search binary packages</h2>
- <p class="discreet">
+ <p>
This archive contains
<strong class="registry-stat" tal:content="context/package_count">bazillions of</strong> software packages.
</p>
