launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

I've enhanced what's there to hopefully fix the remaining issues. 

1. Display of already pending build message vs "real" errors

Pending build message:

ajax: http://people.canonical.com/~ianb/request-build-some-pending1.png

html: http://people.canonical.com/~ianb/request-build-partial-success-html.png

Real error:

http://people.canonical.com/~ianb/request-build-error2.png

2. Disabling of series selection where builds are already pending (ajax only)

One additional server call is made asynchronously when the request build popup is opened. All the pending builds are retrieved and stored for the life of the popup. Each time the ppa selection is changed, the relevant distro series checkboxes are updated without a new server call being required. If no distro series are selectable, the Request Builds button is removed.

Lots of javascript hacking.


-- 
https://code.launchpad.net/~wallyworld/launchpad/recipe-request-build-partial-success/+merge/50873
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/recipe-request-build-partial-success into lp:launchpad.