launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

Robert Collins has proposed merging lp:~lifeless/launchpad/profile into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lifeless/launchpad/profile/+merge/51495

Stop limiting shown profile results. This makes the overlay much bigger of course, but this is useful precisely because of that: our call graphs are very wide, and no single function (inline cost) is usefully high (e.g. storm calls that are high are the generic worker functions), and the top aggregate time calls are useless because about 10 calls down it explodes very wide. Its actually the middle tier where a lot of time and useful information are hidden. 
-- 
https://code.launchpad.net/~lifeless/launchpad/profile/+merge/51495
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lifeless/launchpad/profile into lp:launchpad.

=== modified file 'lib/lp/services/profile/profile.py'
--- lib/lp/services/profile/profile.py	2011-02-24 19:59:45 +0000
+++ lib/lp/services/profile/profile.py	2011-02-28 07:19:01 +0000
@@ -162,7 +162,7 @@
             for name in ('inlinetime', 'totaltime', 'callcount'):
                 prof_stats.sort(name)
                 f = StringIO.StringIO()
-                prof_stats.pprint(top=25, file=f)
+                prof_stats.pprint(file=f)
                 template_context[name] = f.getvalue()
     if actions and is_html:
         # Hack the new HTML in at the end of the page.