launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/turn-off-parallel-a-f into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  #729003 FTPArchiveHandler shouldn't use --arch
  https://bugs.launchpad.net/bugs/729003

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/turn-off-parallel-a-f/+merge/52185

Deeper QA of the recent parallel apt-ftparchive changes revealed that --arch doesn't actually restrict the work that a-f does, so we ended up just doing the same work several times in parallel.

This branch reverts a-f to a single run, until we can fix it properly next release.
-- 
https://code.launchpad.net/~wgrant/launchpad/turn-off-parallel-a-f/+merge/52185
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/turn-off-parallel-a-f into lp:launchpad.

=== modified file 'lib/lp/archivepublisher/model/ftparchive.py'
--- lib/lp/archivepublisher/model/ftparchive.py	2011-02-25 11:54:05 +0000
+++ lib/lp/archivepublisher/model/ftparchive.py	2011-03-04 11:41:35 +0000
@@ -167,14 +167,12 @@
         spawner = CommandSpawner()
 
         returncodes = {}
-        for arch_tag in self._getArchitectureTags().union(set(["source"])):
-            completion_handler = ReturnCodeReceiver()
-            returncodes[arch_tag] = completion_handler
-            command = base_command + ["--arch", arch_tag]
-            spawner.start(
-                command, stdout_handler=stdout_handler,
-                stderr_handler=stderr_handler,
-                completion_handler=completion_handler)
+        completion_handler = ReturnCodeReceiver()
+        returncodes['all'] = completion_handler
+        spawner.start(
+            base_command, stdout_handler=stdout_handler,
+            stderr_handler=stderr_handler,
+            completion_handler=completion_handler)
 
         spawner.complete()
         stdout_handler.finalize()