launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #02879
[Merge] lp:~gary/launchpad/bug723999-2b into lp:launchpad
Gary Poster has proposed merging lp:~gary/launchpad/bug723999-2b into lp:launchpad with lp:~gary/launchpad/bug723999-2a as a prerequisite.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~gary/launchpad/bug723999-2b/+merge/52429
This branch builds on ~gary/launchpad/bug723999-2a to simply move the tests that had changed in that branch to what I believe is now a more appropriate location, in lib/lp/bugs/tests/test_structuralsubscription.py. That's all I did. make lint was happy without any tweaks.
Thank you
Gary
--
https://code.launchpad.net/~gary/launchpad/bug723999-2b/+merge/52429
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gary/launchpad/bug723999-2b into lp:launchpad.
=== modified file 'lib/lp/bugs/tests/test_structuralsubscription.py'
--- lib/lp/bugs/tests/test_structuralsubscription.py 2011-02-18 15:49:10 +0000
+++ lib/lp/bugs/tests/test_structuralsubscription.py 2011-03-07 16:14:59 +0000
@@ -8,10 +8,20 @@
from storm.store import Store
from zope.security.interfaces import Unauthorized
-from canonical.testing.layers import DatabaseFunctionalLayer
+from canonical.testing.layers import (
+ LaunchpadFunctionalLayer,
+ DatabaseFunctionalLayer,
+ )
+from lp.bugs.enum import BugNotificationLevel
+from lp.bugs.interfaces.bugtask import (
+ BugTaskImportance,
+ BugTaskStatus,
+ )
from lp.bugs.model.bugsubscriptionfilter import BugSubscriptionFilter
+from lp.bugs.model.structuralsubscription import get_structural_subscribers
from lp.testing import (
anonymous_logged_in,
+ login_person,
person_logged_in,
TestCaseWithFactory,
)
@@ -104,3 +114,333 @@
with person_logged_in(self.factory.makePerson()):
self.assertRaises(
Unauthorized, lambda: self.subscription.newBugFilter)
+
+
+class FilteredStructuralSubscriptionTestBase:
+ """Tests for filtered structural subscriptions."""
+
+ layer = LaunchpadFunctionalLayer
+
+ def makeTarget(self):
+ raise NotImplementedError(self.makeTarget)
+
+ def makeBugTask(self):
+ return self.factory.makeBugTask(target=self.target)
+
+ def setUp(self):
+ super(FilteredStructuralSubscriptionTestBase, self).setUp()
+ self.ordinary_subscriber = self.factory.makePerson()
+ login_person(self.ordinary_subscriber)
+ self.target = self.makeTarget()
+ self.bugtask = self.makeBugTask()
+ self.bug = self.bugtask.bug
+ self.subscription = self.target.addSubscription(
+ self.ordinary_subscriber, self.ordinary_subscriber)
+ self.initial_filter = self.subscription.bug_filters[0]
+
+ def assertSubscribers(
+ self, expected_subscribers, level=BugNotificationLevel.NOTHING):
+ observed_subscribers = list(
+ get_structural_subscribers(self.bugtask, None, level))
+ self.assertEqual(expected_subscribers, observed_subscribers)
+
+ def test_getStructuralSubscribers(self):
+ # If no one has a filtered subscription for the given bug, the result
+ # of get_structural_subscribers() is the same as for
+ # the set of people from each subscription in getSubscriptions().
+ subscriptions = self.target.getSubscriptions()
+ self.assertSubscribers([sub.subscriber for sub in subscriptions])
+
+ def test_getStructuralSubscribers_with_filter_on_status(self):
+ # If a status filter exists for a subscription, the result of
+ # get_structural_subscribers() may be a subset of getSubscriptions().
+
+ # Without any filters the subscription is found.
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ # Filter the subscription to bugs in the CONFIRMED state.
+ self.initial_filter.statuses = [BugTaskStatus.CONFIRMED]
+
+ # With the filter the subscription is not found.
+ self.assertSubscribers([])
+
+ # If the filter is adjusted, the subscription is found again.
+ self.initial_filter.statuses = [self.bugtask.status]
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ def test_getStructuralSubscribers_with_filter_on_importance(self):
+ # If an importance filter exists for a subscription, the result of
+ # get_structural_subscribers() may be a subset of getSubscriptions().
+
+ # Without any filters the subscription is found.
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ # Filter the subscription to bugs in the CRITICAL state.
+ self.initial_filter.importances = [BugTaskImportance.CRITICAL]
+
+ # With the filter the subscription is not found.
+ self.assertSubscribers([])
+
+ # If the filter is adjusted, the subscription is found again.
+ self.initial_filter.importances = [self.bugtask.importance]
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ def test_getStructuralSubscribers_with_filter_on_level(self):
+ # All structural subscriptions have a level for bug notifications
+ # which get_structural_subscribers() observes.
+
+ # Adjust the subscription level to METADATA.
+ self.initial_filter.bug_notification_level = (
+ BugNotificationLevel.METADATA)
+
+ # The subscription is found when looking for NOTHING or above.
+ self.assertSubscribers(
+ [self.ordinary_subscriber], BugNotificationLevel.NOTHING)
+ # The subscription is found when looking for METADATA or above.
+ self.assertSubscribers(
+ [self.ordinary_subscriber], BugNotificationLevel.METADATA)
+ # The subscription is not found when looking for COMMENTS or above.
+ self.assertSubscribers(
+ [], BugNotificationLevel.COMMENTS)
+
+ def test_getStructuralSubscribers_with_filter_include_any_tags(self):
+ # If a subscription filter has include_any_tags, a bug with one or
+ # more tags is matched.
+
+ self.initial_filter.include_any_tags = True
+
+ # Without any tags the subscription is not found.
+ self.assertSubscribers([])
+
+ # With any tag the subscription is found.
+ self.bug.tags = ["foo"]
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ def test_getStructuralSubscribers_with_filter_exclude_any_tags(self):
+ # If a subscription filter has exclude_any_tags, only bugs with no
+ # tags are matched.
+
+ self.initial_filter.exclude_any_tags = True
+
+ # Without any tags the subscription is found.
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ # With any tag the subscription is not found.
+ self.bug.tags = ["foo"]
+ self.assertSubscribers([])
+
+ def test_getStructuralSubscribers_with_filter_for_any_tag(self):
+ # If a subscription filter specifies that any of one or more specific
+ # tags must be present, bugs with any of those tags are matched.
+
+ # Looking for either the "foo" or the "bar" tag.
+ self.initial_filter.tags = [u"foo", u"bar"]
+ self.initial_filter.find_all_tags = False
+
+ # Without either tag the subscription is not found.
+ self.assertSubscribers([])
+
+ # With either tag the subscription is found.
+ self.bug.tags = ["bar", "baz"]
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ def test_getStructuralSubscribers_with_filter_for_all_tags(self):
+ # If a subscription filter specifies that all of one or more specific
+ # tags must be present, bugs with all of those tags are matched.
+
+ # Looking for both the "foo" and the "bar" tag.
+ self.initial_filter.tags = [u"foo", u"bar"]
+ self.initial_filter.find_all_tags = True
+
+ # Without either tag the subscription is not found.
+ self.assertSubscribers([])
+
+ # Without only one of the required tags the subscription is not found.
+ self.bug.tags = ["foo"]
+ self.assertSubscribers([])
+
+ # With both required tags the subscription is found.
+ self.bug.tags = ["foo", "bar"]
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ def test_getStructuralSubscribers_with_filter_for_not_any_tag(self):
+ # If a subscription filter specifies that any of one or more specific
+ # tags must not be present, bugs without any of those tags are
+ # matched.
+
+ # Looking to exclude the "foo" or "bar" tags.
+ self.initial_filter.tags = [u"-foo", u"-bar"]
+ self.initial_filter.find_all_tags = False
+
+ # Without either tag the subscription is found.
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ # With both tags, the subscription is omitted.
+ self.bug.tags = ["foo", "bar"]
+ self.assertSubscribers([])
+
+ # With only one tag, the subscription is found again.
+ self.bug.tags = ["foo"]
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ # However, if find_all_tags is True, even a single excluded tag
+ # causes the subscription to be skipped.
+ self.initial_filter.find_all_tags = True
+ self.assertSubscribers([])
+
+ # This is also true, of course, if the bug has both tags.
+ self.bug.tags = ["foo", "bar"]
+ self.assertSubscribers([])
+
+ def test_getStructuralSubscribers_with_filter_for_not_all_tags(self):
+ # If a subscription filter specifies that all of one or more specific
+ # tags must not be present, bugs without all of those tags are
+ # matched.
+
+ # Looking to exclude the "foo" and "bar" tags.
+ self.initial_filter.tags = [u"-foo", u"-bar"]
+ self.initial_filter.find_all_tags = True
+
+ # Without either tag the subscription is found.
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ # With only one of the excluded tags the subscription is not
+ # found--we are saying that we want to find both an absence of foo
+ # and an absence of bar, and yet foo exists.
+ self.bug.tags = ["foo"]
+ self.assertSubscribers([])
+
+ # With both tags the subscription is also not found.
+ self.bug.tags = ["foo", "bar"]
+ self.assertSubscribers([])
+
+ def test_getStructuralSubscribers_with_multiple_filters(self):
+ # If multiple filters exist for a subscription, all filters must
+ # match.
+
+ # Add the "foo" tag to the bug.
+ self.bug.tags = ["foo"]
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ # Filter the subscription to bugs in the CRITICAL state.
+ self.initial_filter.statuses = [BugTaskStatus.CONFIRMED]
+ self.initial_filter.importances = [BugTaskImportance.CRITICAL]
+
+ # With the filter the subscription is not found.
+ self.assertSubscribers([])
+
+ # If the filter is adjusted to match status but not importance, the
+ # subscription is still not found.
+ self.initial_filter.statuses = [self.bugtask.status]
+ self.assertSubscribers([])
+
+ # If the filter is adjusted to also match importance, the subscription
+ # is found again.
+ self.initial_filter.importances = [self.bugtask.importance]
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ # If the filter is given some tag criteria, the subscription is not
+ # found.
+ self.initial_filter.tags = [u"-foo", u"bar", u"baz"]
+ self.initial_filter.find_all_tags = False
+ self.assertSubscribers([])
+
+ # After removing the "foo" tag and adding the "bar" tag, the
+ # subscription is found.
+ self.bug.tags = ["bar"]
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ # Requiring that all tag criteria are fulfilled causes the
+ # subscription to no longer be found.
+ self.initial_filter.find_all_tags = True
+ self.assertSubscribers([])
+
+ # After adding the "baz" tag, the subscription is found again.
+ self.bug.tags = ["bar", "baz"]
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ def test_getStructuralSubscribers_any_filter_is_a_match(self):
+ # If a subscription has multiple filters, the subscription is selected
+ # when any filter is found to match. Put another way, the filters are
+ # ORed together.
+ subscription_filter1 = self.initial_filter
+ subscription_filter1.statuses = [BugTaskStatus.CONFIRMED]
+ subscription_filter2 = self.subscription.newBugFilter()
+ subscription_filter2.tags = [u"foo"]
+
+ # With the filter the subscription is not found.
+ self.assertSubscribers([])
+
+ # If the bugtask is adjusted to match the criteria of the first filter
+ # but not those of the second, the subscription is found.
+ self.bugtask.transitionToStatus(
+ BugTaskStatus.CONFIRMED, self.ordinary_subscriber)
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ # If the filter is adjusted to also match the criteria of the second
+ # filter, the subscription is still found.
+ self.bugtask.bug.tags = [u"foo"]
+ self.assertSubscribers([self.ordinary_subscriber])
+
+ # If the bugtask is adjusted to no longer match the criteria of the
+ # first filter, the subscription is still found.
+ self.bugtask.transitionToStatus(
+ BugTaskStatus.INPROGRESS, self.ordinary_subscriber)
+ self.assertSubscribers([self.ordinary_subscriber])
+
+
+class TestStructuralSubscriptionFiltersForDistro(
+ FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
+
+ def makeTarget(self):
+ return self.factory.makeDistribution()
+
+
+class TestStructuralSubscriptionFiltersForProduct(
+ FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
+
+ def makeTarget(self):
+ return self.factory.makeProduct()
+
+
+class TestStructuralSubscriptionFiltersForDistroSourcePackage(
+ FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
+
+ def makeTarget(self):
+ return self.factory.makeDistributionSourcePackage()
+
+
+class TestStructuralSubscriptionFiltersForMilestone(
+ FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
+
+ def makeTarget(self):
+ return self.factory.makeMilestone()
+
+ def makeBugTask(self):
+ bug = self.factory.makeBug(milestone=self.target)
+ return bug.bugtasks[0]
+
+
+class TestStructuralSubscriptionFiltersForDistroSeries(
+ FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
+
+ def makeTarget(self):
+ return self.factory.makeDistroSeries()
+
+
+class TestStructuralSubscriptionFiltersForProjectGroup(
+ FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
+
+ def makeTarget(self):
+ return self.factory.makeProject()
+
+ def makeBugTask(self):
+ return self.factory.makeBugTask(
+ target=self.factory.makeProduct(project=self.target))
+
+
+class TestStructuralSubscriptionFiltersForProductSeries(
+ FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
+
+ def makeTarget(self):
+ return self.factory.makeProductSeries()
=== modified file 'lib/lp/bugs/tests/test_structuralsubscriptiontarget.py'
--- lib/lp/bugs/tests/test_structuralsubscriptiontarget.py 2011-03-07 16:14:58 +0000
+++ lib/lp/bugs/tests/test_structuralsubscriptiontarget.py 2011-03-07 16:14:59 +0000
@@ -27,20 +27,12 @@
LaunchpadFunctionalLayer,
LaunchpadZopelessLayer,
)
-from lp.bugs.enum import BugNotificationLevel
from lp.bugs.interfaces.bug import CreateBugParams
-from lp.bugs.interfaces.bugtask import (
- BugTaskImportance,
- BugTaskStatus,
- )
from lp.bugs.interfaces.structuralsubscription import (
IStructuralSubscriptionTarget,
IStructuralSubscriptionTargetHelper,
)
-from lp.bugs.model.structuralsubscription import (
- get_structural_subscribers,
- StructuralSubscription,
- )
+from lp.bugs.model.structuralsubscription import StructuralSubscription
from lp.bugs.tests.test_bugtarget import bugtarget_filebug
from lp.registry.errors import (
DeleteSubscriptionError,
@@ -175,279 +167,6 @@
None)
-class FilteredStructuralSubscriptionTestBase:
- """Tests for filtered structural subscriptions."""
-
- layer = LaunchpadFunctionalLayer
-
- def makeTarget(self):
- raise NotImplementedError(self.makeTarget)
-
- def makeBugTask(self):
- return self.factory.makeBugTask(target=self.target)
-
- def setUp(self):
- super(FilteredStructuralSubscriptionTestBase, self).setUp()
- self.ordinary_subscriber = self.factory.makePerson()
- login_person(self.ordinary_subscriber)
- self.target = self.makeTarget()
- self.bugtask = self.makeBugTask()
- self.bug = self.bugtask.bug
- self.subscription = self.target.addSubscription(
- self.ordinary_subscriber, self.ordinary_subscriber)
- self.initial_filter = self.subscription.bug_filters[0]
-
- def assertSubscribers(
- self, expected_subscribers, level=BugNotificationLevel.NOTHING):
- observed_subscribers = list(
- get_structural_subscribers(self.bugtask, None, level))
- self.assertEqual(expected_subscribers, observed_subscribers)
-
- def test_getStructuralSubscribers(self):
- # If no one has a filtered subscription for the given bug, the result
- # of get_structural_subscribers() is the same as for
- # the set of people from each subscription in getSubscriptions().
- subscriptions = self.target.getSubscriptions()
- self.assertSubscribers([sub.subscriber for sub in subscriptions])
-
- def test_getStructuralSubscribers_with_filter_on_status(self):
- # If a status filter exists for a subscription, the result of
- # get_structural_subscribers() may be a subset of getSubscriptions().
-
- # Without any filters the subscription is found.
- self.assertSubscribers([self.ordinary_subscriber])
-
- # Filter the subscription to bugs in the CONFIRMED state.
- self.initial_filter.statuses = [BugTaskStatus.CONFIRMED]
-
- # With the filter the subscription is not found.
- self.assertSubscribers([])
-
- # If the filter is adjusted, the subscription is found again.
- self.initial_filter.statuses = [self.bugtask.status]
- self.assertSubscribers([self.ordinary_subscriber])
-
- def test_getStructuralSubscribers_with_filter_on_importance(self):
- # If an importance filter exists for a subscription, the result of
- # get_structural_subscribers() may be a subset of getSubscriptions().
-
- # Without any filters the subscription is found.
- self.assertSubscribers([self.ordinary_subscriber])
-
- # Filter the subscription to bugs in the CRITICAL state.
- self.initial_filter.importances = [BugTaskImportance.CRITICAL]
-
- # With the filter the subscription is not found.
- self.assertSubscribers([])
-
- # If the filter is adjusted, the subscription is found again.
- self.initial_filter.importances = [self.bugtask.importance]
- self.assertSubscribers([self.ordinary_subscriber])
-
- def test_getStructuralSubscribers_with_filter_on_level(self):
- # All structural subscriptions have a level for bug notifications
- # which get_structural_subscribers() observes.
-
- # Adjust the subscription level to METADATA.
- self.initial_filter.bug_notification_level = (
- BugNotificationLevel.METADATA)
-
- # The subscription is found when looking for NOTHING or above.
- self.assertSubscribers(
- [self.ordinary_subscriber], BugNotificationLevel.NOTHING)
- # The subscription is found when looking for METADATA or above.
- self.assertSubscribers(
- [self.ordinary_subscriber], BugNotificationLevel.METADATA)
- # The subscription is not found when looking for COMMENTS or above.
- self.assertSubscribers(
- [], BugNotificationLevel.COMMENTS)
-
- def test_getStructuralSubscribers_with_filter_include_any_tags(self):
- # If a subscription filter has include_any_tags, a bug with one or
- # more tags is matched.
-
- self.initial_filter.include_any_tags = True
-
- # Without any tags the subscription is not found.
- self.assertSubscribers([])
-
- # With any tag the subscription is found.
- self.bug.tags = ["foo"]
- self.assertSubscribers([self.ordinary_subscriber])
-
- def test_getStructuralSubscribers_with_filter_exclude_any_tags(self):
- # If a subscription filter has exclude_any_tags, only bugs with no
- # tags are matched.
-
- self.initial_filter.exclude_any_tags = True
-
- # Without any tags the subscription is found.
- self.assertSubscribers([self.ordinary_subscriber])
-
- # With any tag the subscription is not found.
- self.bug.tags = ["foo"]
- self.assertSubscribers([])
-
- def test_getStructuralSubscribers_with_filter_for_any_tag(self):
- # If a subscription filter specifies that any of one or more specific
- # tags must be present, bugs with any of those tags are matched.
-
- # Looking for either the "foo" or the "bar" tag.
- self.initial_filter.tags = [u"foo", u"bar"]
- self.initial_filter.find_all_tags = False
-
- # Without either tag the subscription is not found.
- self.assertSubscribers([])
-
- # With either tag the subscription is found.
- self.bug.tags = ["bar", "baz"]
- self.assertSubscribers([self.ordinary_subscriber])
-
- def test_getStructuralSubscribers_with_filter_for_all_tags(self):
- # If a subscription filter specifies that all of one or more specific
- # tags must be present, bugs with all of those tags are matched.
-
- # Looking for both the "foo" and the "bar" tag.
- self.initial_filter.tags = [u"foo", u"bar"]
- self.initial_filter.find_all_tags = True
-
- # Without either tag the subscription is not found.
- self.assertSubscribers([])
-
- # Without only one of the required tags the subscription is not found.
- self.bug.tags = ["foo"]
- self.assertSubscribers([])
-
- # With both required tags the subscription is found.
- self.bug.tags = ["foo", "bar"]
- self.assertSubscribers([self.ordinary_subscriber])
-
- def test_getStructuralSubscribers_with_filter_for_not_any_tag(self):
- # If a subscription filter specifies that any of one or more specific
- # tags must not be present, bugs without any of those tags are
- # matched.
-
- # Looking to exclude the "foo" or "bar" tags.
- self.initial_filter.tags = [u"-foo", u"-bar"]
- self.initial_filter.find_all_tags = False
-
- # Without either tag the subscription is found.
- self.assertSubscribers([self.ordinary_subscriber])
-
- # With both tags, the subscription is omitted.
- self.bug.tags = ["foo", "bar"]
- self.assertSubscribers([])
-
- # With only one tag, the subscription is found again.
- self.bug.tags = ["foo"]
- self.assertSubscribers([self.ordinary_subscriber])
-
- # However, if find_all_tags is True, even a single excluded tag
- # causes the subscription to be skipped.
- self.initial_filter.find_all_tags = True
- self.assertSubscribers([])
-
- # This is also true, of course, if the bug has both tags.
- self.bug.tags = ["foo", "bar"]
- self.assertSubscribers([])
-
- def test_getStructuralSubscribers_with_filter_for_not_all_tags(self):
- # If a subscription filter specifies that all of one or more specific
- # tags must not be present, bugs without all of those tags are
- # matched.
-
- # Looking to exclude the "foo" and "bar" tags.
- self.initial_filter.tags = [u"-foo", u"-bar"]
- self.initial_filter.find_all_tags = True
-
- # Without either tag the subscription is found.
- self.assertSubscribers([self.ordinary_subscriber])
-
- # With only one of the excluded tags the subscription is not
- # found--we are saying that we want to find both an absence of foo
- # and an absence of bar, and yet foo exists.
- self.bug.tags = ["foo"]
- self.assertSubscribers([])
-
- # With both tags the subscription is also not found.
- self.bug.tags = ["foo", "bar"]
- self.assertSubscribers([])
-
- def test_getStructuralSubscribers_with_multiple_filters(self):
- # If multiple filters exist for a subscription, all filters must
- # match.
-
- # Add the "foo" tag to the bug.
- self.bug.tags = ["foo"]
- self.assertSubscribers([self.ordinary_subscriber])
-
- # Filter the subscription to bugs in the CRITICAL state.
- self.initial_filter.statuses = [BugTaskStatus.CONFIRMED]
- self.initial_filter.importances = [BugTaskImportance.CRITICAL]
-
- # With the filter the subscription is not found.
- self.assertSubscribers([])
-
- # If the filter is adjusted to match status but not importance, the
- # subscription is still not found.
- self.initial_filter.statuses = [self.bugtask.status]
- self.assertSubscribers([])
-
- # If the filter is adjusted to also match importance, the subscription
- # is found again.
- self.initial_filter.importances = [self.bugtask.importance]
- self.assertSubscribers([self.ordinary_subscriber])
-
- # If the filter is given some tag criteria, the subscription is not
- # found.
- self.initial_filter.tags = [u"-foo", u"bar", u"baz"]
- self.initial_filter.find_all_tags = False
- self.assertSubscribers([])
-
- # After removing the "foo" tag and adding the "bar" tag, the
- # subscription is found.
- self.bug.tags = ["bar"]
- self.assertSubscribers([self.ordinary_subscriber])
-
- # Requiring that all tag criteria are fulfilled causes the
- # subscription to no longer be found.
- self.initial_filter.find_all_tags = True
- self.assertSubscribers([])
-
- # After adding the "baz" tag, the subscription is found again.
- self.bug.tags = ["bar", "baz"]
- self.assertSubscribers([self.ordinary_subscriber])
-
- def test_getStructuralSubscribers_any_filter_is_a_match(self):
- # If a subscription has multiple filters, the subscription is selected
- # when any filter is found to match. Put another way, the filters are
- # ORed together.
- subscription_filter1 = self.initial_filter
- subscription_filter1.statuses = [BugTaskStatus.CONFIRMED]
- subscription_filter2 = self.subscription.newBugFilter()
- subscription_filter2.tags = [u"foo"]
-
- # With the filter the subscription is not found.
- self.assertSubscribers([])
-
- # If the bugtask is adjusted to match the criteria of the first filter
- # but not those of the second, the subscription is found.
- self.bugtask.transitionToStatus(
- BugTaskStatus.CONFIRMED, self.ordinary_subscriber)
- self.assertSubscribers([self.ordinary_subscriber])
-
- # If the filter is adjusted to also match the criteria of the second
- # filter, the subscription is still found.
- self.bugtask.bug.tags = [u"foo"]
- self.assertSubscribers([self.ordinary_subscriber])
-
- # If the bugtask is adjusted to no longer match the criteria of the
- # first filter, the subscription is still found.
- self.bugtask.transitionToStatus(
- BugTaskStatus.INPROGRESS, self.ordinary_subscriber)
- self.assertSubscribers([self.ordinary_subscriber])
-
-
class TestStructuralSubscriptionForDistro(
RestrictedStructuralSubscriptionTestBase, TestCaseWithFactory):
@@ -512,13 +231,6 @@
StructuralSubscription)
-class TestStructuralSubscriptionFiltersForDistro(
- FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
-
- def makeTarget(self):
- return self.factory.makeDistribution()
-
-
class TestStructuralSubscriptionForProduct(
UnrestrictedStructuralSubscriptionTestBase, TestCaseWithFactory):
@@ -529,13 +241,6 @@
self.target = self.factory.makeProduct()
-class TestStructuralSubscriptionFiltersForProduct(
- FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
-
- def makeTarget(self):
- return self.factory.makeProduct()
-
-
class TestStructuralSubscriptionForDistroSourcePackage(
UnrestrictedStructuralSubscriptionTestBase, TestCaseWithFactory):
@@ -547,13 +252,6 @@
self.target = ProxyFactory(self.target)
-class TestStructuralSubscriptionFiltersForDistroSourcePackage(
- FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
-
- def makeTarget(self):
- return self.factory.makeDistributionSourcePackage()
-
-
class TestStructuralSubscriptionForMilestone(
UnrestrictedStructuralSubscriptionTestBase, TestCaseWithFactory):
@@ -565,17 +263,6 @@
self.target = ProxyFactory(self.target)
-class TestStructuralSubscriptionFiltersForMilestone(
- FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
-
- def makeTarget(self):
- return self.factory.makeMilestone()
-
- def makeBugTask(self):
- bug = self.factory.makeBug(milestone=self.target)
- return bug.bugtasks[0]
-
-
class TestStructuralSubscriptionForDistroSeries(
UnrestrictedStructuralSubscriptionTestBase, TestCaseWithFactory):
@@ -587,13 +274,6 @@
self.target = ProxyFactory(self.target)
-class TestStructuralSubscriptionFiltersForDistroSeries(
- FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
-
- def makeTarget(self):
- return self.factory.makeDistroSeries()
-
-
class TestStructuralSubscriptionForProjectGroup(
UnrestrictedStructuralSubscriptionTestBase, TestCaseWithFactory):
@@ -605,17 +285,6 @@
self.target = ProxyFactory(self.target)
-class TestStructuralSubscriptionFiltersForProjectGroup(
- FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
-
- def makeTarget(self):
- return self.factory.makeProject()
-
- def makeBugTask(self):
- return self.factory.makeBugTask(
- target=self.factory.makeProduct(project=self.target))
-
-
class TestStructuralSubscriptionForProductSeries(
UnrestrictedStructuralSubscriptionTestBase, TestCaseWithFactory):
@@ -627,13 +296,6 @@
self.target = ProxyFactory(self.target)
-class TestStructuralSubscriptionFiltersForProductSeries(
- FilteredStructuralSubscriptionTestBase, TestCaseWithFactory):
-
- def makeTarget(self):
- return self.factory.makeProductSeries()
-
-
class TestStructuralSubscriptionTargetHelper(TestCaseWithFactory):
"""Tests for implementations of `IStructuralSubscriptionTargetHelper`."""
