launchpad-reviewers team mailing list archive

[Huw Wilkins <huw.wilkins@xxxxxxxxxxxxx>]

The proposal to merge lp:~huwshimi/launchpad/private-objects-298152 into lp:launchpad has been updated.

Description changed to:

The current style for notifying private bugs is not obvious enough. After some discussion I created a new style that overlays a banner at the top of the page that scrolls with it.

The banner can be closed, and when closed the privacy portlet should fade to red.

To test the notification you'll need a bug that has been marked private and you'll need to set the flag with 'bugs.private_notification.enabled default 1 on' on https://launchpad.dev/+feature-rules

Here is a screenshot of this change: http://launchpadlibrarian.net/66331334/privacy_red.png

For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/private-objects-298152/+merge/53195
-- 
https://code.launchpad.net/~huwshimi/launchpad/private-objects-298152/+merge/53195
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/private-objects-298152 into lp:launchpad.