launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

Gavin Panella has proposed merging lp:~allenap/launchpad/alt-javascript-build-less-noisy into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #734801 in Launchpad itself: "Building unminified launchpad.js uses debug builds of YUI which are too noisy"
  https://bugs.launchpad.net/launchpad/+bug/734801

For more details, see:
https://code.launchpad.net/~allenap/launchpad/alt-javascript-build-less-noisy/+merge/53269

Updates the recent changes to the launchpad.js build process to create a "raw" (i.e. non-debug, non-minified) build by default.
-- 
https://code.launchpad.net/~allenap/launchpad/alt-javascript-build-less-noisy/+merge/53269
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/launchpad/alt-javascript-build-less-noisy into lp:launchpad.

=== modified file 'Makefile'
--- Makefile	2011-03-11 11:49:56 +0000
+++ Makefile	2011-03-14 16:23:58 +0000
@@ -21,12 +21,12 @@
 LAZR_BUILT_JS_ROOT=lazr-js/build
 
 ifeq ($(LPCONFIG), development)
-JS_BUILD := debug
+JS_BUILD := raw
 else
 JS_BUILD := min
 endif
 
-JS_YUI := $(shell utilities/yui-deps.py $(JS_BUILD))
+JS_YUI := $(shell utilities/yui-deps.py $(JS_BUILD:raw=))
 JS_LAZR := $(LAZR_BUILT_JS_ROOT)/lazr.js
 JS_OTHER := $(wildcard lib/canonical/launchpad/javascript/*/*.js)
 JS_LP := $(shell find lib/lp/*/javascript ! -path '*/tests/*' -name '*.js')