← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~huwshimi/launchpad/private-objects-298152 into lp:launchpad

 

> 1- stackoverflow etc show the ribbon above (y-axis) the page content,
> rather than overlaid on it (z-axis), so it does not obscure any
> content.

That screenshot was probably not the best. This banner works exactly like the banner on Stackoverflow. That screenshot shows the page scrolled down a bit but it does push the content down when you're at the top of the page.

> 
> 2- The current hashmarks have the advantage that you can still see the
> bug is private when you have scrolled down the page, and it's very
> common for bugs to be more than one screen long.

Again, like Stackoverflow the banner stays at the top of the visible area.
-- 
https://code.launchpad.net/~huwshimi/launchpad/private-objects-298152/+merge/53195
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/private-objects-298152 into lp:launchpad.



Follow ups

References