launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Stuart Bishop has proposed merging lp:~stub/launchpad/pending-db-changes into lp:launchpad/db-devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #689642 in Launchpad itself: "Database patches without a trailing semi-colon fail in replicated environment"
  https://bugs.launchpad.net/launchpad/+bug/689642
  Bug #726128 in Launchpad itself: "staging restore script creates invalid feature rule"
  https://bugs.launchpad.net/launchpad/+bug/726128

For more details, see:
https://code.launchpad.net/~stub/launchpad/pending-db-changes/+merge/54520

Renaming a primary key index breaks Slony-I, so don't do that.
-- 
https://code.launchpad.net/~stub/launchpad/pending-db-changes/+merge/54520
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stub/launchpad/pending-db-changes into lp:launchpad/db-devel.

=== modified file 'database/schema/patch-2208-56-0.sql'
--- database/schema/patch-2208-56-0.sql	2011-03-18 11:19:52 +0000
+++ database/schema/patch-2208-56-0.sql	2011-03-23 13:34:42 +0000
@@ -21,8 +21,9 @@
     RENAME TO distroseries__registrant__idx;
 
 -- Rename old misnamed indexes.
-ALTER INDEX distrorelease_pkey
-    RENAME TO distroseries_pkey;
+-- Don't rename primary key indexes though, as this causes Slony-I to explode.
+--ALTER INDEX distrorelease_pkey
+--    RENAME TO distroseries_pkey;
 ALTER INDEX distrorelease_distribution_key
     RENAME TO distrorelease__distribution__name__key;
 ALTER INDEX distrorelease_distro_release_unique