launchpad-reviewers team mailing list archive

[Huw Wilkins <huw.wilkins@xxxxxxxxxxxxx>]

Huw Wilkins has proposed merging lp:~huwshimi/launchpad/browse-links-746104 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #746104 in Launchpad itself: ""view the branch content" phraseology is pointlessly confusing"
  https://bugs.launchpad.net/launchpad/+bug/746104

For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/browse-links-746104/+merge/55667

The links to browse a branch were "View the branch content" and while this is very correct it requires quite a lot cognition.

Following a discussion we decided "Browse the code" was a better and more widely recognised label. This is not correct in the case where the branch does not contain any code, but I think it is better to have a label that is more understandable.
-- 
https://code.launchpad.net/~huwshimi/launchpad/browse-links-746104/+merge/55667
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/browse-links-746104 into lp:launchpad.

=== modified file 'lib/lp/code/browser/branch.py'
--- lib/lp/code/browser/branch.py	2011-03-08 21:51:56 +0000
+++ lib/lp/code/browser/branch.py	2011-03-31 03:15:49 +0000
@@ -360,7 +360,7 @@
 
     def source(self):
         """Return a link to the branch's file listing on codebrowse."""
-        text = 'View the branch content'
+        text = 'Browse the code'
         enabled = self.context.code_is_browseable
         url = self.context.codebrowse_url('files')
         return Link(url, text, icon='info', enabled=enabled)

=== modified file 'lib/lp/code/stories/branches/xx-branch-index.txt'
--- lib/lp/code/stories/branches/xx-branch-index.txt	2010-10-18 22:24:59 +0000
+++ lib/lp/code/stories/branches/xx-branch-index.txt	2011-03-31 03:15:49 +0000
@@ -197,7 +197,7 @@
     >>> print extract_text(get_branch_management_portlet())
     Only Sample Person can upload to this branch.
     If you are Sample Person please log in for upload directions.
-    View the branch content
+    Browse the code
 
 For mirrored branches, the table has a link to the branch's project, the
 location of the original branch, the mirror on Launchpad, information

=== modified file 'lib/lp/registry/stories/product/xx-product-development-focus.txt'
--- lib/lp/registry/stories/product/xx-product-development-focus.txt	2010-09-03 08:36:32 +0000
+++ lib/lp/registry/stories/product/xx-product-development-focus.txt	2011-03-31 03:15:49 +0000
@@ -97,7 +97,7 @@
     Development focus:
     trunk series Change details
     lp://dev/fooix Change branch
-    View the branch content
+    Browse the code
 
 
 Projects with development focus branches
@@ -114,11 +114,11 @@
     Development focus:
     trunk series
     lp://dev/fooix
-    View the branch content
+    Browse the code
     Links:
       trunk series (/fooix/trunk)
       lp://dev/fooix (http://code.launchpad.dev/~eric/fooix/trunk)
-      View the branch content
+      Browse the code
         (http://bazaar.launchpad.dev/~eric/fooix/trunk/files)
 
     >>> owner_browser.open('http://launchpad.dev/fooix')
@@ -126,7 +126,7 @@
     Development focus:
     trunk series     Change details
     lp://dev/fooix   Change branch
-    View the branch content
+    Browse the code
     Links:
       trunk series (/fooix/trunk)
       <span class="invisible-link">Change details</span>
@@ -135,7 +135,7 @@
       <span class="invisible-link">Change branch</span>
       Change the branch for this series
         (http://launchpad.dev/fooix/trunk/+linkbranch)
-      View the branch content
+      Browse the code
         (http://bazaar.launchpad.dev/~eric/fooix/trunk/files)
 
 
@@ -162,7 +162,7 @@
     Development focus:
     trunk series     Change details
     lp://dev/fooix   Change branch
-    View the branch content
+    Browse the code
     Links:
       trunk series (/fooix/trunk)
       <span class="invisible-link">Change details</span>
@@ -171,5 +171,5 @@
       <span class="invisible-link">Change branch</span>
       Change the branch for this series
         (http://launchpad.dev/fooix/trunk/+linkbranch)
-      View the branch content
+      Browse the code
         (https://bazaar.launchpad.dev/~eric/fooix/trunk/files)

=== modified file 'lib/lp/registry/stories/productseries/xx-productseries-link-branch.txt'
--- lib/lp/registry/stories/productseries/xx-productseries-link-branch.txt	2011-03-23 16:28:51 +0000
+++ lib/lp/registry/stories/productseries/xx-productseries-link-branch.txt	2011-03-31 03:15:49 +0000
@@ -65,7 +65,7 @@
     lp://dev/firefox - Sample Person
     Change branch
 
-    >>> print sample_browser.getLink('View the branch content').url
+    >>> print sample_browser.getLink('Browse the code').url
     http://bazaar.launchpad.dev/~name12/firefox/main/files
 
 The total and recent revision counts for the branch are displayed to