launchpad-reviewers team mailing list archive

[Huw Wilkins <huw.wilkins@xxxxxxxxxxxxx>]

Huw Wilkins has proposed merging lp:~huwshimi/launchpad/ie-comment-button-414747 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #414747 in Launchpad itself: "No comment submit button on IE"
  https://bugs.launchpad.net/launchpad/+bug/414747

For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/ie-comment-button-414747/+merge/56094

The Post Comment button was hidden in IE. This was because IE does not get AJAX comment submissions and we had some left over code from a previous iteration of comments hiding the button.

We now use the existing button rather than replacing it with a link, so the code that hid the button is no longer required.
-- 
https://code.launchpad.net/~huwshimi/launchpad/ie-comment-button-414747/+merge/56094
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/ie-comment-button-414747 into lp:launchpad.

=== modified file 'lib/lp/bugs/templates/bugtask-index.pt'
--- lib/lp/bugs/templates/bugtask-index.pt	2011-03-30 08:53:48 +0000
+++ lib/lp/bugs/templates/bugtask-index.pt	2011-04-04 01:34:28 +0000
@@ -312,20 +312,6 @@
                   tal:content="structure
                   comment_form/actions/field.actions.save/render" />
               </form>
-              <tal:comment condition="nothing">
-                <!-- If javascript is enabled, hide the Save Changes button.
-                It will be replaced later by an "Add comment" link,
-                which does commenting inline. The reason for hiding the
-                button is that it's kind of ugly having it transformed
-                into a link. Better to hide it and have it appear after
-                a while. At some point we should be able to hook up
-                inline commenting earlier than in the on-load handler,
-                which would make this hack not needed. -->
-              </tal:comment>
-              <script type="text/javascript">
-                var button = document.getElementById('field.actions.save');
-                button.style.display = 'none';
-              </script>
               <script type="text/javascript">
                 LPS.use('lp.app.comment', function(Y) {
                     var comment = new Y.lp.app.comment.Comment();