launchpad-reviewers team mailing list archive

[Raphaël Victor Badin <raphael.badin@xxxxxxxxxxxxx>]

Raphaël Victor Badin has proposed merging lp:~rvb/launchpad/dds-fix-spinner-50391 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #750391 in Launchpad itself: "Throbbing in the wrong place"
  https://bugs.launchpad.net/launchpad/+bug/750391

For more details, see:
https://code.launchpad.net/~rvb/launchpad/dds-fix-spinner-50391/+merge/56199

This branch fixes the location of the spinner displayed when requesting package diffs.

There is no unit test for this because I'm not sure how to test for the location of this _very transient_ spinner.

== QA ==
- Turn on the feature flag :
    'soyuz.derived-series-ui.enabled default 1 on'
- On a local instance access this page:
    https://launchpad.dev/deribuntu/deriwarty/+localpackagediffs?field.name_filter=&field.package_type=blacklisted&field.package_type-empty-marker=1
- Open the alsa-utils row
- Click the "Compute differences from last common version:"
  This should fail but the (short lived) spinner should replace the link you just clicked on (before being replaced by an error message).
-- 
https://code.launchpad.net/~rvb/launchpad/dds-fix-spinner-50391/+merge/56199
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/launchpad/dds-fix-spinner-50391 into lp:launchpad.

=== modified file 'lib/lp/registry/javascript/distroseriesdifferences_details.js'
--- lib/lp/registry/javascript/distroseriesdifferences_details.js	2011-03-31 14:41:30 +0000
+++ lib/lp/registry/javascript/distroseriesdifferences_details.js	2011-04-04 16:14:27 +0000
@@ -493,13 +493,15 @@
 var compute_package_diff = function(container, dsd_link) {
     var in_progress_message = Y.lp.soyuz.base.makeInProgressNode(
         'Computing package diff...');
-    container.append(in_progress_message);
-    container.one('.package-diff-placeholder').set(
-        'text',
-        'Differences from last common version:');
+    var placeholder = container.one('.package-diff-placeholder');
+    placeholder.set('innerHTML','');
+    placeholder.appendChild(in_progress_message);
     var success_cb = function(transaction_id, response, args) {
         container.one('p.update-in-progress-message').remove();
-        container.all('.request-derived-diff').each(function(sub_container){
+        container.one('.package-diff-placeholder').set(
+            'text',
+            'Differences from last common version:');
+         container.all('.request-derived-diff').each(function(sub_container){
            set_package_diff_status(sub_container, 'PENDING', 'Pending');
            // Setup polling
            namespace.setup_pending_package_diff(sub_container, dsd_link);