launchpad-reviewers team mailing list archive

[Julian Edwards <julian.edwards@xxxxxxxxxxxxx>]

Julian Edwards has proposed merging lp:~julian-edwards/launchpad/drivers-need-to-drive-bug-752613 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~julian-edwards/launchpad/drivers-need-to-drive-bug-752613/+merge/56607

= Summary =
Fix permissions on +addseries so distro drivers can create new series.

== Pre-implementation notes ==
Patch from Curtis.

== Implementation details ==
lp.Moderate is now used instead of the erroneous and absent lp.Append!

== Tests ==
bin/test -cvvt distroseries-views.txt

== Demo and Q/A ==
Change is already confirmed working on dogfood.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/browser/configure.zcml
  lib/lp/registry/browser/tests/distroseries-views.txt
  lib/lp/registry/browser/distribution.py
-- 
https://code.launchpad.net/~julian-edwards/launchpad/drivers-need-to-drive-bug-752613/+merge/56607
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~julian-edwards/launchpad/drivers-need-to-drive-bug-752613 into lp:launchpad.

=== modified file 'lib/lp/registry/browser/configure.zcml'
--- lib/lp/registry/browser/configure.zcml	2011-04-06 15:26:34 +0000
+++ lib/lp/registry/browser/configure.zcml	2011-04-06 16:15:29 +0000
@@ -1970,7 +1970,7 @@
         for="lp.registry.interfaces.distribution.IDerivativeDistribution"
         class="lp.registry.browser.distroseries.DistroSeriesAddView"
         facet="overview"
-        permission="launchpad.Append"
+        permission="launchpad.Moderate"
         template="../templates/distroseries-add.pt">
     </browser:page>
     <browser:page

=== modified file 'lib/lp/registry/browser/distribution.py'
--- lib/lp/registry/browser/distribution.py	2011-04-04 18:51:17 +0000
+++ lib/lp/registry/browser/distribution.py	2011-04-06 16:15:29 +0000
@@ -466,7 +466,7 @@
 
     usedfor = IDerivativeDistribution
 
-    @enabled_with_permission('launchpad.Append')
+    @enabled_with_permission('launchpad.Moderate')
     def addseries(self):
         text = 'Add series'
         return Link('+addseries', text, icon='add')

=== modified file 'lib/lp/registry/browser/tests/distroseries-views.txt'
--- lib/lp/registry/browser/tests/distroseries-views.txt	2011-04-04 16:32:02 +0000
+++ lib/lp/registry/browser/tests/distroseries-views.txt	2011-04-06 16:15:29 +0000
@@ -261,7 +261,7 @@
 
     >>> login_person(yo_driver)
     >>> view = create_view(youbuntu, name='+addseries')
-    >>> check_permission('launchpad.Driver', view)
+    >>> check_permission('launchpad.Moderate', view)
     True
 
     >>> yo_form = dict(form)