launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Curtis Hovey has proposed merging lp:~sinzui/launchpad/mailing-list-archiving-2 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~sinzui/launchpad/mailing-list-archiving-2/+merge/56631

Fix the mailing list archive threading presentation.

    Launchpad bug: https://bugs.launchpad.net/bugs/752766
    Pre-implementation: no one
    Test command: ./mmm-archive-manager.py launchpad-users

Threaded messages are not indented to show which message they are subordinate
too. The markup is correct

--------------------------------------------------------------------

RULES

The screenshots in the MP show they are threaded, so a late CSS change
probably broke the presentation. The presentation is fixed (as tested on using
the webkit inspector) with this CSS:
    ul ul {
        margin-left: 2em;
        }


QA

    * Run ./mmm-archive-manager.py launchpad-users on staging
    * Verify that https://lists.staging.launchpad.net/launchpad-users/
      indents the subordinate messages in a thread.


LINT

    lib/lp/services/mailman/monkeypatches/lp-mhonarc-common.mrc


IMPLEMENTATION

Added a general rule to indent subordinate lists.
    lib/lp/services/mailman/monkeypatches/lp-mhonarc-common.mrc
-- 
https://code.launchpad.net/~sinzui/launchpad/mailing-list-archiving-2/+merge/56631
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~sinzui/launchpad/mailing-list-archiving-2 into lp:launchpad.

=== modified file 'lib/lp/services/mailman/monkeypatches/lp-mhonarc-common.mrc'
--- lib/lp/services/mailman/monkeypatches/lp-mhonarc-common.mrc	2011-04-01 03:09:00 +0000
+++ lib/lp/services/mailman/monkeypatches/lp-mhonarc-common.mrc	2011-04-06 18:17:27 +0000
@@ -80,6 +80,9 @@
     margin: 0;
     padding: 0;
     }
+ul ul {
+    margin-left: 2em;
+    }
 .mail li {
     margin-left: 20px;
     padding-left: 0px;