← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~rvb/launchpad/fix-packagediff-request-link into lp:launchpad

 

The proposal to merge lp:~rvb/launchpad/fix-packagediff-request-link into lp:launchpad has been updated.

Description changed to:

This branch fixes the display of the link to compute package diffs when one the package diff is already computed and the other is not but makes no sense as it has the same version as base_version.

= Tests =
./bin/test -cvv test_distroseriesdifference_views test_no_package_diff_parent_same_version
./bin/test -cvv test_distroseriesdifference_views test_no_package_diff_derived_same_version

= QA =
In the first row of the page:
https://dogfood.launchpad.net/ubuntu/natty/+localpackagediffs
The header of the package diff widget should not be a link to compute the package diffs.

For more details, see:
https://code.launchpad.net/~rvb/launchpad/fix-packagediff-request-link/+merge/57727
-- 
https://code.launchpad.net/~rvb/launchpad/fix-packagediff-request-link/+merge/57727
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/launchpad/fix-packagediff-request-link into lp:launchpad.



References