launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/bug-736002-seriously-this-time into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #736002 in Launchpad itself: "Distribution:+bugtarget-portlet-tags-content timeouts"
  https://bugs.launchpad.net/launchpad/+bug/736002

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/bug-736002-seriously-this-time/+merge/58016

bugtarget-portlet-tags-content.pt was evaluating view/tags_cloud_data twice, so it was still timing out. This trivial branch makes it evaluate just once, hopefully avoiding timeouts.
-- 
https://code.launchpad.net/~wgrant/launchpad/bug-736002-seriously-this-time/+merge/58016
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/bug-736002-seriously-this-time into lp:launchpad.

=== modified file 'lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt'
--- lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt	2010-11-09 09:49:12 +0000
+++ lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt	2011-04-17 01:23:26 +0000
@@ -6,7 +6,7 @@
     <tal:tags content="cache:public noparam, 60 minutes">
         <h2 tal:condition="tags_cloud_data">Tags</h2>
         <div style="text-align: justify">
-          <a tal:repeat="tag_info view/tags_cloud_data"
+          <a tal:repeat="tag_info tags_cloud_data"
              tal:content="tag_info/tag"
              tal:attributes="href tag_info/url;
                             style string:font-size: ${tag_info/factor}em" />