launchpad-reviewers team mailing list archive

["j.c.sackett" <jonathan.sackett@xxxxxxxxxxxxx>]

The proposal to merge lp:~jcsackett/launchpad/add-security-audit-utility into lp:launchpad has been updated.

Description changed to:

Summary
=======
database/schema/security.cfg has duplicate entries for permissions under the same section. This caused an error in bug expiration, and has the potential to be a timebomb. There isn't currently anyway of easily checking for these dupes. This utility is an easy way to check.

This branch does not attempt to remove duplicates--some of the duplicate settings are contradictory (one specifies only SELECT, another says SELECT and UPDATE). Another branch can be landed down the line to correct the file, once all duplicates are checked via this utility.

Preimp
======
Spoke with Curtis Hovey

Implementation
==============
Adds a utility which scans security.cfg and reports and duplicates.

QA
==
Run the script in a branch, it will report any dupes.

Lint
====
make lint:

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  utilities/audit-security.py

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/add-security-audit-utility/+merge/58199
-- 
https://code.launchpad.net/~jcsackett/launchpad/add-security-audit-utility/+merge/58199
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/add-security-audit-utility into lp:launchpad.