launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

Robert Collins has proposed merging lp:~lifeless/launchpad/bug-112776 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #112776 in Launchpad itself: ""log out" will error with a 404 and an OOPS code in various pages"
  https://bugs.launchpad.net/launchpad/+bug/112776

For more details, see:
https://code.launchpad.net/~lifeless/launchpad/bug-112776/+merge/58434

Fix ye ancient bug report by not using a url which will traverse possibly inaccessible pages in the course of logging out.
-- 
https://code.launchpad.net/~lifeless/launchpad/bug-112776/+merge/58434
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lifeless/launchpad/bug-112776 into lp:launchpad.

=== modified file 'lib/canonical/launchpad/templates/launchpad-loginstatus.pt'
--- lib/canonical/launchpad/templates/launchpad-loginstatus.pt	2011-03-29 06:00:48 +0000
+++ lib/canonical/launchpad/templates/launchpad-loginstatus.pt	2011-04-20 05:28:27 +0000
@@ -7,7 +7,7 @@
 <div id="logincontrol" tal:condition="view/login_shown"
 ><a tal:attributes="href view/login_url">Log in / Register</a></div>
 <div id="logincontrol" tal:condition="view/logged_in">
-  <form action="+logout" method="post">
+  <form action="/+logout" method="post">
     <input type="hidden" name="loggingout" value="1" />
     <div id="rendertime" tal:condition="request/features/visible_render_time">Loading...</div>
     <div id="ajax-time" tal:condition="request/features/visible_render_time">