launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~jtv/launchpad/db-bug-735621 into lp:launchpad/db-devel

To: mp+58321@xxxxxxxxxxxxxxxxxx
From: Aaron Bentley <aaron@xxxxxxxxxxxxx>
Date: Wed, 20 Apr 2011 14:06:01 -0000
In-reply-to: <20110419150219.31676.61267.launchpad@loganberry.canonical.com>
Reply-to: mp+58321@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Per your comments, I won't review this, but I'm confused about the handling of SECTION.  In the original, it is $(SECTION), and as a shell command, that means "run SECTION and return the contents of stdout" (the same as backticks).  I don't see how this would work with python interpolation, or why you've left it as-is.
-- 
https://code.launchpad.net/~jtv/launchpad/db-bug-735621/+merge/58321
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/db-bug-735621 into lp:launchpad/db-devel.

References

[Merge] lp:~jtv/launchpad/db-bug-735621 into lp:launchpad/db-devel
From: Jeroen T. Vermeulen, 2011-04-19