launchpad-reviewers team mailing list archive

["j.c.sackett" <jonathan.sackett@xxxxxxxxxxxxx>]

The proposal to merge lp:~jcsackett/launchpad/remove-duplicate-settings into lp:launchpad has been updated.

Description changed to:

Summary
=======
Investigating errors occuring in some cronscripts, duplicate security settings were found in database/schema/security.cfg. This has the effect of removing permissions that are needed for some scripts, resulting in failures.

A previous branch created a utiility that identified these duplicates. This branch removes the dupes under the advisement that in each case we want to keep the setting that provides the broadest permissions for the cronscripts.

Preimplementation
=================
Spoke with Curtis Hovey about which settings to keep.

Implementation
==============
database/schema/security.cfg
----------------------------
Removed duplicate settings within each configuration block (e.g. a section beginning with [$SECTION].

Tests
=====
Given the number of things removed, ec2 is the only viable test. This branch has already been submitted.

QA
==
qa-untestable

Lint
====
= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  database/schema/security.cfg
  lib/lp/scripts/utilities/tests/test_audit_security_settings.py
  utilities/audit-security-settings.py

database/schema/security.cfg
    740: Line exceeds 78 characters.
    741: Line exceeds 78 characters.
    742: Line exceeds 78 characters.
    768: Line exceeds 78 characters.
    772: Line exceeds 78 characters.
    827: Line exceeds 78 characters.
    842: Line exceeds 78 characters.
    843: Line exceeds 78 characters.
    859: Line exceeds 78 characters.
    860: Line exceeds 78 characters.
    863: Line exceeds 78 characters.
    864: Line exceeds 78 characters.
    865: Line exceeds 78 characters.
    917: Line exceeds 78 characters.
    918: Line exceeds 78 characters.
    919: Line exceeds 78 characters.
    947: Line exceeds 78 characters.
    1029: Line exceeds 78 characters.
    1039: Line exceeds 78 characters.
    1040: Line exceeds 78 characters.

Errors in security.cfg are a result of the cfg format.

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/remove-duplicate-settings/+merge/58529
-- 
https://code.launchpad.net/~jcsackett/launchpad/remove-duplicate-settings/+merge/58529
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/remove-duplicate-settings into lp:launchpad.